From afbc38c2af66ca570b46146d9cf2edf2812c07fd Mon Sep 17 00:00:00 2001
From: Michael Grote <michael.grote@posteo.de>
Date: Sat, 9 Nov 2024 21:34:39 +0100
Subject: [PATCH] docs

---
 .../mgrote_minio_configure/defaults/main.yml  | 23 ++++++++++---------
 roles/mgrote_minio_configure/tasks/policy.yml |  6 ++---
 2 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/roles/mgrote_minio_configure/defaults/main.yml b/roles/mgrote_minio_configure/defaults/main.yml
index 88633fd8..54e397a4 100644
--- a/roles/mgrote_minio_configure/defaults/main.yml
+++ b/roles/mgrote_minio_configure/defaults/main.yml
@@ -1,15 +1,19 @@
 ---
-minio_root_access_key: pfiDnpEL3rL1CmIedZbD # händisch zu erstellen beium ersten minio aufsetzen
-minio_root_secret_key: Bc2eyAiTxLok0RawYguQJUB0hC8HtvCA7RjYRAfV # händisch zu erstellen beium ersten minio aufsetzen
-minio_root_alias: minio_ansible_root
-minio_url: https://s3.mgrote.net
-minio_config_dir: /etc/minio
+# Client
 minio_client_release: ""
 minio_client_bin: /usr/local/bin/mc
-minio_print_keys: true # zeige secret in playbook
 
-# --dp ausschreiben
+# Allgemeines
+minio_config_dir: /etc/minio
+minio_root_alias: minio_ansible_root
 
+minio_url: https://s3.mgrote.net
+
+# Secrets
+minio_root_access_key: pfiDnpEL3rL1CmIedZbD
+minio_root_secret_key: Bc2eyAiTxLok0RawYguQJUB0hC8HtvCA7RjYRAfV
+
+# User
 minio_users:
   - name: testuser5
     secret: hallowelt
@@ -24,13 +28,10 @@ minio_users:
     state: absent
     policy: testbucket3_ro
 
+# Buckets
 # Anzulegende Buckets, pro Bucket wird eine RW + RO Policy erstellt
 minio_buckets:
   - name: testbucket1
     state: present
   - name: testbucket3
     state: absent
-
-
-# auf docker10 aufraumen
-# und irtantu
diff --git a/roles/mgrote_minio_configure/tasks/policy.yml b/roles/mgrote_minio_configure/tasks/policy.yml
index 519bac07..0ef125eb 100644
--- a/roles/mgrote_minio_configure/tasks/policy.yml
+++ b/roles/mgrote_minio_configure/tasks/policy.yml
@@ -27,12 +27,12 @@
   loop: "{{ minio_buckets }}"
 
 - name: "setup policies (ro)"
-  ansible.builtin.command: "{{ minio_client_bin }} --dp admin policy create {{ minio_root_alias }} {{ item.name }}_ro {{ minio_config_dir }}/{{ item.name }}_ro"
+  ansible.builtin.command: "{{ minio_client_bin }} --disable-pager admin policy create {{ minio_root_alias }} {{ item.name }}_ro {{ minio_config_dir }}/{{ item.name }}_ro"
   loop: "{{ minio_buckets }}"
   changed_when: false # Befehl gibt immer "Created policy `testbucket3_ro` successfully." aus, unabhängig ob sie schon existiert oder nicht.
 
 - name: "setup policies (rw)"
-  ansible.builtin.command: "{{ minio_client_bin }} --dp admin policy create {{ minio_root_alias }} {{ item.name }}_rw {{ minio_config_dir }}/{{ item.name }}_rw"
+  ansible.builtin.command: "{{ minio_client_bin }} --disable-pager admin policy create {{ minio_root_alias }} {{ item.name }}_rw {{ minio_config_dir }}/{{ item.name }}_rw"
   loop: "{{ minio_buckets }}"
   changed_when: false # Befehl gibt immer "Created policy `testbucket3_ro` successfully." aus, unabhängig ob sie schon existiert oder nicht.
 
@@ -42,5 +42,3 @@
     state: absent
   loop: "{{ minio_buckets }}"
   when: '"absent" in item.state'
-
-# deletata to localhost