mirrors
/
OpenRCT2
mirror of https://github.com/OpenRCT2/OpenRCT2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Move scenery_update_age to SmallScenery member function

This commit is contained in:
Gymnasiast 2020-03-04 15:48:17 +01:00
parent 425b05d011
commit 1b38289490
No known key found for this signature in database
GPG Key ID: DBFFF47AB2CA3EDD
3 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/openrct2/world/Scenery.cpp
View File

@ -74,7 +74,7 @@ void scenery_update_tile(const CoordsXY& sceneryPos)
if (tileElement->GetType() == TILE_ELEMENT_TYPE_SMALL_SCENERY)
{
scenery_update_age(sceneryPos, tileElement);
tileElement->AsSmallScenery()->UpdateAge(sceneryPos);
}
else if (tileElement->GetType() == TILE_ELEMENT_TYPE_PATH)
{
@ -101,12 +101,9 @@ void scenery_update_tile(const CoordsXY& sceneryPos)
*
* rct2: 0x006E33D9
*/
void scenery_update_age(const CoordsXY& sceneryPos, TileElement* tileElement)
void SmallSceneryElement::UpdateAge(const CoordsXY& sceneryPos)
{
TileElement* tileElementAbove;
rct_scenery_entry* sceneryEntry;
sceneryEntry = tileElement->AsSmallScenery()->GetEntry();
auto* sceneryEntry = GetEntry();
if (sceneryEntry == nullptr)
{
return;
@ -118,14 +115,14 @@ void scenery_update_age(const CoordsXY& sceneryPos, TileElement* tileElement)
}
if (!scenery_small_entry_has_flag(sceneryEntry, SMALL_SCENERY_FLAG_CAN_BE_WATERED)
|| (gClimateCurrent.Weather < WEATHER_RAIN) || (tileElement->AsSmallScenery()->GetAge() < 5))
|| (gClimateCurrent.Weather < WEATHER_RAIN) || GetAge() < 5)
{
tileElement->AsSmallScenery()->IncreaseAge(sceneryPos);
IncreaseAge(sceneryPos);
return;
}
// Check map elements above, presumably to see if map element is blocked from rain
tileElementAbove = tileElement;
TileElement* tileElementAbove = reinterpret_cast<TileElement*>(this);
// Change from original: RCT2 only checked for the first three quadrants, which was very likely to be a bug.
while (!(tileElementAbove->GetOccupiedQuadrants()))
{
@ -142,13 +139,13 @@ void scenery_update_age(const CoordsXY& sceneryPos, TileElement* tileElement)
case TILE_ELEMENT_TYPE_ENTRANCE:
case TILE_ELEMENT_TYPE_PATH:
map_invalidate_tile_zoom1({ sceneryPos, tileElementAbove->GetBaseZ(), tileElementAbove->GetClearanceZ() });
tileElement->AsSmallScenery()->IncreaseAge(sceneryPos);
IncreaseAge(sceneryPos);
return;
case TILE_ELEMENT_TYPE_SMALL_SCENERY:
sceneryEntry = tileElementAbove->AsSmallScenery()->GetEntry();
if (scenery_small_entry_has_flag(sceneryEntry, SMALL_SCENERY_FLAG_VOFFSET_CENTRE))
{
tileElement->AsSmallScenery()->IncreaseAge(sceneryPos);
IncreaseAge(sceneryPos);
return;
}
break;
@ -156,8 +153,8 @@ void scenery_update_age(const CoordsXY& sceneryPos, TileElement* tileElement)
}
// Reset age / water plant
tileElement->AsSmallScenery()->SetAge(0);
map_invalidate_tile_zoom1({ sceneryPos, tileElement->GetBaseZ(), tileElement->GetClearanceZ() });
SetAge(0);
map_invalidate_tile_zoom1({ sceneryPos, GetBaseZ(), GetClearanceZ() });
}
/**

1
src/openrct2/world/Scenery.h
View File

@ -278,7 +278,6 @@ extern money32 gClearSceneryCost;
void init_scenery();
void scenery_update_tile(const CoordsXY& sceneryPos);
void scenery_update_age(const CoordsXY& sceneryPos, TileElement* tileElement);
void scenery_set_default_placement_configuration();
void scenery_remove_ghost_tool_placement();

1
src/openrct2/world/TileElement.h
View File

@ -383,6 +383,7 @@ public:
void SetSecondaryColour(colour_t colour);
bool NeedsSupports() const;
void SetNeedsSupports();
void UpdateAge(const CoordsXY& sceneryPos);
};
assert_struct_size(SmallSceneryElement, 16);