From 338cca6760af5985ab56a6df070f781b4248ab17 Mon Sep 17 00:00:00 2001 From: Peter Froud Date: Sat, 16 Mar 2024 21:35:48 -0700 Subject: [PATCH] Add missing `%u` in format strings --- src/openrct2/actions/BannerPlaceAction.cpp | 4 ++-- src/openrct2/actions/BannerRemoveAction.cpp | 8 ++++---- src/openrct2/actions/RideFreezeRatingAction.cpp | 2 +- src/openrct2/actions/SignSetStyleAction.cpp | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/openrct2/actions/BannerPlaceAction.cpp b/src/openrct2/actions/BannerPlaceAction.cpp index cb498d19e0..092233014f 100644 --- a/src/openrct2/actions/BannerPlaceAction.cpp +++ b/src/openrct2/actions/BannerPlaceAction.cpp @@ -98,7 +98,7 @@ GameActions::Result BannerPlaceAction::Query() const auto* bannerEntry = OpenRCT2::ObjectManager::GetObjectEntry(_bannerType); if (bannerEntry == nullptr) { - LOG_ERROR("Invalid banner object type. bannerType = ", _bannerType); + LOG_ERROR("Invalid banner object type. bannerType = %u", _bannerType); return GameActions::Result( GameActions::Status::InvalidParameters, STR_CANT_POSITION_THIS_HERE, STR_UNKNOWN_OBJECT_TYPE); } @@ -126,7 +126,7 @@ GameActions::Result BannerPlaceAction::Execute() const auto* bannerEntry = OpenRCT2::ObjectManager::GetObjectEntry(_bannerType); if (bannerEntry == nullptr) { - LOG_ERROR("Invalid banner object type. bannerType = ", _bannerType); + LOG_ERROR("Invalid banner object type. bannerType = %u", _bannerType); return GameActions::Result( GameActions::Status::InvalidParameters, STR_CANT_POSITION_THIS_HERE, STR_UNKNOWN_OBJECT_TYPE); } diff --git a/src/openrct2/actions/BannerRemoveAction.cpp b/src/openrct2/actions/BannerRemoveAction.cpp index c0321349be..33274c9954 100644 --- a/src/openrct2/actions/BannerRemoveAction.cpp +++ b/src/openrct2/actions/BannerRemoveAction.cpp @@ -70,14 +70,14 @@ GameActions::Result BannerRemoveAction::Query() const auto bannerIndex = bannerElement->GetIndex(); if (bannerIndex == BannerIndex::GetNull()) { - LOG_ERROR("Invalid banner index. index = ", bannerIndex); + LOG_ERROR("Invalid banner index. index = %u", bannerIndex); return GameActions::Result(GameActions::Status::InvalidParameters, STR_CANT_REMOVE_THIS, STR_NONE); } auto banner = bannerElement->GetBanner(); if (banner == nullptr) { - LOG_ERROR("Invalid banner index. index = ", bannerIndex); + LOG_ERROR("Invalid banner index. index = %u", bannerIndex); return GameActions::Result(GameActions::Status::InvalidParameters, STR_CANT_REMOVE_THIS, STR_NONE); } @@ -109,14 +109,14 @@ GameActions::Result BannerRemoveAction::Execute() const auto bannerIndex = bannerElement->GetIndex(); if (bannerIndex == BannerIndex::GetNull()) { - LOG_ERROR("Invalid banner index. index = ", bannerIndex); + LOG_ERROR("Invalid banner index. index = %u", bannerIndex); return GameActions::Result(GameActions::Status::InvalidParameters, STR_CANT_REMOVE_THIS, STR_NONE); } auto banner = bannerElement->GetBanner(); if (banner == nullptr) { - LOG_ERROR("Invalid banner index. index = ", bannerIndex); + LOG_ERROR("Invalid banner index. index = %u", bannerIndex); return GameActions::Result(GameActions::Status::InvalidParameters, STR_CANT_REMOVE_THIS, STR_NONE); } diff --git a/src/openrct2/actions/RideFreezeRatingAction.cpp b/src/openrct2/actions/RideFreezeRatingAction.cpp index 5e3ad0321c..47dcf13df8 100644 --- a/src/openrct2/actions/RideFreezeRatingAction.cpp +++ b/src/openrct2/actions/RideFreezeRatingAction.cpp @@ -40,7 +40,7 @@ GameActions::Result RideFreezeRatingAction::Query() const if (_value <= 0) { - LOG_ERROR("Rating value must be positive", _rideIndex.ToUnderlying()); + LOG_ERROR("Rating value must be positive: %u", _rideIndex.ToUnderlying()); return GameActions::Result( GameActions::Status::InvalidParameters, STR_ERR_INVALID_PARAMETER, STR_ERR_VALUE_OUT_OF_RANGE); } diff --git a/src/openrct2/actions/SignSetStyleAction.cpp b/src/openrct2/actions/SignSetStyleAction.cpp index ef6063a7a1..66a7bbf765 100644 --- a/src/openrct2/actions/SignSetStyleAction.cpp +++ b/src/openrct2/actions/SignSetStyleAction.cpp @@ -50,7 +50,7 @@ GameActions::Result SignSetStyleAction::Query() const auto banner = GetBanner(_bannerIndex); if (banner == nullptr) { - LOG_ERROR("Invalid banner id. id = ", _bannerIndex); + LOG_ERROR("Invalid banner id. id = %u", _bannerIndex); return GameActions::Result(GameActions::Status::InvalidParameters, STR_CANT_REPAINT_THIS, STR_NONE); } @@ -87,7 +87,7 @@ GameActions::Result SignSetStyleAction::Execute() const auto banner = GetBanner(_bannerIndex); if (banner == nullptr) { - LOG_ERROR("Invalid banner id. id = ", _bannerIndex); + LOG_ERROR("Invalid banner id. id = %u", _bannerIndex); return GameActions::Result(GameActions::Status::InvalidParameters, STR_CANT_REPAINT_THIS, STR_NONE); }