mirrors
/
OpenRCT2
mirror of https://github.com/OpenRCT2/OpenRCT2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix memory leak in GetFileName (#19420)

This commit is contained in:
Hielke Morsink 2023-02-16 20:45:48 +01:00 committed by GitHub
parent a428f20d46
commit 3e713e5c2f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/openrct2/core/ZipAndroid.cpp
View File

@ -16,6 +16,7 @@
# include <SDL.h>
# include <jni.h>
# include <string>
using namespace OpenRCT2;
@ -76,11 +77,7 @@ public:
jstring jniString = (jstring)env->CallObjectMethod(_zip, fileNameMethod, (jint)index);
const char* jniChars = env->GetStringUTFChars(jniString, nullptr);
utf8* string = (char*)malloc(strlen(jniChars) + 1);
std::memcpy((void*)string, jniChars, strlen(jniChars));
string[strlen(jniChars)] = 0x00;
std::string string = jniChars;
env->ReleaseStringUTFChars(jniString, jniChars);
return string;