Merge pull request #1741 from janisozaur/memory

Prevent accessing memory we don't own
This commit is contained in:
Ted John 2015-08-06 23:56:18 +01:00
commit 8f3e7e5cd0
1 changed files with 6 additions and 2 deletions

View File

@ -522,7 +522,8 @@ config_section_definition *config_get_section_def(const utf8 *name, int size)
for (i = 0; i < countof(_sectionDefinitions); i++) {
const_utf8string sectionName = _sectionDefinitions[i].section_name;
if (sectionName[size] == 0 && _strnicmp(sectionName, name, size) == 0)
const int sectionNameSize = strnlen(sectionName, size);
if (sectionNameSize == size && sectionName[size] == 0 && _strnicmp(sectionName, name, size) == 0)
return &_sectionDefinitions[i];
}
@ -535,8 +536,11 @@ config_property_definition *config_get_property_def(config_section_definition *s
for (i = 0; i < section->property_definitions_count; i++) {
const_utf8string propertyName = section->property_definitions[i].property_name;
if (propertyName[size] == 0 && _strnicmp(propertyName, name, size) == 0)
const int propertyNameSize = strnlen(propertyName, size);
if (propertyNameSize == size && propertyName[size] == 0 && _strnicmp(propertyName, name, size) == 0)
{
return &section->property_definitions[i];
}
}
return NULL;