Avoid constructing temporary string object

This commit is contained in:
ζeh Matt 2023-07-05 22:39:53 +03:00
parent 3d5e6ea932
commit b6ea3b1b47
No known key found for this signature in database
GPG Key ID: 18CE582C71A225B0
3 changed files with 3 additions and 3 deletions

View File

@ -162,7 +162,7 @@ public:
int32_t ooIndex = 0;
for (const ScenarioOverride& scenarioOverride : _scenarioOverrides)
{
if (String::IEquals(scenarioOverride.filename.c_str(), scenarioFilename))
if (String::IEquals(scenarioOverride.filename, scenarioFilename))
{
if (scenarioOverride.strings[index].empty())
{

View File

@ -2113,7 +2113,7 @@ std::string NetworkBase::MakePlayerNameUnique(const std::string& name)
// Check if there is already a player with this name in the server
for (const auto& player : player_list)
{
if (String::IEquals(player->Name.c_str(), new_name.c_str()))
if (String::IEquals(player->Name, new_name))
{
unique = false;
break;

View File

@ -186,7 +186,7 @@ const NetworkUser* NetworkUserManager::GetUserByName(const std::string& name) co
for (const auto& kvp : _usersByHash)
{
const auto& networkUser = kvp.second;
if (String::IEquals(name.c_str(), networkUser->Name.c_str()))
if (String::IEquals(name, networkUser->Name))
{
return networkUser.get();
}