Commit Graph

18907 Commits

Author SHA1 Message Date
Thamara Andrade 9edb3966fb
Close #13785: Refactor NetworkStatus window to class (#18302) 2022-10-18 06:54:01 -03:00
Hielke Morsink 3bb8ea3668
Better annotate some magic numbers in for loops 2022-10-17 16:08:55 +00:00
Eilidh Martin fdbceae17c
Fix #18324: Refactor TitleOptions to class 2022-10-17 15:29:17 +02:00
Hielke Morsink 5fa53ad528
Rename global config functions to use TitleCase 2022-10-16 21:46:08 +02:00
Hielke Morsink f9d1f024c2
Rename public plug-in config data members 2022-10-16 21:46:07 +02:00
Hielke Morsink 0ca7bb058f
Rename public font config data members 2022-10-16 21:46:07 +02:00
Hielke Morsink 89fa8d8052
Rename public notification config data members 2022-10-16 21:46:06 +02:00
Hielke Morsink bff430805f
Rename public network config data members 2022-10-16 21:46:06 +02:00
Hielke Morsink 371470b5d5
Rename public sound config data members 2022-10-16 21:46:05 +02:00
Hielke Morsink f605b02630
Rename public interface config data members 2022-10-16 21:46:05 +02:00
Hielke Morsink abac080d3e
Rename public general config data members 2022-10-16 21:46:01 +02:00
Rik Smeets c80bd455e9
Code style: Remove struct snakes from Paint (#18341) 2022-10-14 20:26:36 +02:00
Silent db6af4b362
Ensure argv on Windows is nullptr-terminated (#18331) 2022-10-14 09:31:55 +02:00
AuraSpecs 46fa09ca91
Fix: Sides of River Rapids’ corners overlay other parts of the track (#17316) 2022-10-13 20:52:48 +02:00
AuraSpecs dda256ef5f
Add inverted large loops and inverted boosters to Flying RC 2022-10-13 20:51:54 +02:00
Rik Smeets 94e8e9ea6b
Fix #18094: Invisible underground shops/facilities
Underground shops and facilities placed right next to non-underground path would be connected to the path, but the buildings themselves would remain invisible. Guests could use them though.

This has been fixed by drawing a tunnel, which is the same way ride entrances/exits are drawn.
2022-10-13 16:54:19 +00:00
Raymond Zhao a45f898c7e
Close #18322: Refactor TitleLogo window to class 2022-10-13 12:16:16 +02:00
Duncan 406b73d904
Remove final snakes from map and world (#18304) 2022-10-12 09:14:45 -03:00
Duncan 7dd8989e70
Next chunk of World/Map.h snakes (#18296)
* Next chunk of World/Map.h snakes

* Apply clang-format
2022-10-12 06:35:20 +01:00
Michael Steenbeek 7be8f475f3
Merge pull request #18292 from Gymnasiast/fix/18290
Fix #18290: Ride and plug-in window colours not appearing
2022-10-11 21:43:53 +02:00
Duncan 67bbc8560d
Code style: Remove snakes from everything world apart from Map.h (#18273)
* Remove remaining snakes from world (outside of map)

* Initial few desnaking of Map.h
2022-10-11 19:39:24 +01:00
Gymnasiast de71ed19b5
Remove remaining usages of SPRITE_ID_PALETTE_COLOUR_1() 2022-10-11 14:54:27 +02:00
Gymnasiast 418c5a6708
Use GetColourButtonImage() for remaining windows 2022-10-11 14:44:45 +02:00
Gymnasiast 89cd86da4d
Fix #18290: Ride and plug-in window colours not appearing 2022-10-11 14:44:07 +02:00
Rik Smeets 0c78a27d9f
Fix missing validation on invalid characters in file name (#18287)
When saving a new file with a name containing '/' or '\' on Windows, the incorrect file name would be determined since these characters represent a new folder. This would trigger a failure on save.

The user's input should be validated in all cases. Before, it was only executed for folder names. This change also applies the validation on file names.
2022-10-11 13:27:11 +02:00
Michael Steenbeek 6fe19878f6
More ImageId cleanup (#18258)
* Remove more usages of uint32 image indices

* Remove unused gfx_get_sprite_size()

* Remove uint32 images from text drawing

* Remove now-unused ImageId overload

* Default-initialise ttfRunIndex

* Suppress false-alarm GCC error
2022-10-10 19:42:40 +01:00
Rik Smeets 3fa7d59a1c
Fix #18070: Entrances/exits clip through walls (#18266)
Entrance or exit buildings placed underground could clip through walls.
2022-10-09 17:49:01 +02:00
Silent 9ea6351708
Windows: Use a modern file/folder picker 2022-10-09 17:12:46 +02:00
Michael Steenbeek def6b705cf
Merge pull request #18257 from rik-smeets/improve-crossing-behaviour
Fix guests 'waiting' on extended railway crossings
2022-10-09 17:10:14 +02:00
Rik Smeets 7c2ec714f7 Improve method name for level crossing check 2022-10-09 11:01:10 +02:00
Gymnasiast 079253e168
Remove now-unused SawyerEncoding.{cpp,h} 2022-10-08 23:09:07 +02:00
Gymnasiast c33e377d7c
Close #17341: Always allow loading with incorrect checksum 2022-10-08 22:58:23 +02:00
Rik Smeets bba54d2ecc Fix guests 'waiting' on extended railway crossings
On extended railway crossings, guests would stop to 'wait' for the passing train, which would then phase right through them. This change at least allows guests a chance to get to a safe place.
2022-10-08 21:59:26 +02:00
Michael Steenbeek bfd333bb38
Merge pull request #18217 from CookiePLMonster/fix-18200
Refactor Windows locales and remove the last non-Unicode functions
2022-10-08 21:47:12 +02:00
Michael Steenbeek c31482a3c3
Merge pull request #18255 from Gymnasiast/refactor/load-s6-s4
Remove old S6/S4 loading functions
2022-10-08 21:46:32 +02:00
Rik Smeets 8e33cf580f Code style: Remove snakes from virtual floor 2022-10-08 20:50:59 +02:00
Rik Smeets 4c06c2d5bb Code style: Remove snakes from path supports 2022-10-08 20:50:54 +02:00
Gymnasiast 900eea48b2
Consolidate landscape loading functions 2022-10-08 20:12:35 +02:00
Gymnasiast a3800320bc
Replace load_from_sv4() and load_from_sc4() 2022-10-08 20:12:35 +02:00
Gymnasiast 830fedb6b8
Replace load_from_sv6() and load_from_sc6() 2022-10-08 20:12:35 +02:00
Gymnasiast d5f6a5b285
Replace context_load_park_from_file() with object equivalent 2022-10-08 20:12:35 +02:00
Rik Smeets ffab787c73 Consistent naming of ImageId parameter 2022-10-08 19:59:38 +02:00
Rik Smeets 1d557f40ee Code style: Remove snakes from steel supports 2022-10-08 19:59:32 +02:00
Rik Smeets 0bf64f0228 Remove unused wooden support methods 2022-10-08 19:21:23 +02:00
Rik Smeets 29f61fd403 Code style: Remove snakes from wooden supports 2022-10-08 19:20:59 +02:00
Duncan 5dba30778d
Code style: Remove more snakes from the park, maphelper, scenery. (#18222) 2022-10-08 06:56:17 -03:00
Haven Kim 34170d6814
Fix #17853: Invention name tears while being dragged (#18223) 2022-10-08 06:52:32 -03:00
Rik Smeets 00d2dd8ef7
Code Style: Remove snake casing in PaintHelpers (#18247) 2022-10-08 11:24:50 +02:00
ZeeMajora ea04c0b010
Corkscrew rc's large flat to steep pieces available cheatless (#18230)
Makes the corkscrew roller coaster's large flat to steep pieces available without cheats for consistency with the looping & twister roller coasters which are similar coaster types that have this element available without cheats.
2022-10-07 22:27:58 +02:00
Hielke Morsink d4774293d5
Fix #18064: Unable to dismiss notification messages 2022-10-07 16:44:06 +02:00
Silent 0f978fe907
Remove the last non-Unicode Windows functions 2022-10-07 15:05:43 +02:00
Silent e825ffade7
Platform.Win32: Migrate to modern locale functions and names 2022-10-07 15:05:43 +02:00
leoleotte 0dee78bfe5
Close #13774: Refactor Footpath window to class 2022-10-06 19:41:31 +00:00
Michael Steenbeek fa81f119c2
Merge pull request #18208 from Gymnasiast/fix/18204
Fix #18204: Crash opening New Ride window with invalid highlight
2022-10-06 10:54:19 +02:00
Thomas Fai 8e3a0ee814
Part of #16033: VehiclePaint constants 2022-10-05 21:01:06 +00:00
ZeeMajora e6df43b7c9
Extras tab: add Tycoon park, keep competitions apart 2022-10-05 20:51:37 +00:00
Michael Steenbeek 051ede1598
Merge pull request #18213 from duncanspumpkin/codeStyle4
Code style: Remove snakes from Location, LargeScenery and MapAnimation
2022-10-05 22:36:39 +02:00
Michael Steenbeek 99e13e023e
Name unknown_15 window event as ScrollSelect
Co-authored-by: leoleotte <leoleotte@users.noreply.github.com>
2022-10-05 21:59:20 +02:00
Rik Smeets c5904d81d6
Code Style: Remove snakes from paint tile elements (#18212) 2022-10-05 21:27:38 +02:00
duncanspumpkin 16581e9288 Address snakes in mapgen and map animation 2022-10-05 20:22:51 +01:00
duncanspumpkin 2a593b6029 Remove snake cases from Location and LargeScenery 2022-10-05 20:21:56 +01:00
Rik Smeets 8ea34a5360
Fix #18134: Photo section clips through terrain 2022-10-05 18:35:37 +00:00
Gymnasiast 33f5fed0e2
Make GetFirstNonNullRideType() member function 2022-10-05 20:24:15 +02:00
Gymnasiast 79f3e28b07
Fix #18204: Crash opening New Ride window with invalid highlight 2022-10-05 20:13:11 +02:00
Nick 4aabc00335
Fix: ghosts are counted in guest scenery or fountain thoughts 2022-10-05 17:57:22 +00:00
Rik Smeets 69721e66f7
Fix #14312: Research ride type message incorrect
In some cases, researching a new ride type appeared as a new vehicle instead.
2022-10-05 19:26:44 +02:00
Michael Steenbeek 47d040226b
Merge pull request #18186 from duncanspumpkin/codeStyle3
Code Style: Remove snakes from entrances and footpaths
2022-10-05 13:24:12 +02:00
Gymnasiast 8ceea45877
Release v0.4.2
- Feature: [#6326] Ability to load .SV6 files from RCT Classic that have more than 9601 guests.
- Feature: [#6570, #10860, #17929] Fully support RollerCoaster Tycoon Classic as a RCT2 base install path.
- Feature: [#13634] Add ability to sell merchandise in random colours.
- Feature: [#16164] Add new track elements for Flying Coaster and Lay-Down Coaster and add paint code for more elements.
- Feature: [#16283] Added parkinfo command line tool to list objects in a save file.
- Feature: [#16662] Show a warning message when g2.dat is mismatched.
- Feature: [#17107] Ride operating settings can be set via text input.
- Feature: [#17638] Added Zero G rolls, medium loops and large corkscrews to the Hybrid and Single-Rail coasters.
- Feature: [#17821] [Plugin] Add API for track subpositions and vehicle subposition.
- Feature: [#17877] Add three real-life flying roller coaster colour schemes.
- Feature: [#17900] Add “Classic Wooden Coaster” with shallow banked turns.
- Feature: [#18057] Staff members now wait for passing or stalled vehicles before crossing railway tracks.
- Feature: [#18168] Add additional track pieces to the LIM Launched Coaster and the Looping Coaster.
- Feature: [objects#198] Add additional pirate roofs.
- Feature: [objects#205] Add additional glass roofs.
- Feature: [objects#209] Add the Steel Roller Coaster train and 2-across Inverted Train from RollerCoaster Tycoon 1.
- Feature: [#18050] Add asset pack manager and asset packs.
- Improved: [#15358] Park and scenario names can now contain up to 128 characters.
- Improved: [#15589] Numpad Enter can now be used to close text input.
- Improved: [#16819] Don’t prompt to “Save game as” when saving a loaded saved game (excepting autosaves).
- Improved: [#16840] Add support for rectangular heightmaps.
- Improved: [#17575] You can now search for Authors in Object Selection.
- Improved: [#17806] Added warning when using RCT1 objects without RCT1 linked.
- Improved: [#17868] [Plugin] You can now change active tab of a custom window programmatically.
- Improved: [#17909] Track elements that are not supported by any train are now hidden by default.
- Improved: [#17924] Improved performance when loading JSON object images from a .DAT file.
- Improved: [#17955] Modifying ratings via in-game console is now multiplayer-safe and also freezes the ratings.
- Improved: [#18177] [Plugin] Widget tooltips can now be read and changed.
- Change: [#9104] Calculate maze support costs.
- Change: [#17319] Giant screenshots are now cropped to the horizontal view-clipping selection.
- Change: [#17499] Update error text when using vehicle incompatible with TD6 and add error when using incompatible track elements.
- Change: [#17655] Lower default price for the Crooked House.
- Change: [#17745] Make maintenance cost of Mini-Golf more balanced.
- Change: [#17762] Use vertical tabs in the New Game dialog.
- Change: [#18113] Increased limit of Loan Interest in Scenario Editor to 255%.
- Fix: [#5141] Headless server is counted as a player.
- Fix: [#7466] Coaster track not drawn at tunnel exit.
- Fix: [#10535] Guests getting stuck at specific level crossings.
- Fix: [#14337] Guest blocking ride entrance after ride price changed to be unaffordable.
- Fix: [#15328] Wooden Roller Coaster incorrectly draws a railing on the first station piece (original bug).
- Fix: [#16392] Scenery on sloped surface is placed at wrong height.
- Fix: [#16476] The game sometimes crashes when demolishing a maze.
- Fix: [#17053] Crash when trying to open files under 4 bytes in length.
- Fix: [#17312] (Flying) Inline Twist appearing under the surface when placed on ground level.
- Fix: [#17339] Distorted visuals when changing scaling factor between integer numbers in OpenGL rendering mode.
- Fix: [#17394] Six-seater Hyper-Twister Trains focuses ride window camera on Car 2 rather than Car 1 (original bug).
- Fix: [#17430] Possible crash when toggling tile element visibility in multiplayer.
- Fix: [#17444] “Manta Ray” boats slowed down too much in “Ayers Rock” scenario (original bug).
- Fix: [#17503] Parks with staff with an ID of 0 have all staff windows focus on that staff.
- Fix: [#17508] Grid doesn’t disable after setting patrol area.
- Fix: [#17532] Object Selection window allows unselecting all station types.
- Fix: [#17533] Missing audio when specifying ‘--rct2-data-path’.
- Fix: [#17535] Multiplayer desync when placing rides with scenery.
- Fix: [#17541] Station style not correctly saved to TD6.
- Fix: [#17542] Stalls will autorotate towards paths outside the park.
- Fix: [#17544, #17754] Visual glitches in Invention List window.
- Fix: [#17553] Crash when moving invention list items to empty list.
- Fix: [#17571] All researched tracked rides show up as new vehicles in .park scenarios.
- Fix: [#17600] Notifications are not properly cleared when loading a park.
- Fix: [#17605] Crash when opening parks which have had objects removed externally.
- Fix: [#17639, 17735] When building upside down, the special elements list contains many items twice (original bug).
- Fix: [#17664] Unable to save after an extended period of time due to inactive ride music data leaking.
- Fix: [#17703] (undefined string) when building on invalid height.
- Fix: [#17776] “Other Parks” tab uses separate lists for SC4/SC6 and .park scenarios.
- Fix: [#17784] Colour preset RNG is biased (original bug).
- Fix: [#17788] Guests could leave queue if another guest rejoins it from the entrance building.
- Fix: [#17834] Finance window becomes blank after 4096 years.
- Fix: [#17816] Option to pause game when Steam Overlay is active is not greyed out when using the OpenGL renderer.
- Fix: [#17897] Guest can get stuck on tiles with construction rights outside the park.
- Fix: [#17904] Trees are removed at no cost to make way for ride entrance/exits.
- Fix: [#17905] The chain button in the map window is enabled for rectangular maps when (re)opened.
- Fix: [#17931] The in-game command ‘count_objects’ crashes the game.
- Fix: [#17865] With difficult guest generation, tested but unopened rides still contribute to the guest cap.
- Fix: [#17866] [Plugin] Wrong Soft Guest Cap at start of new game.
- Fix: [#17889] Peeps don’t stop at level railway crossings if approached from downhill.
- Fix: [#17980] Queue lines of track designs mess up existing queue lines if dragged through them.
- Fix: [#17959] Areas marked for dirty drawing are too large.
- Fix: [#17963] Some marketing campaigns can’t be started after Finances window tab has been on Research.
- Fix: [#17964] Sprites don’t show up on two sides of the view-clip selection.
- Fix: [#17966] Reversed steel trains do not properly import from S4.
- Fix: [#17973] Bins and lamps overlay parts of the land (original bug).
- Fix: [#18008] Steeplechase S-bends has multiple gaps visible in the tracks (original bug).
- Fix: [#18009] Visual glitch with litter at edge of sloped path.
- Fix: [#18025] Fix land ownership in Six Holland, Six Flags Magic Mountain, North America - Grand Canyon and Asia - Great Wall of China Tourism Enhancement scenarios.
- Fix: [#18026] Park rating drops to 0 with more than 32k guests, total ride excitement or intensity.
- Fix: [#18032] All non-interactive widgets (labels, groupboxes) produce sound when clicked.
- Fix: [#18035] Favourited servers don’t get their online status updated.
- Fix: [#18051] Visual glitch with Mine Ride’s large unbanked turn (original bug).
- Fix: [#18059] [Plugin] Width and height of custom window not changeable via script.
- Fix: [#18063] Guests can stop for all kinds of actions at railway crossing.
- Fix: [#18087] Bank balance is clamped to a 32-bit integer every transaction.
2022-10-05 12:07:57 +02:00
Gymnasiast 609becf8ad
Update backtrace token 2022-10-05 12:04:32 +02:00
X123M3-256 8b00fd1824
Add additional track pieces to LIM Launched Coaster and the Looping Coaster (#18168) 2022-10-05 06:41:10 +00:00
duncanspumpkin 3e8dc1b2ac Remove snakes from the foopaths 2022-10-04 20:08:14 +01:00
duncanspumpkin 2c29190ff8 Remove snakes from entrance 2022-10-04 20:07:35 +01:00
Michael Steenbeek 2e6595fe8a
Merge pull request #18050 from IntelOrca/assetpacks-audio
Add asset pack manager and asset packs
2022-10-04 19:08:38 +02:00
73 8c3ff1bfa8
Replace Transparancy with Transparency 2022-10-04 18:28:15 +02:00
Duncan 85929e5914
Remove snakes from construction clear (#18185) 2022-10-04 10:06:23 +01:00
Michał Janiszewski bcce0c2d12
Fix leak in `PaintEntryPool::Chain::operator=` (#18183)
Inspired by #18178
2022-10-03 22:53:33 +00:00
Ted John 41fb257fed Fix override of RCT classic audio on startup 2022-10-03 23:36:28 +01:00
Meehoi 34cb2a96f1
Fix #18174: Height marks on land do not appear 2022-10-03 21:51:36 +02:00
Ted John 0defe35d75 Update look of asset packs window 2022-10-03 20:16:01 +01:00
Stephan Spengler 9e1937d144
[Plugin] Widget tooltips can now be read and changed 2022-10-03 20:50:19 +02:00
Silent 82088f3496
Fix #17664: Ride music channel data leaks when stopping inactive music 2022-10-03 20:02:27 +02:00
Meehoi 5cb9b8be15
Remove format string in server name from Discord rich presence (#18159) 2022-10-03 00:01:24 +02:00
Rik Smeets ec12892dba
Remove snake_case from gentle rides (#18173) 2022-10-02 19:54:20 +02:00
ebstalk 20333c32fe
Fix #17964: Sprites don't show up on two sides of the view-clip selection 2022-10-01 21:26:36 +00:00
Rik Smeets 6d97bbddf9
Fix #18063: Guests stopping at railway crossings
Guests could stop at railway crossings for actions like taking a picture, watching a ride / a ride being constructed, reading a map etc. This also could mean they'd be in the way for a passing train.

Now, these actions will no longer be performed if the guest is at a crossing.
2022-10-01 19:09:51 +02:00
Duncan 3565a0172d
Attack snakes in banners and climate (#18163) 2022-10-01 18:54:15 +02:00
Ted John 2415b2e608 Fix compiler errors 2022-10-01 14:35:23 +01:00
Ted John 9bb47d0aa1 Add tooltips and new reload icon 2022-10-01 13:53:18 +01:00
Ted John 06e5b7cc1a Remove toggle button 2022-10-01 13:28:47 +01:00
Ted John 717e265c19 Add checkboxes to asset pack window 2022-10-01 13:07:13 +01:00
Ted John b2d5e356ab Allow multiple asset pack overrides 2022-10-01 13:06:55 +01:00
Ted John b264a73247 Re-create track sound channel if closed 2022-10-01 13:06:55 +01:00
Ted John dbf99bed71 Fix crash with invalid JSON 2022-10-01 13:06:55 +01:00
Ted John 589403d6cd Fix uninitialised data 2022-10-01 13:06:55 +01:00
Ted John 14dddde5c0 Ensure rain sound reloads when asset packs are reloaded 2022-10-01 13:06:55 +01:00
Ted John 6f7e571c08 Fix crash when assetpack does not exist 2022-10-01 13:06:55 +01:00
Ted John edb37a9fba Fix win32 builds 2022-10-01 13:06:55 +01:00
Ted John bf85e6de4c Implement loading / saving asset pack config 2022-10-01 13:06:55 +01:00
Ted John 331a5961b1 Implement asset packs for audio 2022-10-01 13:06:52 +01:00
73 b9e677945d
Replace 20XX with 2022 (#18158)
* Replace 2020 with 2022

Replace all 2020 headers with 2022

* replace other years with 2022

add missing years
2022-10-01 08:42:14 +01:00
Michael Steenbeek 2e5847d8d4
Merge pull request #18136 from Gymnasiast/refactor/more-imageid
Refactor/more imageid
2022-09-30 22:17:57 +02:00
73 1c419bcc9e
fix typo and outdated information (#18157)
this will not alter the code, only the annotation
2022-09-30 20:01:30 +00:00
Rik Smeets efa7a23773
Fix #18140 & #18143: Invalid read in Staff
The tile element should be determined the same way as is done when checking if the footpath is blocked by a vehicle.

Also added some extra safety checks and made the code a bit more efficient / reusable. For example: when the staff member is not a mechanic, the tile element doesn't have to determined.
2022-09-30 18:00:59 +00:00
Gymnasiast 26c080a0d7
Remove unused symbols, fixes 2022-09-30 00:01:13 +02:00
Gymnasiast a69a8fa7e8
Remove uint32_t overloads in Paint functions 2022-09-29 21:17:16 +02:00
Gymnasiast cedccf9b0e
Use const ImageId in drawing functions 2022-09-29 21:17:15 +02:00
Michael Steenbeek d352ca3d01
Merge pull request #18146 from ZeeMajora/classic-calculations-2
More accurate rating calculations for the classic coasters
2022-09-29 20:18:11 +02:00
73 edc79d77eb fix visual glitch with supports
maze and shops get their original support colors instead of yellow

Co-authored-by: beam41 <beam_baimon@hotmail.com>
2022-09-29 11:13:15 -04:00
Michael Steenbeek 6f3790cf98
Modify ride drawing code to use ImageId 2022-09-28 21:36:56 +02:00
Rik Smeets 67856292a4
Fix #17889: Peeps don't stop at level railway crossings if approached from downhill
If peeps approached a railway crossing from downhill, they would not stop for a passing train. This was because the exact destination z is determined too late. To always get the correct path, get the first footpath at the previous z index, or one step above.

Co-authored-by: Gymnasiast <m.o.steenbeek@gmail.com>
2022-09-28 16:44:05 +00:00
Michael Steenbeek a0dd6a3aa6
Fix #18087: gCash clamped to 32-bit integer every transaction 2022-09-28 12:20:44 +02:00
Michael Steenbeek 3c11e04b52
Fix #17053: Crash when trying to open files under 4 bytes in length 2022-09-28 03:08:27 +02:00
Michael Steenbeek 7bb7d97bdc
More bound box refactors 2022-09-27 21:20:49 +02:00
ZeeMajora ff85b6bcc3
More accurate rating calculations for the classic coasters 2022-09-27 12:47:16 -04:00
73 a8073f6bd5
Increase limit on Loan Interest from 80% to 255%
Co-authored-by: Gymnasiast <m.o.steenbeek@gmail.com>
2022-09-27 12:20:01 +02:00
Michael Steenbeek 36b775e573
Fix #17811: Erratic “same price” for photos if gSamePriceThroughoutPark is corrupted 2022-09-26 19:58:19 +02:00
Meehoi 61d74eaa4b
Part of #15589: Make numpad enter able to confirm input 2022-09-25 18:33:02 +00:00
Michael Steenbeek ae0f548d97
Bump network version 2022-09-25 19:21:05 +02:00
73 4f05ef58b2
Add 5 colour presets to Car Ride 2022-09-25 19:20:29 +02:00
73 bfa22d4ac0
Add 4 colour presets to Boat Hire 2022-09-25 19:17:49 +02:00
73 d00737367b
Add 2 colour presets to Dodgems 2022-09-25 19:17:01 +02:00
73 a7cd02b2be
Add 2 additional colour presets to Flying Saucers 2022-09-25 19:16:06 +02:00
Hielke Morsink cf6de246ea
Merge pull request #16873 2022-09-25 18:58:52 +02:00
Gymnasiast d135d7dc52
Bump network version for fd531903ce 2022-09-25 13:33:32 +02:00
Michael Steenbeek a3b7ac5a90
Create category for DLC and BYO scenarios 2022-09-25 12:59:35 +02:00
Rik Smeets 425000bfca
Don't prompt to 'Save game as' when saving (#16819)
After loading a saved game and choosing 'Save game', the 'Save game as' window would open the first time every time after loading the save.
Now, it will be saved using the existing save path, except when an autosave is loaded which the player probably doesn't want to overwrite.
2022-09-25 08:33:28 +02:00
Hielke Morsink c77a685225
Fix invalidation issues 2022-09-25 00:19:35 +02:00
Alex b00b158464
Refactor of TileInspector to Window class 2022-09-25 00:19:29 +02:00
AuraSpecs fd531903ce
Make maintenance of Mini-Golf less hateful (#17745)
This commit gets rid of Diamond Golf Balls: https://youtu.be/Szk3iPckVTo?t=106
2022-09-24 22:12:01 +00:00
AuraSpecs 6972811bff
Fix clipping on Flying RC Inline Twist
Same bug as #17832 but on the Flying RC. This fixes that.
2022-09-24 23:48:44 +02:00
Rik Smeets ffcd9551c9
Fix #17973: Path items overlay parts of the land 2022-09-24 22:25:12 +02:00
Rik Smeets 6c6ea169f1
Add railway crossing behaviour for staff (#18057) 2022-09-24 07:44:19 +02:00
Stephan Spengler 6be41893a4
Fix #18059: Width and height of custom window not changeable via script (#18061) 2022-09-24 07:06:26 +02:00
Michael Steenbeek e0a25f3d22
Merge pull request #18081 from rik-smeets/fix-10535
Fix #10535: Guests getting stuck at specific level crossings.
2022-09-23 22:58:13 +02:00
Meehoi d6ca1a3da9
Fix #18035: Favourited servers don't get their online status updated
From fetching flow, list will always have favourited servers but no code to update those entries, only append.
This code updates those favourited servers in the list with new data from internet by matching address.
This will fix list having 2 duplicate servers too. (one favourited and one not)
2022-09-23 22:51:05 +02:00
Michael Steenbeek 7af999e2dd
Fix #17980: Path mess and desync when hovering track design 2022-09-23 22:49:16 +02:00
Rik Smeets 9e68226df0 Fix #10535: Guests stuck at some level crossings
The location of the back vehicle itself should be included in determining whether to clear the 'blocked by vehicle' flag on footpath. Otherwise, in specific cases, blocked footpath can be missed and therefore this flag wouldn't ever be cleared.
2022-09-23 07:53:41 +02:00
Rik Smeets 189ebbced7 Reformat code on updating crossings 2022-09-23 07:11:15 +02:00
AuraSpecs 53877c244c
Allow laydown to pull pieces from corkscrew
This PR allows the Laydown RC to render missing pieces from the corkscrew rc.
2022-09-22 21:29:31 +00:00
Michael Steenbeek 53c6b97d48
Merge pull request #18073 from Gymnasiast/refactor/gmapsize
Use gMapSize instead of MAXIMUM_MAP_SIZE_TECHNICAL in appropriate places
2022-09-22 20:58:07 +02:00
Gymnasiast fc2b718926
Use RCT1 Wooden RC Trains and Single-person swinging cars 2022-09-22 17:09:30 +02:00
Gymnasiast 9367314a9f
Bump network version 2022-09-22 16:22:33 +02:00
Gymnasiast f5f4a8a2f6
Use gMapSize instead of MAXIMUM_MAP_SIZE_TECHNICAL in appropriate places
Backported from my map size refactors.

These functions previously scanned the whole map,
so this might also provide a slight performance boost (not tested).
2022-09-22 16:19:46 +02:00
Michael Steenbeek 31e2d7692c
Rename more instances of “vehicle” to “train” 2022-09-22 11:22:18 +02:00
Michael Steenbeek 9b27cfd33c
Merge pull request #18071 from Gymnasiast/feature/17955
Close #17955: Make ratings setting networked and freeze them
2022-09-21 21:09:41 +02:00
Gymnasiast 8c40223af3
Bump network and plugin API versions 2022-09-21 20:45:17 +02:00
Gymnasiast fed3863f7c
Fix land tiles in some parks
Co-authored-by: 733737 <733737@users.noreply.github.com>
2022-09-21 20:36:30 +02:00
Gymnasiast c1149895fa
Close #17955: Make ratings setting networked and freeze them 2022-09-21 19:15:10 +02:00
Hielke Morsink 8d08c13fa6
Fix #17963: Opening research tab breaks marketing tab 2022-09-21 14:49:08 +00:00
Gymnasiast 67c82b75e6
Fix: Cannot build banked turns on the Bobsleigh RC 2022-09-21 15:21:28 +02:00
Gymnasiast 97aec235e7
Fix #18053: Ride types without vehicles get all pieces disabled 2022-09-21 15:10:59 +02:00
Karst 0687e4f393
Fix #18007: River rapids vehicles glitch/sprites get cut off
This reverts commit ce95b58d5e,
"Fix #17992: Virginia Reel doesn't show sloped tracks".

The problem this commit aimed to fix has been (mostly) fixed
in 0a571cce29.
2022-09-21 15:06:45 +02:00
Hielke Morsink 43dbf9eb18
Fix #18032: non-interactive widgets produce sound 2022-09-19 20:38:34 +00:00
Rik Smeets d2634640ce
Fix visual glitch with Mine Ride's large turn (#18051) 2022-09-18 23:05:20 +02:00
Michael Steenbeek 36904cf3d0
Remove Reverse Incline Launched Shuttle mode from Junior RC (#18001)
This mode was not available in vanilla RCT2. We added it for RCT1 parity
before realising it was a better idea to just spin it off into its own
roller coaster (namely the Classic Mini RC). When we did eventually split
it, I overlooked this one.

Obviously, this mode still remains available on the Classic Mini RC.
2022-09-17 13:07:16 +02:00
Basssiiie a1be5dead3
Fix park rating overflow with over 32k guests, excitement or intensity (#18026) 2022-09-15 16:08:17 +02:00
Michael Steenbeek 0a571cce29
Fix #17992: Virginia Reel doesn't show sloped tracks 2022-09-12 22:39:40 +02:00
Rik Smeets b161a46beb
Fix visual glitch with litter at sloped path 2022-09-11 16:30:49 +00:00
Michael Steenbeek b258298b69
Close #13772: Refactor EditorScenarioOptions to class (#17983) 2022-09-11 17:58:54 +02:00
Rik Smeets a271c6c6f1
Fix Steeplechase S-bends bounding boxes 2022-09-11 17:56:21 +02:00
spacek531 ce95b58d5e
Fix #17992: Virginia Reel doesn't show sloped tracks 2022-09-09 08:23:56 +02:00
Michael Steenbeek 4f0f6608f4
Fix BoundBox order 2022-09-07 23:50:16 +02:00
Gymnasiast 2a5bccb4c3
Fix whitespace 2022-09-07 20:54:23 +02:00
Michael Steenbeek 400bbbc5ed
Use constant reference 2022-09-07 20:51:00 +02:00
Gymnasiast b4ab72416e
Move Boundbox to its own file, remove non-Coords constructors 2022-09-07 20:51:00 +02:00
iikorni b5ba892bd9
Fix naming case errors 2022-09-07 19:41:35 +02:00
iikorni d70bca7980
Fix error with MagicCarpet BoundBox conversion 2022-09-07 19:41:35 +02:00
iikorni 388387c809
Fix formatting on files 2022-09-07 19:41:35 +02:00
iikorni 4fa4e4d440
Change some rides over to the BoundBoxXY struct
Changes over the Crooked House, Ferris Wheel, Haunted House,
Magic Carpet, Swinging Ship, Swinging Inverter Ship, Monorail, and
the Supports file over to using the new BoundBoxXY(Z) struct(s).
2022-09-07 19:41:35 +02:00
iikorni c82bca90eb
Add BoundBoxXYZ to Location 2022-09-07 19:41:35 +02:00
iikorni cfc9af6957
Add BoundBoxXY to Location 2022-09-07 19:41:35 +02:00
Michael Steenbeek 1956b718ef
Merge pull request #17821 from Basssiiie/plugin-tracksegment-subposition-length
[Plugin] Implement plugin getters for track and vehicle subpositions
2022-09-07 02:36:42 +02:00
Fruitsalad 27e7a1fca7
Added definitions for if DISABLE_NETWORK is defined. 2022-09-06 23:28:34 +02:00
Fruitsalad 63520216a4
Fixes a minor bug
Apparently NetworkBase isn't reset between connecting to a
server and starting a new server, so previously if you
connected to a server that set IsServerPlayerInvisible to
true, disconnected and then started a server (without
closing OpenRCT), player 0 would be invisible despite
the server not being headless.
2022-09-06 23:28:34 +02:00
Fruitsalad f17b1a970e
Remove headless servers from the player list UI 2022-09-06 23:28:33 +02:00
Fruitsalad 5bdcd06dec
Remove headless servers from the server list player count 2022-09-06 23:26:27 +02:00
Fruitsalad 27bf5e160d
Remove unused variable wsa_initialized from NetworkBase 2022-09-06 23:26:27 +02:00
Michael Steenbeek 99a0876ad6
Disable track elements if no train supports them (#17909)
This can be useful in several situations:
- In RCT1 scenarios, or when playing with ported RCT1 vehicles, it will disable elements like banked turns
- We can add extra elements to existing coaster types by default, even if no RCT2 train supports them
2022-09-06 21:24:02 +00:00
Henry Cheng 121f121d4e
#17735 Track elements are listed twice when building backwards
Fix: Instead of checking whether bank has the value TRACK_BANK_UPSIDE_DOWN, instead check bank_start, as bank is not guaranteed to be bank_start.
2022-09-06 23:21:22 +02:00
Michael Steenbeek 9578c514d2
Fix #17966: Reversed steel trains do not properly import from S4 2022-09-06 22:57:58 +02:00
Stephan Spengler 1b5f50fd32
Fix #17974: Setting tabIndex of custom window does not work 2022-09-06 22:17:40 +02:00
Yuvraj Tetarwal 90b6cdb62e
Fix #17904: Trees are removed at no cost to make way for ride entrance/exits 2022-09-05 22:49:16 +02:00
frutiemax 7cb579795d
Fix dirty blocks regression (#17959) 2022-09-04 19:55:19 +02:00
Michael Steenbeek 8709b7800f
Merge pull request #17878 from Gymnasiast/feature/flag15-import
Close #6326: Add support for RCTC SV6 files with 15000 entities
2022-09-04 14:10:48 +02:00
Michael Steenbeek 342e3d7e09
Implement cache of loaded ObjData files 2022-09-03 23:34:34 +02:00
Michael Steenbeek 34c7bed26b
Use vertical tabs in the New Game dialog 2022-09-03 23:08:43 +02:00
Gymnasiast eea69c026c
Bump network version 2022-09-03 16:24:39 +02:00
Stephan Spengler 7537ca24e3
Combine the guest generation loops into one 2022-09-03 16:24:21 +02:00
Gymnasiast 83c6ce6b39
Fix #17865: Unopened rides contribute to difficult guest cap 2022-09-03 16:22:54 +02:00
spacek531 8c8dc632b8
Implement #17806: Warn user if fallback images are used
Warns user on the object debug info, when closing the object selection window after selecting objects, and when opening a park.
2022-09-03 13:56:23 +00:00
Bas 885be63797 Rename subposition rotations to yaw, pitch, roll 2022-09-03 09:34:16 +02:00
Bas 8c39881353 Implement plugin getter for subposition coordinates 2022-09-02 23:19:15 +02:00
Bas 7b5aeece59 Implement plugin getters for subposition and subposition length 2022-09-02 23:18:29 +02:00
Henry Cheng b6ceb1afce
Fix #17866: Wrong Soft Guest Cap at start of new game (#17869)
* Change _suggestedGuestMaximum initalization

* Update initialization method

* Add changelog

* Update changelog entry
2022-09-02 08:27:13 +01:00
Michael Steenbeek 027482cbcf
Fix UpdateRotating function for the Motion Simulator 2022-09-01 12:57:32 +02:00
frutiemax c2cfa95d1a
Add UpdateRideApproachVehicleWaypoints to RTD (#17124) 2022-08-31 22:56:13 -03:00
lalip a891d85dd9
Fix #17897: Guest can get stuck on construction rights outside the park
Caused by a refactor mistake in f0777e5418.
2022-08-31 23:51:05 +02:00
Michael Steenbeek a5a6d3a66c
Merge pull request #17929 from IntelOrca/rctc-support
Add support for RCT Classic assets
2022-08-31 23:26:25 +02:00
Henry Cheng 5f24099f39
Close #17868: Allow scripting to change active tab 2022-08-31 23:13:02 +02:00
Henry Cheng 0c76872869
Fix #17816: Option to pause Steam Overlay not greyed out when using OpenGL 2022-08-31 23:08:36 +02:00
Michael Steenbeek 7d881454de
Merge pull request #17942 from Gymnasiast/sync-objects
Update to objects v1.3.4
2022-08-31 23:03:43 +02:00
Gymnasiast 6d3a3cec76
Apply review requests 2022-08-31 23:02:52 +02:00
Ted John 9699c9db9e
Add support for RCT Classic audio files 2022-08-31 22:48:26 +02:00
Ted John 7d5e2e815e
Support RCT Classic ride music 2022-08-31 22:48:26 +02:00
Ted John 85a66c67ac
Add initial support for RCT Classic 2022-08-31 22:48:26 +02:00
Gymnasiast d8b5932a5e
Rename MaxEntitiesFlag15 to MaxEntitiesRCTCExtended 2022-08-31 22:45:13 +02:00
Gymnasiast b837cea59b
Use a vector instead of array 2022-08-31 22:44:12 +02:00
Gymnasiast 624d6ee752
Remove UnsupportedRCTCFlagException 2022-08-31 22:44:12 +02:00
Gymnasiast fdf6e1fca7
Close #6326: Add support for RCTC SV6 files with 15000 entities 2022-08-31 22:44:12 +02:00
Michael Steenbeek 2062084dab
Merge pull request #17933 from Broxzier/bugfix/17931-object-count-command
Fix #17931: The in-game command ‘count_objects’ crashes the game.
2022-08-31 22:35:52 +02:00
Michael Steenbeek 847299bf1a
Improve legibility [ci skip] 2022-08-31 22:35:14 +02:00
Gymnasiast 180dd5d38d
Use newly ported RCT1 objects for Inverted RC and Steel RC trains 2022-08-31 22:02:40 +02:00
frutiemax 306cc65258
Add UpdateRotating field to RTD 2022-08-31 10:10:39 +02:00
Hielke Morsink bb84c181f3
Fix crash on non-legacy objects 2022-08-30 11:57:28 +02:00
Hielke Morsink ced6f1280f
Fix reading out of bounds in `cc_object_count` 2022-08-30 11:31:24 +02:00
Michael Steenbeek 9dd28c90d7
Merge pull request #17908 from Gymnasiast/refactor/window-clean
Small window symbol cleanup
2022-08-29 22:04:13 +02:00
Rik Smeets e0648f8ddb
Fix guests leaving queue if other guest rejoins it (#17788)
If another guest returns to the queue from the entrance building, guests arriving at the entrance building through the queue could decide to leave it.
2022-08-29 19:57:51 +01:00
Michael Steenbeek 6c54bacd41
Fix #17921: NPE in track_block_get_next() (#17922) 2022-08-28 23:46:50 +02:00
Michael Steenbeek a2f3ab84cc
Print x and y offsets when extracting sprite from command line 2022-08-28 21:32:52 +02:00
Hielke Morsink 61c35c8f1c
Fix #17905: chain button enabled for rectangular maps 2022-08-28 09:36:18 +02:00
AuraSpecs 2633eb013f
Add three colour schemes to Flying Roller Coaster 2022-08-27 15:37:24 +00:00
Gymnasiast 45e7ee6a73
Rename rct_window_event_list to WindowEventList 2022-08-27 16:56:52 +02:00
Gymnasiast 5647fc8506
Fix flag usage 2022-08-27 16:52:29 +02:00
Gymnasiast ae8b2b8374
Remove unused window events 2022-08-27 16:50:02 +02:00
Gymnasiast bc650d1238
Use RCT2 brakes 2022-08-26 23:53:03 +02:00
spacek531 74ff5429a9
Add Classic Wooden Roller Coaster
Co-authored-by: Gymnasiast <Gymnasiast@users.noreply.github.com>
2022-08-26 23:53:03 +02:00
leoleotte 83e4277cea
Close #13807: Refactor Themes window to class 2022-08-24 21:33:37 +02:00
Tulio Leao 8ae01beeb1
Merge pull request #17736 from rik-smeets/calculate-maze-support-costs 2022-08-24 00:24:46 -03:00
Michael Steenbeek 942874152e
Merge pull request #17875 from Gymnasiast/refactor/window-struct-names
Rename rct_widgetindex to WidgetIndex
2022-08-23 15:07:10 +02:00
Rik Smeets 67ea7e739f
Fix #14337: Guest blocking ride entrance (#17743)
If the ride price becomes unaffordable for a guest who is already waiting to enter a vehicle, that guest became stuck due to an animation loop.
2022-08-22 21:15:58 +01:00
Rik Smeets f7c769603b Close #9104: Calculate maze support costs 2022-08-22 19:30:01 +02:00
Rik Smeets 5c596eae5d Extract maze cost calculation 2022-08-22 19:29:56 +02:00
Gymnasiast aea4df11fd
Remove rct_window_event (unused) 2022-08-21 18:59:46 +02:00
Gymnasiast 828ad513a7
Remove wndproc (unused) 2022-08-21 18:55:09 +02:00
Gymnasiast 2f6b82b13f
Remove gMaxTextBoxInputLength (only written to) 2022-08-21 18:54:51 +02:00
Gymnasiast a088537b65
Rename rct_widgetindex to WidgetIndex 2022-08-21 18:49:23 +02:00
Hielke Morsink 7f29e4e39c
Make `rct_windowclass` strong type `WindowClass`
This already revealed some places where implicit conversions were done, including some where its use was nonsense (MouseInput.cpp).
The changes to the Intent class were necessary to keep things working, and this splits things up more neatly.
2022-08-21 18:38:25 +02:00
Michael Steenbeek ebe38a91ce
Return dummy TED when index is out of bounds (#17810) 2022-08-21 17:09:18 +01:00
Ted John 05f2995d71
Fix #17843: New ride window incorrectly shows track design list 2022-08-21 16:19:43 +02:00
Dan Stevens 4291568a95
Fix #17844L ‘ride.ratings.calculate’ hook called several times during calculation
The ‘ride.ratings.calculate’ API hook is now called for a ride only after its rating calculations are complete (RIDE_LIFECYCLE_TESTED lifecycle_flag is set).
2022-08-21 00:25:17 +02:00
Michael Steenbeek 564a902b5f
Fix #15328: Incorrect railing on Wooden RC station (#17831) 2022-08-18 23:24:23 +02:00
skdltmxn 4fcdafc0f4
Fix #17834: finance window becomes blank after 4096 years 2022-08-17 23:05:18 +02:00
Michael Steenbeek 815d5ce2d5
Fix #17848: Trim colour not imported correctly from TD6 2022-08-17 17:44:06 +00:00
AuraSpecs 615325dd70
Hotfix B&M inline twist issue (#17832) 2022-08-16 23:50:41 -03:00
ale 7f33e4886d
Fix #17544: Placement rule in Invention List window does not move 2022-08-15 19:52:20 -04:00
ale 3a5a8d4f78
Fix #17754: Scenery Group thumbnails missing in Invention List window 2022-08-15 19:50:01 -04:00
Michael Steenbeek 354df90ab1
Fix #17815,#17818: Special... dropdown and brake settings glitches 2022-08-14 20:37:32 +00:00
Hielke Morsink f030b26454
Remove buffer size limit of assert messages 2022-08-14 22:16:53 +02:00
frutiemax 37500525b7
Add SpecialElementRatingAdjustment field in the RTD (#17652) 2022-08-13 22:49:38 -03:00
Michael Steenbeek 53f7a20d02
Merge pull request #17809 from Gymnasiast/bla3
Move some code from _legacy.cpp to RideConstruction.cpp (ui)
2022-08-13 23:37:33 +02:00