Commit Graph

18986 Commits

Author SHA1 Message Date
ζeh Matt 17ce2d759f
Rename Id to Id to PeepId to avoid conflicts with entity id 2023-01-27 19:11:04 +02:00
mdbckrtn b1b056ec52
Fix #18839: New staff members now picked up correctly (#18956)
* Fix #18839: New staff members now picked up correctly

When "Automatically place staff" is disabled, new staff members were not automatically placed into the "picked" state as is the case with vanilla RCT. This change ensures that new staff members are automatically placed into the picker and that, in scenarios where multiple new staff members are queued up without having first placed one, the most recently created staff member will be the actively picked up peep (also the case with vanilla).

* Fix #18839: Address networking issues

* Fix #18839: Add else to pickup action intent.
2023-01-27 08:20:59 +00:00
Josh Trzebiatowski 258b569deb
Allow filtering in Scenery window (#19272)
* WIP: scenery searching

* refactor snake case

* actually start filtering scenery

* prepare for merge from develop

* use ObjectManager to get scenery info

* clear selected scenery when it is filtered out

* Clear tool when no scenery is selected

* updating changelog

* fix clang formatting issues
2023-01-26 21:40:02 +00:00
Duncan 85b72c766e
Spin off Object Type into standalone header (#19278)
* Split off object type into standalone header

* Include missing header

* Rename to ObjectTypes.h
2023-01-26 21:39:20 +00:00
Duncan ead13c44b8
Split off LargeSceneryEntry (#19277) 2023-01-26 18:44:42 +00:00
Michael Steenbeek bb7fdc0e28
Hide primary/secondary remap button on broken large scenery (#17045) 2023-01-25 22:21:05 +00:00
spacek531 b1bb24aefb
Fill out TrackSegment API (#18478)
* add fields to track segment api

* add getTrackSegments to API

* change element to segment for continuity

* improve documentation

* continue tweaking documentation

* implement segment suggestions

* clarify purpose of isSteepUp flag

* add rest of track element flags

* remove extraneous information from comment

* continue tweaking API

* implement basssiiie suggestion

* rename angle to slope

* reorder items in the documentation

* bump plugin api
2023-01-25 22:05:18 +00:00
Josh Trzebiatowski c437a9f0cc
Add filter text box to new ride selection window (#19067)
* Add filter text box to new ride selection window

* update after snake_case refactor

* Change _filter to an instance variable, move textbox data assignment to OnPrepareDraw

* replace std::string_view with u8string_view
2023-01-25 21:47:00 +00:00
spacek531 9844532112
Refactor TrackPlaceAction so block brake logic only runs once (#18777)
* move block brake incrementation out of trackblock loop

* add comment to new code block
2023-01-25 21:09:36 +00:00
Michael Steenbeek c260a95abc
Fix #19245: NPE in UpdateRideApproachExitWaypoints() (#19252)
* Fix #19245: NPE in UpdateRideApproachExitWaypoints()

* Apply suggestions from code review

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2023-01-25 20:48:37 +00:00
Duncan ef27814ca5
Split off scenery entries (#19133)
BannerSceneryEntry, WallSceneryEntry footpathItemEntry
2023-01-25 19:56:29 +00:00
Duncan d51b4d3191
Split off SmallSceneryEntry into dedicated file (#19115)
* Split off small scenery entry to new file

* Move flags to new file
2023-01-25 19:25:33 +00:00
Michael Steenbeek 6b85b0a8c7
Change lift speed range of Classic Wooden RC (#19233)
* Change lift speed range of Classic Wooden RC

As this ride is meant to reflect both old-school wooden roller coasters, as well as RCT1’s wooden RC, it makes no sense the lift can be set to speeds up to 11 km/h. Limit this to 4-8 km/h.

* Bump network version

* Add changelog entry

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2023-01-25 12:01:54 +00:00
spacek531 9071c91ec8
RideConstruction window can set block brake speed (#18992)
* RideConstruction window can set block brake speed

* add missing constant

* refactor to allow future expansion

* revert addition of constant
2023-01-25 07:32:03 +00:00
Wirlie 538b87e94c
Fix: A queuing guest can ignore the next guest in the queue in certain circumstances (RCT2 bug) (#19068)
* Use PeepDirection instead of sprite_direction to update queue position

* Align guests to the centre of the first queue tile.

* Bump network version

* Update changelog

* Update replays

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2023-01-24 09:35:12 +00:00
Michał Janiszewski be5b7b7f74
Drop unused variables (#19267)
* Drop unused variable in ShortcutKeys.cpp

* Drop unused variable in TitleMenu.cpp
2023-01-24 09:24:47 +00:00
Josh Trzebiatowski d6027a111a
Fix #19250: MusicObjects do not free their preview images (#19264)
* Fix: MusicObjects do not free their preview images

* Update changelog

* remove unneeded preview check on MusicObject
2023-01-24 05:55:31 +00:00
Josh Trzebiatowski 54f263b704
Fix #19112: Text boxes not updated with empty strings (#19207)
* fix #19112 text boxes not updated with empty strings

* Update changelog
2023-01-23 21:20:27 +00:00
Michael Steenbeek d8417fee30
Desnake the rct2/rct12 fields (#19254) 2023-01-22 19:16:41 +00:00
Michael Steenbeek f328aef84b
Add drawing code for queue junctions (#19253) 2023-01-22 00:59:40 +01:00
Duncan b76bffe1ec
Desnake RCT12 class names 2023-01-21 22:32:44 +00:00
Michael Steenbeek e17f09c25c
Move three tables to MazeSetTrackACtion.cpp 2023-01-21 22:25:31 +00:00
Michael Steenbeek ba39d7be5d
Merge pull request #19241 from Gymnasiast/refactor/more-fields
Desnake TileElement fields, pad_ and byte_
2023-01-21 22:38:07 +01:00
Duncan e09f27df3c
Rename snake_case Class names (Remaining Bits) (#19237)
* Rename snake_case Class names

* Clang format

* Fix build issues
2023-01-21 19:57:17 +00:00
Gymnasiast f6427817e8
Rename byte_ to Byte 2023-01-21 16:41:03 +01:00
Gymnasiast 3dd895abf7
Rename pad_ to Pad 2023-01-21 16:39:35 +01:00
Gymnasiast fa7dd95321
Rename remaining snake in (RCT12)TileElement fields 2023-01-21 16:37:11 +01:00
Michael Steenbeek 09b1074d08
Merge pull request #19234 from Gymnasiast/objects-138
Objects v1.3.8 + fix #474: Mini Golf window allows selecting nonexistent players
2023-01-21 15:41:21 +01:00
Duncan 7d08372c80
Remove snake_case from Class names OpenRCT2/Ride*-S* (#19232)
* Remove snake_case from Class names OpenRCT2/Ride*-S*

* Clang format
2023-01-20 20:58:55 +00:00
Gymnasiast eb5fe27495
Fix #474: Mini Golf window allows selecting nonexistent players 2023-01-20 13:24:16 +01:00
Gymnasiast 06dd935d36
Use RCT1 variants of Corkscrew and Go Karts when importing S4 2023-01-20 12:39:30 +01:00
Michael Steenbeek cf9aad7885
Close #19214: Use consistent casing for RC and RCT (#19230) 2023-01-20 08:19:14 +00:00
Duncan 9deed6d98a
Replace snakes in Class names OpenRCT2/N*-P* (#19227)
* Replace snakes in Class names OpenRCT2/N*-P*

* Rename PODDate (and TimeOfDay for good measure)

Co-authored-by: Gymnasiast <m.o.steenbeek@gmail.com>
2023-01-20 05:24:44 +00:00
Hielke Morsink e110c631f1
Include missing project headers in solution 2023-01-19 23:34:49 +00:00
Michael Steenbeek 31b510a30b
Rename entity-related stuff in RCT12.h
Replaces ‘sprite’ with ‘entity’ where appropriate.
2023-01-19 22:29:48 +00:00
Michael Steenbeek 48619afbb8
Replace snake_case in rct1 folder 2023-01-19 21:48:07 +00:00
Michael Steenbeek 24cc49cde9
Fix #19076: scrolling on money amounts doesn’t work 2023-01-19 21:07:21 +00:00
Michael Steenbeek 448c8fafd0
Rename base_height, clearance_height and owner 2023-01-19 20:36:30 +01:00
Duncan 23b6d1840e
Rename classes with snakes OpenRCT2/G*-M* 2023-01-19 15:13:23 +00:00
Duncan 859b071ddc
Rename classes with snakes OpenRCT2/A*-F* (#19215)
* Rename classes with snakes OpenRCT2/A*-F*

* Clang format files
2023-01-19 08:16:44 +00:00
Michael Steenbeek 59736ecfbc
Merge pull request #19216 from Broxzier/refactor/snake-case-util
Rename snake_case functions in OpenRCT2/util folder
2023-01-19 00:10:28 +01:00
Hielke Morsink ba0c8c135a
Apply review changes 2023-01-18 23:41:59 +01:00
Hielke Morsink 86ffb01ddd
Add comment and rename function pointer 2023-01-18 23:02:44 +01:00
Hielke Morsink 0762fcb601
Rename snake_case functions in OpenRCT2/util folder 2023-01-18 22:44:13 +01:00
Duncan 3456797893
Use clang-tidy to get remaining snakes in ride/coaster (#19200)
* First pass with clang-tidy

Fix Rc RC

Clang format files

* Apply clang tidy to remaining ride files

* Undo table mangling in SplashBoats.cpp

Co-authored-by: Gymnasiast <m.o.steenbeek@gmail.com>
2023-01-18 20:41:42 +00:00
Michael Steenbeek 92dce8e046
Rename snake_case functions in peep folder (#19213) 2023-01-18 20:35:58 +00:00
Duncan bb5a663e2d
Remove snake case from coaster/ride/A*-B* and F* 2023-01-18 20:52:43 +01:00
Josh Trzebiatowski f14d1e3b7e
Track missing objects when selecting scenery groups (#19131) 2023-01-18 09:11:56 +01:00
Hielke Morsink 2c224cfd53
Rename snake_case functions in OpenRCT2/network folder (#19203) 2023-01-18 06:05:53 +00:00
Hielke Morsink 917c091e6b
Rename snake_case functions in OpenRCT2/marketing folder 2023-01-17 23:13:39 +00:00