Sam J Gunner
55b4c4c6f1
Fix #13046 : Simplify block sectioned comparisons ( #13049 )
2020-10-01 09:06:28 -03:00
Duncan
afbc983a94
Fix #13050 : Mistake during refactor removed drawing cached track count ( #13051 )
2020-10-01 09:57:46 +02:00
Duncan
2063aea5ef
Remove common format formatter where possible ( #13034 )
...
* Remove common format formatter where possible
Eventually should have it limited to tooltips, window titles and widget args
* Remove remaining paint functions using common
* Remove misuse of gCommonFormatArgs
2020-09-30 22:42:04 +01:00
Tulio Leao
b92328ce34
Merge pull request #13004 from vjavs/strong-enum/PeepActionSpriteType
...
Refactor PeepActionSpriteType to use strong enum
2020-09-29 23:38:23 -03:00
ζeh Matt
30307ec42d
Merge pull request #13030 from ZehMatt/fix-4617-2
...
Fix #4617 : Crash when rotating with invalid viewport open
2020-09-30 00:53:32 +03:00
Matt
005e1e0e1f
Final cleanup
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:51 +03:00
Matt
f765ed2f94
Use unique_ptr for TitleSequenceParkHandle Stream
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:28 +03:00
Matt
e3a4d6a245
Use std::string for TitleSequenceParkHandle HintPath
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:01 +03:00
Matt
17bff41e82
Use std::unique_ptr for TitleSequenceParkHandle
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:22:44 +03:00
Matt
464545b907
Cleanup remnants
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:22:35 +03:00
Matt
612249bd74
Use vector for TitleSequence commands
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:21:58 +03:00
Matt
7245f23422
Use vector for TitleSequence saves
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:21:42 +03:00
Matt
ccb6eb06f8
Use unique_ptr for TitleSequence instances
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:21:27 +03:00
Matt
d6c2ec898d
Fix #4617 : Crash when rotating with invalid viewport open
2020-09-29 21:44:59 +03:00
Vinicius Sa
ca8fa55fdb
Use EnumValue to get the underlying value of an enum
...
Applied to objects of the enum class PeepActionSpriteType when they are
used as arrays subscripts.
2020-09-29 11:15:07 -03:00
Vinicius Sa
f8dd0a57aa
Refactor PeepActionSpriteType to use strong enum
2020-09-29 11:15:04 -03:00
Duncan
3c8adb1fc1
Remove gMapTooltip format args global ( #12971 )
...
Fix mistake
2020-09-28 21:45:28 -03:00
Łukasz Pękalski
d1cd2e08b5
Close #12388 , refactor PeepState to use strong enum ( #12927 )
...
* Close #12388 , refactor:PeepState to use strong enum
* refactor: refactored file PlayTests.cpp
* refactor: change PEEP_STATE_ to PeepState:: and camel case after merging
chore: code reformatting
2020-09-28 15:51:49 -03:00
Aaron van Geffen
d27e14f45b
Compact, statically initialized syntax for event lists ( #12973 )
2020-09-28 20:36:15 +02:00
Łukasz Pękalski
065da23b3b
Close #12437 , refactor: RIDE_MODE_* to strong enums ( #12833 )
...
* partial refactor: RIDE_MODE_* to strong enums
* Close #12437 , refactor: RIDE_MODE_* to strong enums
* chore: code formatting
* refactor: RideMode, change enum names to CamelCase
and resolve casting order.
* chore: refactor due to code formatting
* Close #12437 , refactor: RIDE_MODE_* to strong enums
Resolved comments
* chore: Formatting correction.
* Use EnumsToFlags constexpr
* refactor: resolved comments
added newline at the end of file
* refactor: Change case stack to default in Switch
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2020-09-28 14:09:59 +01:00
Tulio Leao
8f5ee758ee
Fix #3200 : Close Construction window upon selecting vehicle page ( #13022 )
2020-09-28 07:37:22 -03:00
Duncan
4ec10837a6
Remove Formatter::Common where not required ( #12972 )
...
* Remove Formatter::Common where not required
* Remove common from Guest window where possible
2020-09-27 21:09:08 -03:00
Matt
958f3824c9
Fix #12969 : Crash opening ride window with invalid mechanic assigned
2020-09-27 13:40:40 +03:00
Aaron van Geffen
62b13e68bc
Fix #13005 : Last player action is not truncated ( #13007 )
2020-09-27 11:41:28 +02:00
Michael Steenbeek
4a79e9305f
Replace gfx_draw_string_right() with DrawTextBasic ( #12966 )
2020-09-18 21:39:00 -03:00
Michael Steenbeek
77e22851cc
Merge pull request #12925 from richard-fine/dropdown-menus-static-data
...
RFC: Dropdown menus static data
2020-09-18 23:37:26 +02:00
Duncan
da82144bfb
Fix #12944 . Mistake from refactor meant formatter optimised away ( #12961 )
...
Not sure why it should get optimised away but this will fix the crashes.
2020-09-18 09:25:17 +01:00
Matt
b3b9a348c5
Apply review suggestions
2020-09-17 22:16:05 +03:00
Matt
38e03ae45d
Use the Formatter for News items
2020-09-17 22:14:36 +03:00
Matt
ccde06ab0f
Explicitly pass formatter arguments to ShowError and family
2020-09-17 22:14:36 +03:00
Matt
2639349925
Move storage into Formatter class and refactor usage
2020-09-17 22:14:36 +03:00
Michael Steenbeek
1982e8491b
Merge pull request #12667 from mwnciau/json-refactor
...
Migrate JSON library to JSON for Modern C++
2020-09-17 21:11:06 +02:00
Simon Jarrett
2c92c652e2
Refactor ObjectLoadError to use new JSON library
2020-09-16 20:18:54 +01:00
frutiemax
af591c834b
Part of #12097 : Use ScreenRect on gfx_fill_rect_inset (1) ( #12938 )
...
* Part of #12097 : Use ScreenRect on gfx_fill_rect_inset (1)
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2020-09-16 00:02:22 -03:00
Michael Steenbeek
3acbb92074
Merge pull request #12922 from Gymnasiast/LetItSnow2
2020-09-15 18:11:45 +02:00
Tulio Leao
c1729c8a87
Merge pull request #12858 from ju-pinheiro/network-strong-enums
...
NETWORK_PERMISSION and NETWORK_AUTH replaced by strong enums
2020-09-15 08:07:19 -03:00
Brett
c9de4f49fe
Add snow as a weather type
...
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
2020-09-14 21:58:00 +02:00
Richard Fine
4f31ddaca4
Make menu data declarations local to the functions using them
2020-09-13 16:30:17 -04:00
Richard Fine
a51d8e4deb
Convert cheats menu to use new constexpr menu specification
2020-09-13 16:16:05 -04:00
Richard Fine
ce99928b81
Convert view menu to use new constexpr menu specification
2020-09-13 16:15:53 -04:00
Richard Fine
d21da12f9f
Fix 11414: ‘Possible misuse of comma operator’ warnings ( #12919 )
...
Fix the ‘possible misuse of comma operator’ warnings reported by XCode - the two original ones reported in #11414 , plus one more in Util.cpp.
2020-09-13 17:43:59 +01:00
Tulio Leao
917fb77f0e
Revert regressed warning on window_install_track_paint
2020-09-10 21:19:53 -03:00
Tulio Leao
c2f42cd908
Fix #12901 : Guest thoughts show up as guest actions or names
2020-09-10 21:18:42 -03:00
Tulio Leao
2f3d455b3a
Merge pull request #12899 from Gymnasiast/refactor/c-style-casts
...
Remove most remaining C-style casts
2020-09-10 20:49:15 -03:00
Aaron van Geffen
c0e551056f
Fix #12900 : Garbled/distorted date lines in file browser ( #12902 )
...
* Fix #12900 : Garbled/distorted date lines in file browser
2020-09-10 20:47:39 -03:00
ju-pinheiro
20a8bbc322
Close #12420 : Refactor NETWORK_PERMISSION to use strong enum
...
First approach, instead of a bigger refactor to avoid the need of "static_cast".
2020-09-10 19:32:27 -03:00
Gymnasiast
c83ddefe47
Convert remaining C-style casts to C++-style ones
2020-09-10 21:36:20 +02:00
Tulio Leao
4afbbed9bd
Fix #12881 : Guests' favourite rides not listed in the guest window
2020-09-10 19:11:17 +02:00
Gymnasiast
d140dd72c6
Remove const void* overload from DrawTextEllipsised()
2020-09-10 18:13:13 +02:00
Gymnasiast
b788a099b5
Replace gfx_draw_string_clipped() calls with DrawTextEllipsised
2020-09-10 18:13:13 +02:00
Gymnasiast
6e22eade67
Create Objective struct and use it for global objective
2020-09-09 15:38:03 +02:00
Jacob Schwartz
fe71ce437d
Close #12434 : Refactor ENTERTAINER_COSTUME to use strong enum ( #12865 )
2020-09-08 16:29:18 -03:00
Nils Caspar
22f29bf192
Close #12414 : Refactor GUEST_LIST_FILTER_TYPE to use strong enum ( #12830 )
2020-09-02 12:50:16 -03:00
Simon Ellmann
5f3fe62f83
Close #12432 : Refactor STAFF_MODE to use strong enum ( #12752 )
...
* Refactor STAFF_MODE to use strong enum
Closes #12432
* Change type of gStaffModes to StaffMode
2020-09-02 12:48:40 -03:00
Nils Caspar
ae81ed63cc
Remove unused constant TAB_HEIGHT in Cheats.cpp ( #12838 )
2020-09-01 22:58:06 +02:00
Michael Steenbeek
55722a7ad4
Remove commented-out code ( #12834 )
2020-09-01 15:33:52 -03:00
Aaron van Geffen
e9803fc4b5
Fix #12820 : Title menu buttons not invalidating properly ( #12821 )
...
This introduces constants for the title menu buttons to ensure this does not happen again.
2020-08-30 23:30:02 +02:00
Aaron van Geffen
5825dedd81
Rename TitleScenarioSelect to ScenarioSelect ( #12822 )
...
The scenario select window is not only available through the title screen.
2020-08-30 20:22:20 +02:00
Tulio Leao
731a93dc39
Create WindowColour enum for widget definition calls ( #12722 )
...
* Make MakeWidget* functions take enum colour
* Make windows A-D use WindowColour enum
* Make windows E-G use WindowColour enum
* Make windows I-M use WindowColour enum
* Make windows N-P use WindowColour enum
* Make windows R-S use WindowColour enum
* Make windows T use WindowColour enum
* Make windows V-W use WindowColour enum
2020-08-28 23:31:31 -03:00
Łukasz Pękalski
411f242cfd
Close #12431 Refactor VirtualFloorStyles to use strong enum ( #12790 )
2020-08-27 21:06:39 -03:00
Michael Steenbeek
db8efe20d0
Merge pull request #12785 from Gymnasiast/refactor/text-drawing
...
Start removal of gfx_draw_string_*()
2020-08-26 22:51:39 +02:00
Gymnasiast
549a771120
Use Formatter&
2020-08-26 17:13:19 +02:00
Gymnasiast
972e6e80ab
Allow passing Formatter to DrawTextBasic() and DrawTextEllipsised()
2020-08-26 15:08:42 +02:00
Gymnasiast
ceace1a3ad
Remove draw_string_left_underline()
2020-08-26 14:47:47 +02:00
Gymnasiast
f1caddc9fe
Remove draw_string_right_underline()
2020-08-26 14:46:37 +02:00
Gymnasiast
879ce64a86
Use Formatter in windows/Ride.cpp
2020-08-26 13:59:18 +02:00
Michael Steenbeek
56c623e549
Merge pull request #12671 from AaronVanGeffen/refactor/tabs
...
MakeTab wrapper for standard tab widgets
2020-08-26 12:13:36 +02:00
Tulio Leao
efdb7e1a2d
Change gDateMonthsElapsed type to int32_t
2020-08-25 19:06:38 -03:00
Tulio Leao
4caf571c22
Followup on #12475 post-mortem comments ( #12745 )
...
* Remove using namespace OpenRCT2 from header
* Fix using wronf undefined enum for shortcut key map
2020-08-21 16:07:38 +01:00
Sidney
5330f7fb86
closes #12445 Refactor CLIMATE to use strong enum ( #12551 )
2020-08-21 09:43:57 +01:00
frutiemax
4cc550a364
Close #12460 : Refactor KeyboardShortcut to use strong enum ( #12475 )
...
* Close #12460 : Refactor KeyboardShortcut to use strong enum
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2020-08-20 23:54:43 -03:00
Tom Parsons
9cdae2d1e2
Fix #12401 : Refactor SCALE_QUALITY to use strong enum ( #12673 )
2020-08-20 23:32:56 -03:00
Simon J
4c2ce0f892
Remove duplicate TRACK_ELEMENT_LOCATION_IS_UNDERGROUND flag ( #12714 )
...
Renamed all instances to ELEMENT_IS_UNDERGROUND
Co-authored-by: Simon Jarrett <simonjjarrett@gmail.com>
2020-08-18 09:26:03 -03:00
Aaron van Geffen
40cfadcdc5
Apply formatting suggestions from code review
...
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2020-08-18 10:13:48 +02:00
ryan-bello
cc2bb33892
changed enum STAFF_TYPE to strong enum StaffType, moved it to Peep.h
2020-08-17 22:59:02 -04:00
ryan-bello
54a33cbde8
renamed StaffType to AssignedStaffType
2020-08-17 20:16:09 -04:00
Aaron van Geffen
3b97cd9b14
Refactor Staff*, Themes, and TitleEditor to use MakeTab
2020-08-17 20:59:42 +02:00
Aaron van Geffen
6b9211c8b8
Refactor Park, Player, Research, Ride* to use MakeTab
2020-08-17 20:59:42 +02:00
Aaron van Geffen
3631d75b98
Use MakeTab in Mapgen, Multiplayer, Network, NewRide, NewsOptions
2020-08-17 20:59:23 +02:00
Aaron van Geffen
be626d0b7c
Refactor Editor*, Finances, Guest* to use MakeTab
2020-08-17 20:59:17 +02:00
Aaron van Geffen
6602b51b8b
Use MakeTab in EditorInventionsList, EditorObjectSelection, Scenery
2020-08-17 20:59:17 +02:00
Aaron van Geffen
4a55acd71e
Introduce MakeTab wrapper function
...
The MakeTab function is only applied in two places, for the moment:
the Cheats and Options windows.
2020-08-17 20:59:13 +02:00
Aaron van Geffen
72be84caf8
Remove unused fourth tab from Staff window ( #12713 )
2020-08-17 20:21:46 +02:00
Duncan
55ba164dee
Fix crash when switching ride types with construct window open ( #12694 )
2020-08-16 18:48:21 +01:00
pizza2004
647730fcfa
Fix #12691 : Tooltip at ride's graph tab is not using a proper string
2020-08-15 23:17:38 +02:00
Aaron van Geffen
f95da1c99a
Fix alignment for widget definitions
2020-08-14 10:18:17 +02:00
Michał Janiszewski
6dd67296a4
Merge "new version" window back to changelog
2020-08-14 10:18:17 +02:00
Michał Janiszewski
6ae5645686
Show update information on main screen & in floppy menu
2020-08-14 10:18:17 +02:00
Michał Janiszewski
55835456a0
Pester users to update to latest release
2020-08-14 10:18:17 +02:00
Aaron van Geffen
eda8e31055
Refactor widget defs in EditorObjectiveOptions window ( #12672 )
2020-08-13 23:07:19 -03:00
Matt Thomson
a8f8f06e2d
Fix #12402 : Refactor MEASUREMENT_FORMAT to use strong enum ( #12642 )
...
* Fix #12402 : Refactor MEASUREMENT_FORMAT to use strong enum
* Remove redundant default branches
Co-authored-by: Matt Thomson <matt-thomson@users.noreply.github.com>
2020-08-13 21:51:28 +01:00
Michael Steenbeek
5e09ecc904
Fix #12308 : Cannot use cheats in editor modes ( #12661 )
...
This allows opening the cheats window while in editor mode. Some tabs and options are disabled because they are not relevant to these modes.
2020-08-13 13:03:56 +02:00
Michael Steenbeek
33d9fc2b75
Fix #10549 : 'Build the best ride you can' objective missing ride name
...
This is implemented in a way that is compatible with RCT2 (as long as the ride type was not split).
2020-08-13 00:23:08 +02:00
Michael Steenbeek
68ce06e833
Refactor objective handling in Scenario Editor
...
This moves some knowledge out of the window and into the main code and also cleans up the window a bit.
This also allows setting the "x guests by the end of year y" goal for no money scenarios, which was not the case previously.
2020-08-12 22:10:47 +02:00
Michael Steenbeek
2d56c8d2de
Merge pull request #12636 from Gymnasiast/refactor/to-member-function
...
Use a 16-bit integer for track type in more places
2020-08-11 17:53:20 +02:00
Tulio Leao
2e4edf6f5d
Merge pull request #12638 from quale/fix-debug-window
...
Fix Z coordinate and spillover in guest debug tab
2020-08-11 07:53:19 -03:00
Jonathan van Tuijl
4117965a4a
Fix Z coordinate in guest debug tab
2020-08-11 03:37:34 +02:00
Jonathan van Tuijl
dcdc782361
Increase minimum window size so pathfind history doesn’t spill out
2020-08-11 03:35:24 +02:00
Gymnasiast
89f04c4fb3
Fix names of two track type functions
2020-08-10 23:48:18 +02:00
Michael Steenbeek
be0123decb
Fix #12611 : Bad check for pay-per-ride ability
2020-08-10 18:56:06 +02:00