This change removes ftell/GetPosition() from hot spots during the startup,
"optimizing" the function for success cases - reading past EOF should
never/rarely happen so it seems fine to let it try to read before checking
Drastically reduces startup speed because of the
optimization applied to ObjectAsset::GetSize - now the file
size is obtained without reading the entire file into memory.
The codes that finds the closest entry that isn't used for remapping has the indices of remappable colors slightly off, and would make some colors in the imported image remappable even though they shouldn't have been.
Comment in header file describing the standard palette corrected as well.
* Code Refactor: Rename vehicle_sprite_type to Pitch
In some of the issues the vehicle_sprite_type is used to check for properties in regards to the pitch of the vehicle.Similarly bank_rotation is used to provide information on the Roll property. This is not in alignment with the https://github.com/OpenRCT2/OpenRCT2/wiki/Coding-Style and makes it harder to refactor other elements of the codebase and makes for undesired nested logics.
This PR also includes the change from rename bank_rotation to Roll in alignment with the OpenRCT2 Coding Style
Related to PullRequest #11956
* Apply formatting
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
* Fix#14449: Surface smoothing not working at extra zooms
Caused by two issues. One was spotted by @AaronVanGeffen in that surface smoothing was turned off. The other was caused by a bug in the opengl renderer that went unnoticed due to never being hit during normal play.
* Fix merrygoround and enterprise extra zoom peep drawing
* Add changelog entry
* Fix some actions for plugins
If an action doesn't have an AcceptParameters method, the paramaters passed in executeAction will be ignored and the action will fail.
* Change plugin parameter names
* Increment plugin API version
* Start a network serialiser for entities
will be used only for checksums and replay diffs
* Continue work
* Use the new serailser for checksums
* Use new serialiser for replays
* keep compilers happy
* Try create checksum stream
* Fix compiling
* Split off class into seperate file
* Update Xcode project
* Increment network version
* Fix pragma mistake
* Fix none network builds
* Update replays
* Improve ChecksumStream and use FNV internally
* Small cleanups
* satisfy compilers
* Revert change of checksum size to simplfy rerecording
* Zero initialise data
* Fix serialiser
* Update replays again
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
Co-authored-by: Matt <m.moninger.h@gmail.com>
When opening and closing the dropdown box multiple times while attempting to create an ad campaign for free food vouchers, the game would duplicate the available food items in the list each time.
I discovered that it was because the vector wasn't being cleared each time the list was populated it, so an easy fix is to clear it before continuing.
Silent