Commit Graph

22888 Commits

Author SHA1 Message Date
ζeh Matt c1bd0ff047
Fix serializer traits 2022-02-16 18:56:43 +02:00
ζeh Matt ff1eb583fc
Make clang-format happy 2022-02-16 18:56:43 +02:00
ζeh Matt d7f5003943
Introduce EntityId and refactor everything 2022-02-16 18:56:39 +02:00
OpenRCT2 git bot 9322f415a9 Merge Localisation/master into OpenRCT2/develop 2022-02-16 04:09:00 +00:00
Ted John 6c3a417af3
Merge pull request #16259 from IntelOrca/refactor/rectangle-maps
Refactor map size to allow for rectangle maps.
2022-02-15 19:08:37 +00:00
Michael Steenbeek ffe67ff33e
Merge pull request #16642 from Gymnasiast/refactor/dropdown
Create Dropdown::Item and use it for gDropdownItems
2022-02-15 18:50:26 +01:00
Ted John b5127089e2 Fix pressed tab for plugin windows 2022-02-15 10:37:18 +00:00
Ted John 44294119c9 More code review changes 2022-02-14 23:20:19 +00:00
Ted John 6d337a15c4 Increment network version 2022-02-14 23:16:47 +00:00
Ted John 45040cd34a More code review changes 2022-02-14 23:15:59 +00:00
Ted John 83c347218b Allow plugins to call change map size game action 2022-02-14 23:15:59 +00:00
Ted John 3d2420c86c More code review changes 2022-02-14 23:15:59 +00:00
Ted John 454bfb0a8f Refactor map size to allow for rectangle maps 2022-02-14 23:15:59 +00:00
Duncan b22ac0551c
Merge pull request #16592 from skdltmxn/fix-integer-overflow
Fix staff statistics overflow
2022-02-14 21:41:52 +00:00
Michael Steenbeek ed657f07f0
Add #16572 to changelog [ci skip] 2022-02-14 21:11:18 +01:00
Ted John efc490d785
Merge pull request #16641 from IntelOrca/plugin/remove-widget-limit
Remove custom window widget limit for plugins, and refactor code that reads the widget flags.
2022-02-14 18:24:13 +00:00
duncanspumpkin 4d341c8518 Update network version 2022-02-14 12:32:14 +00:00
duncanspumpkin 78549b5053 Update replays 2022-02-14 07:42:18 +00:00
skdltmxn 9cd502a9f7 Fix staff statistics overflow 2022-02-14 07:42:18 +00:00
Ted John b775832d01 Refactor window flags to be read with the helper methods 2022-02-13 23:09:42 +00:00
Ted John 05b589fb93 Remove custom window widget limit 2022-02-13 23:09:42 +00:00
Ted John da89a4e413
Remove rct_window::enabled_widgets (#16643)
`enabled_widgets` was used to enable input for widgets. However I do not recall anywhere this being used to specifically disable a widget which doesn't use the dedicated `disabled_widgets` flag. I don't think there is any purpose in keeping this, so I have removed all uses of it.
2022-02-13 23:06:19 +00:00
Silent 09897ede9e
Refactor last_*_directory and last_run_version to use u8string
Fixes a regression from #16631 causing a crash when
constructing u8string from a nullptr
2022-02-13 21:34:26 +01:00
Michael Steenbeek 34aafa5e14
Merge pull request #16638 from Gymnasiast/fix/16576
Fix #16576: Cannot select vehicle types with entry index >= 256
2022-02-13 21:33:53 +01:00
Gymnasiast 9441d4b24f
Bump network version 2022-02-13 21:11:18 +01:00
Gymnasiast 4abbfcb32b
Create dropdown item flags 2022-02-13 00:14:33 +01:00
Gymnasiast 723867e0a0
Create Dropdown::Item and use it for gDropdownItems 2022-02-12 23:57:22 +01:00
Gymnasiast a17c4ad304
Rename Dropdown::Item to ItemExt 2022-02-12 23:42:59 +01:00
Karst 9dd54b9ee1
Add Inline Twist to B&M Track (#16389)
This adds the inline twist to the B&M track.

Feature is complete. Note: The inline twist doesn't draw correctly when going out of the tunnel. This is sadly an original bug, as this is also present on the Flying RC's Flying Twist (#7466).
2022-02-12 22:31:08 +01:00
Gymnasiast 49ccc21d84
Fix #16576: Cannot select vehicle types with entry index >= 256 2022-02-12 20:43:45 +01:00
Gymnasiast 3ff8225bb9
Replace some uint8_t in Ride.cpp 2022-02-12 20:43:45 +01:00
ζeh Matt c0474d2d27
Merge pull request #16466 from ZehMatt/refactor/identifier-rideid
Use TIdentifier for RideId
2022-02-12 11:23:54 -08:00
Michael Steenbeek ee54603695
Rename value strings for spinners (#16637) 2022-02-12 20:17:37 +01:00
Michael Steenbeek 44a607800e
Bring ImageImporter enum names in line with code style 2022-02-12 18:56:17 +01:00
ζeh Matt 004cf02c26
Fix variable name type conflict 2022-02-12 18:15:19 +02:00
ζeh Matt f22142d2cf
Use RideId::GetNull over SELECTED_RIDE_UNDEFINED 2022-02-12 18:13:50 +02:00
ζeh Matt f4d105f843
Remove NetworkRideId 2022-02-12 18:11:18 +02:00
ζeh Matt 1fe6c0618b
Fix clang format 2022-02-12 18:11:18 +02:00
ζeh Matt 06e430157f
Use RideId::GetNull and RideId::IsNull over constant 2022-02-12 18:11:18 +02:00
ζeh Matt 4554d6d883
Fix all uses of RideId 2022-02-12 18:11:18 +02:00
ζeh Matt 0656df4a65
Fix passing RideId to Formatter 2022-02-12 18:11:18 +02:00
ζeh Matt 2c72940cfd
Use TIdentifier for RideId 2022-02-12 18:11:18 +02:00
ζeh Matt a2470c0573
Rename ride_id_t to RideId 2022-02-12 18:11:18 +02:00
Michael Steenbeek 8efc941fee
Fix #16227: Assertion hit in fix_duplicated_banners()
Refactor error, introduced in 63a2e9d716#
2022-02-12 17:03:56 +01:00
Michael Steenbeek 2e37f12365
Merge pull request #16631 from CookiePLMonster/fix-crashy-paths
Fix more crashes related to paths
2022-02-12 16:07:26 +01:00
Silent 5028ce3bf6
Turn GeneralConfiguration::rct1_path into an u8string
Fixes a crash when opening Advanced Options on the first launch
2022-02-12 16:07:04 +01:00
Silent 4621cc4264
Json: Fix wrong implicit path typecasts in ReadFromFile and WriteToFile
These functions accepted fs::path which meant passing a u8string to them
wrongly assumed an ANSI encoding and not UTF-8. This would be
a non-issue in C++20 where char8_t is separate, but until then it was an issue
causing incorrect character conversions, and thus an exception.
2022-02-12 14:36:37 +01:00
Michael Steenbeek 81e69ef4e9
Merge pull request #16628 from Gymnasiast/fix/16572
Fix #16572: Crash Placing Track Designs Due to OOB Read on Research.cpp:554
2022-02-12 12:29:52 +01:00
Michael Steenbeek f0ee220ec6
Fix messages [ci skip]
Co-authored-by: pizza2004 <chad@neejean.org>
2022-02-12 12:28:37 +01:00
Michael Steenbeek 29506a3748
Fix #16623: Large Scenery supports don’t render correctly 2022-02-12 12:26:39 +01:00