Commit Graph

12964 Commits

Author SHA1 Message Date
Ted John 61d64ab8c5 Do not use user strings for banners 2019-07-29 19:18:16 +01:00
Ted John 300ce9727e Protect against nullptr 2019-07-29 19:18:16 +01:00
Ted John 749b07e83f Use local variable for format arguments 2019-07-29 19:18:16 +01:00
Ted John 772475848b Fix formatting 2019-07-29 19:18:16 +01:00
Ted John eb4c9acb08 Fix compile errors and ride entry null edge case 2019-07-29 19:18:16 +01:00
Ted John 1d4c1958dd Do not allow duplicate ride names 2019-07-29 19:18:16 +01:00
Ted John f8b08b334e Fix a few more bugs 2019-07-29 19:18:16 +01:00
Ted John 3f8890afde Fix remaining errors and a few bugs 2019-07-29 19:18:16 +01:00
Ted John 3f45976009 Fix openrct2ui errors 2019-07-29 19:18:16 +01:00
Ted John 3155c661fa Refactor format peep action 2019-07-29 19:18:16 +01:00
Ted John 6fff2079f9 Refactor ride name to dynamic args and std::string 2019-07-29 19:18:16 +01:00
Ted John 3ee7824df4
Fix #9678: Korean scenario name is not saved (#9679) 2019-07-29 19:17:49 +01:00
Jim Armstrong a432a8a514 Fix #9487: Access violation in UpdateRideEnterVehicle (#9577)
* Fix #9487: Implement nullptr checks

Implemented nullptr checks for the ride and vehicle variables
in UpdateRideEnterVehicle()
2019-07-29 18:07:21 +01:00
Ted John 0315c9b741
Add lots of guards to track block get next / previous (#9661) 2019-07-29 16:37:51 +01:00
Aaron van Geffen 5066ebebf9
Fix #9574: Text overflow in scenario objective window. 2019-07-29 15:16:36 +02:00
Hielke Morsink 3ac43114a6 Fix: tile inspector hotkey does not work with debugging tools disabled (#9669)
* Fix: tile inspector hotkey does not work with debugging tools disabled

* Update changelog
2019-07-28 16:55:11 +02:00
Michał Janiszewski 83e26804e5 Limit scrolling text colour to valid options (#9639) 2019-07-27 14:23:34 +02:00
Michael Steenbeek 382935c50f
Merge pull request #9644 from IntelOrca/refactor/banners
Refactor banners
2019-07-27 10:59:57 +02:00
Ted John 0b4d989a67 Rename get_banner to GetBanner 2019-07-26 17:24:19 +01:00
Ted John 3bff25ab22 Use TileCoordsXY 2019-07-26 17:14:09 +01:00
Duncan 75e0757ee9
Merge pull request #9632 from ZehMatt/fix-9625
Fix #9625: Show correct cost in scenery selection
2019-07-26 07:12:57 +01:00
Ted John 5c07c53faf Refactor get banner 2019-07-25 22:21:19 +01:00
Ted John 85543bd1c8 Separate RCT2 and OpenRCT2 banner struct 2019-07-25 22:21:19 +01:00
Duncan 9b4f8a6b4b
Merge pull request #9451 from ZehMatt/refactor/sprite-create-untangle
Refactor create_sprite
2019-07-25 06:50:57 +01:00
Michael Steenbeek e5ed5568a8
Remove conversion from UTF-8 to widechar and back again (#9637) 2019-07-24 21:56:49 +02:00
Matt f3638ca858
Address code review 2019-07-24 18:12:25 +02:00
Matt 3395079737
Remove NUM_SPRITE_LISTS macro and replace with SPRITE_LIST_COUNT for consistency 2019-07-24 17:53:54 +02:00
Matt 98a17fe8d9
Refactor create_sprite and remove unnecessary move_sprite_to_list 2019-07-24 17:53:51 +02:00
Michał Janiszewski 837879018f
Make socket status atomic (#9636)
* Make socket status atomic

`TcpSocket::ConnectAsync` will call `Connect` and modify `_status` from
a different thread and must ensure it doesn't introduce a data race.

* Update src/openrct2/network/Socket.cpp

Co-Authored-By: ζeh Matt <m.moninger.h@gmail.com>
2019-07-24 15:05:26 +02:00
Ted John 83b1d1f72e
Merge pull request #9629 from IntelOrca/fix/utf8-support-windows
Fix UTF-8 support on Windows
2019-07-23 22:15:56 +01:00
Ted John 7a2a5a7924 Fix #9626: Crash when navigating to price tab on park window (#9634)
The park name argument was being overwritten by the price argument in the argument buffer. Draw price text in paint event instead.
2019-07-23 21:47:53 +02:00
Matt 126226dbe3
Fix #9625: Show correct cost in scenery selection 2019-07-23 18:03:26 +02:00
Ted John a1d9e52046 Rename ToUtf16 to ToWideChar
This is more correct as wchar_t size can differ, for example Linux typically uses 32 bits for wchar_t where as Windows uses 16 bits.
2019-07-22 23:44:03 +01:00
Ted John 6f61c94dbd Remove old widechar <-> utf-8 conversion function 2019-07-22 23:44:03 +01:00
Ted John 3e28073981 Log path when loading / saving park 2019-07-22 22:15:01 +01:00
Ted John 8cd684924e Set console encoding to UTF-8 for Windows 2019-07-22 22:13:38 +01:00
Duncan ab5f5b20cd
Use enum class for RCT2_SOUND (#9618)
* Use enum class for RCT2_SOUND

* Fix formatting. Fix mistaken declaration.

* Change name of enum to SoundId

* Fix clang format
2019-07-22 19:02:45 +01:00
ζeh Matt 5a6f573f6b
Merge pull request #9466 from ZehMatt/opengl/rain
Fix #6515: Add rain rendering to OpenGL renderer
2019-07-21 19:29:03 +02:00
Hielke Morsink 2792ddfe80 Tile Inspector: Use correct names for up/down buttons
This little mistake has been around for years and is most likely caused
by reordering the buttons. They used to be side-to-side, but their names
were never changed, and since the order of tile elements is reversed I
never noticed it was wrong.
2019-07-21 11:34:50 +02:00
Ted John 5733d666b3 Do not store park name as a user string 2019-07-21 11:33:15 +02:00
Cody Brittain 5342a6d9a9 Renamed sound enums for accuracy and organization 2019-07-20 12:41:36 +02:00
Matt 2cf4a42cbe
Add rain rendering to OpenGL renderer 2019-07-18 20:54:47 +02:00
FredFucks d44e89d9a4 Fix Chinese fonts on Linux with "WenQuanYi Micro Hei" (#9584) 2019-07-17 11:22:38 +02:00
Ferdinand Thiessen 7b317e312c Fix Werror=maybe-uninitialized issue of struct, found by gcc 9.1.1. (#9578) 2019-07-16 10:20:15 +02:00
Duncan b32f799e21
Merge pull request #9546 from aaruel/vector-locations
Refactor #9110: Use a vector for station locations list in sub_6CB945
2019-07-14 17:46:29 +01:00
Michael Steenbeek 3706581073
Add support for drawing en-dash and multiplication sign (#9570) 2019-07-14 15:58:33 +02:00
Michael Steenbeek aff3e42408
Merge pull request #9453 from duncanspumpkin/remove_gc
Remove Networked Game Commands
2019-07-14 14:46:46 +02:00
Cody Brittain 238a10034e Remove sloped curves from Spinning Wild Mouse 2019-07-14 14:05:27 +02:00
Duncan 4e44818a04
Merge pull request #9449 from ZehMatt/refactor/sprite-list-pow2
Remove unnecessary multiplication and division for sprite lists
2019-07-13 09:37:35 +01:00
duncanspumpkin fc657e2571 Revert name change in RCT12 struct to reflect its use.
The new linked_list_index is only for the internal sprite base struct. When importing we are referring to the old linked_list_type_offset. If the names were the same it would not provide any information as to why one was a factor of two different.
2019-07-13 07:20:15 +01:00