Commit Graph

18697 Commits

Author SHA1 Message Date
Eilidh Martin fdbceae17c
Fix #18324: Refactor TitleOptions to class 2022-10-17 15:29:17 +02:00
Rik Smeets c80bd455e9
Code style: Remove struct snakes from Paint (#18341) 2022-10-14 20:26:36 +02:00
Silent db6af4b362
Ensure argv on Windows is nullptr-terminated (#18331) 2022-10-14 09:31:55 +02:00
AuraSpecs 46fa09ca91
Fix: Sides of River Rapids’ corners overlay other parts of the track (#17316) 2022-10-13 20:52:48 +02:00
AuraSpecs dda256ef5f
Add inverted large loops and inverted boosters to Flying RC 2022-10-13 20:51:54 +02:00
Rik Smeets 94e8e9ea6b
Fix #18094: Invisible underground shops/facilities
Underground shops and facilities placed right next to non-underground path would be connected to the path, but the buildings themselves would remain invisible. Guests could use them though.

This has been fixed by drawing a tunnel, which is the same way ride entrances/exits are drawn.
2022-10-13 16:54:19 +00:00
Raymond Zhao a45f898c7e
Close #18322: Refactor TitleLogo window to class 2022-10-13 12:16:16 +02:00
Duncan 406b73d904
Remove final snakes from map and world (#18304) 2022-10-12 09:14:45 -03:00
Duncan 7dd8989e70
Next chunk of World/Map.h snakes (#18296)
* Next chunk of World/Map.h snakes

* Apply clang-format
2022-10-12 06:35:20 +01:00
Michael Steenbeek 7be8f475f3
Merge pull request #18292 from Gymnasiast/fix/18290
Fix #18290: Ride and plug-in window colours not appearing
2022-10-11 21:43:53 +02:00
Duncan 67bbc8560d
Code style: Remove snakes from everything world apart from Map.h (#18273)
* Remove remaining snakes from world (outside of map)

* Initial few desnaking of Map.h
2022-10-11 19:39:24 +01:00
Gymnasiast de71ed19b5
Remove remaining usages of SPRITE_ID_PALETTE_COLOUR_1() 2022-10-11 14:54:27 +02:00
Gymnasiast 418c5a6708
Use GetColourButtonImage() for remaining windows 2022-10-11 14:44:45 +02:00
Gymnasiast 89cd86da4d
Fix #18290: Ride and plug-in window colours not appearing 2022-10-11 14:44:07 +02:00
Rik Smeets 0c78a27d9f
Fix missing validation on invalid characters in file name (#18287)
When saving a new file with a name containing '/' or '\' on Windows, the incorrect file name would be determined since these characters represent a new folder. This would trigger a failure on save.

The user's input should be validated in all cases. Before, it was only executed for folder names. This change also applies the validation on file names.
2022-10-11 13:27:11 +02:00
Michael Steenbeek 6fe19878f6
More ImageId cleanup (#18258)
* Remove more usages of uint32 image indices

* Remove unused gfx_get_sprite_size()

* Remove uint32 images from text drawing

* Remove now-unused ImageId overload

* Default-initialise ttfRunIndex

* Suppress false-alarm GCC error
2022-10-10 19:42:40 +01:00
Rik Smeets 3fa7d59a1c
Fix #18070: Entrances/exits clip through walls (#18266)
Entrance or exit buildings placed underground could clip through walls.
2022-10-09 17:49:01 +02:00
Silent 9ea6351708
Windows: Use a modern file/folder picker 2022-10-09 17:12:46 +02:00
Michael Steenbeek def6b705cf
Merge pull request #18257 from rik-smeets/improve-crossing-behaviour
Fix guests 'waiting' on extended railway crossings
2022-10-09 17:10:14 +02:00
Rik Smeets 7c2ec714f7 Improve method name for level crossing check 2022-10-09 11:01:10 +02:00
Gymnasiast 079253e168
Remove now-unused SawyerEncoding.{cpp,h} 2022-10-08 23:09:07 +02:00
Gymnasiast c33e377d7c
Close #17341: Always allow loading with incorrect checksum 2022-10-08 22:58:23 +02:00
Rik Smeets bba54d2ecc Fix guests 'waiting' on extended railway crossings
On extended railway crossings, guests would stop to 'wait' for the passing train, which would then phase right through them. This change at least allows guests a chance to get to a safe place.
2022-10-08 21:59:26 +02:00
Michael Steenbeek bfd333bb38
Merge pull request #18217 from CookiePLMonster/fix-18200
Refactor Windows locales and remove the last non-Unicode functions
2022-10-08 21:47:12 +02:00
Michael Steenbeek c31482a3c3
Merge pull request #18255 from Gymnasiast/refactor/load-s6-s4
Remove old S6/S4 loading functions
2022-10-08 21:46:32 +02:00
Rik Smeets 8e33cf580f Code style: Remove snakes from virtual floor 2022-10-08 20:50:59 +02:00
Rik Smeets 4c06c2d5bb Code style: Remove snakes from path supports 2022-10-08 20:50:54 +02:00
Gymnasiast 900eea48b2
Consolidate landscape loading functions 2022-10-08 20:12:35 +02:00
Gymnasiast a3800320bc
Replace load_from_sv4() and load_from_sc4() 2022-10-08 20:12:35 +02:00
Gymnasiast 830fedb6b8
Replace load_from_sv6() and load_from_sc6() 2022-10-08 20:12:35 +02:00
Gymnasiast d5f6a5b285
Replace context_load_park_from_file() with object equivalent 2022-10-08 20:12:35 +02:00
Rik Smeets ffab787c73 Consistent naming of ImageId parameter 2022-10-08 19:59:38 +02:00
Rik Smeets 1d557f40ee Code style: Remove snakes from steel supports 2022-10-08 19:59:32 +02:00
Rik Smeets 0bf64f0228 Remove unused wooden support methods 2022-10-08 19:21:23 +02:00
Rik Smeets 29f61fd403 Code style: Remove snakes from wooden supports 2022-10-08 19:20:59 +02:00
Duncan 5dba30778d
Code style: Remove more snakes from the park, maphelper, scenery. (#18222) 2022-10-08 06:56:17 -03:00
Haven Kim 34170d6814
Fix #17853: Invention name tears while being dragged (#18223) 2022-10-08 06:52:32 -03:00
Rik Smeets 00d2dd8ef7
Code Style: Remove snake casing in PaintHelpers (#18247) 2022-10-08 11:24:50 +02:00
ZeeMajora ea04c0b010
Corkscrew rc's large flat to steep pieces available cheatless (#18230)
Makes the corkscrew roller coaster's large flat to steep pieces available without cheats for consistency with the looping & twister roller coasters which are similar coaster types that have this element available without cheats.
2022-10-07 22:27:58 +02:00
Hielke Morsink d4774293d5
Fix #18064: Unable to dismiss notification messages 2022-10-07 16:44:06 +02:00
Silent 0f978fe907
Remove the last non-Unicode Windows functions 2022-10-07 15:05:43 +02:00
Silent e825ffade7
Platform.Win32: Migrate to modern locale functions and names 2022-10-07 15:05:43 +02:00
leoleotte 0dee78bfe5
Close #13774: Refactor Footpath window to class 2022-10-06 19:41:31 +00:00
Michael Steenbeek fa81f119c2
Merge pull request #18208 from Gymnasiast/fix/18204
Fix #18204: Crash opening New Ride window with invalid highlight
2022-10-06 10:54:19 +02:00
Thomas Fai 8e3a0ee814
Part of #16033: VehiclePaint constants 2022-10-05 21:01:06 +00:00
ZeeMajora e6df43b7c9
Extras tab: add Tycoon park, keep competitions apart 2022-10-05 20:51:37 +00:00
Michael Steenbeek 051ede1598
Merge pull request #18213 from duncanspumpkin/codeStyle4
Code style: Remove snakes from Location, LargeScenery and MapAnimation
2022-10-05 22:36:39 +02:00
Michael Steenbeek 99e13e023e
Name unknown_15 window event as ScrollSelect
Co-authored-by: leoleotte <leoleotte@users.noreply.github.com>
2022-10-05 21:59:20 +02:00
Rik Smeets c5904d81d6
Code Style: Remove snakes from paint tile elements (#18212) 2022-10-05 21:27:38 +02:00
duncanspumpkin 16581e9288 Address snakes in mapgen and map animation 2022-10-05 20:22:51 +01:00