From 2b08f21625da0c0425bc8f5843b802f84b72a0b6 Mon Sep 17 00:00:00 2001 From: Charles Pigott Date: Sat, 13 Feb 2021 21:50:51 +0000 Subject: [PATCH] Fix #8625: Wrong ending year was displayed in highscore table --- known-bugs.txt | 9 +++++++++ src/highscore_gui.cpp | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/known-bugs.txt b/known-bugs.txt index a687dff4a5..ddfe7aa0c1 100644 --- a/known-bugs.txt +++ b/known-bugs.txt @@ -409,3 +409,12 @@ Involuntary cargo exchange with cargodist via neutral station [#6114]: shared station make the order "no unload" and if you're unloading make it "no load". Cargodist will then figure out that it should not create such a route. + +Incorrect ending year displayed in end of game newspaper [#8625] + The ending year of the game is configurable, but the date displayed in + the newspaper at the end of the game is part of the graphics, not text. + So to fix this would involve fixing the graphics in every baseset, + including the original. Additionally, basesets are free to put this + text in different positions (which they do), making a proper solution + to this infinitely more complex for a part of the game that fewer than + 1% of players ever see. diff --git a/src/highscore_gui.cpp b/src/highscore_gui.cpp index a473424f81..b1c428a768 100644 --- a/src/highscore_gui.cpp +++ b/src/highscore_gui.cpp @@ -183,7 +183,7 @@ struct HighScoreWindow : EndGameHighScoreBaseWindow { this->SetupHighScoreEndWindow(); Point pt = this->GetTopLeft(ScaleGUITrad(640), ScaleGUITrad(480)); - SetDParam(0, ORIGINAL_END_YEAR); + SetDParam(0, _settings_game.game_creation.ending_year); DrawStringMultiLine(pt.x + ScaleGUITrad(70), pt.x + ScaleGUITrad(570), pt.y, pt.y + ScaleGUITrad(140), !_networking ? STR_HIGHSCORE_TOP_COMPANIES_WHO_REACHED : STR_HIGHSCORE_TOP_COMPANIES_NETWORK_GAME, TC_FROMSTRING, SA_CENTER); /* Draw Highscore peepz */