From f9988abf32bb911d98f442195bb1a30f2d346918 Mon Sep 17 00:00:00 2001 From: Peter Nelson Date: Tue, 23 Apr 2024 20:50:09 +0100 Subject: [PATCH] Fix #12497: [NewGRF] Increase vehicle motion counter for all parts. NewGRFs relied on the incorrectly motion counter that was 'fixed' in #12229, so always update v->motion_counter for all vehicle parts. --- src/vehicle.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vehicle.cpp b/src/vehicle.cpp index 2e1b82b172..d0a16880f6 100644 --- a/src/vehicle.cpp +++ b/src/vehicle.cpp @@ -1033,6 +1033,9 @@ void CallVehicleTicks() /* Do not play any sound when stopped */ if ((front->vehstatus & VS_STOPPED) && (front->type != VEH_TRAIN || front->cur_speed == 0)) continue; + /* Update motion counter for animation purposes. */ + v->motion_counter += front->cur_speed; + /* Check vehicle type specifics */ switch (v->type) { case VEH_TRAIN: @@ -1051,7 +1054,6 @@ void CallVehicleTicks() break; } - v->motion_counter += front->cur_speed; /* Play a running sound if the motion counter passes 256 (Do we not skip sounds?) */ if (GB(v->motion_counter, 0, 8) < front->cur_speed) PlayVehicleSound(v, VSE_RUNNING);