From 737e3feaf024f2ccebc4fdee9ec468a8f6c133de Mon Sep 17 00:00:00 2001 From: Peter Nelson Date: Mon, 18 Mar 2024 23:39:42 +0000 Subject: [PATCH] Codechange: Don't delete news items or NewGRF window when EffectVehicle is deleted. (#12334) EffectVehicles never create news and can't be debugged, so searching for news items and windows to delete just wastes time. --- src/vehicle.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vehicle.cpp b/src/vehicle.cpp index ccd259cb36..044c8013c9 100644 --- a/src/vehicle.cpp +++ b/src/vehicle.cpp @@ -908,8 +908,10 @@ Vehicle::~Vehicle() UpdateVehicleTileHash(this, true); UpdateVehicleViewportHash(this, INVALID_COORD, 0, this->sprite_cache.old_coord.left, this->sprite_cache.old_coord.top); - DeleteVehicleNews(this->index, INVALID_STRING_ID); - DeleteNewGRFInspectWindow(GetGrfSpecFeature(this->type), this->index); + if (this->type != VEH_EFFECT) { + DeleteVehicleNews(this->index, INVALID_STRING_ID); + DeleteNewGRFInspectWindow(GetGrfSpecFeature(this->type), this->index); + } } /**