From a1f49db54dd71af71f664a2c6b1a8f8c33e3fb7f Mon Sep 17 00:00:00 2001 From: rubidium Date: Fri, 4 Sep 2009 20:31:49 +0000 Subject: [PATCH] (svn r17416) -Codechange: move the build date/time 'determination' to rev.cpp as that's the file most likely to be regularly recompiled --- src/os/windows/crashlog_win.cpp | 8 +++++--- src/rev.cpp.in | 8 ++++++++ src/rev.h | 1 + 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/os/windows/crashlog_win.cpp b/src/os/windows/crashlog_win.cpp index f24d499dc0..cf622fc527 100644 --- a/src/os/windows/crashlog_win.cpp +++ b/src/os/windows/crashlog_win.cpp @@ -292,7 +292,7 @@ static LONG WINAPI ExceptionHandler(EXCEPTION_POINTERS *ep) output += seprintf(output, last, "*** OpenTTD Crash Report ***\r\n" "Date: %d-%.2d-%.2d %.2d:%.2d:%.2d\r\n" - "Build: %s (%d) built on " __DATE__ " " __TIME__ "\r\n", + "Build: %s (%d) built on %s\r\n", time.wYear, time.wMonth, time.wDay, @@ -300,7 +300,8 @@ static LONG WINAPI ExceptionHandler(EXCEPTION_POINTERS *ep) time.wMinute, time.wSecond, _openttd_revision, - _openttd_revision_modified + _openttd_revision_modified, + _openttd_build_date ); } @@ -437,7 +438,8 @@ static LONG WINAPI ExceptionHandler(EXCEPTION_POINTERS *ep) MINIDUMP_EXCEPTION_INFORMATION mdei; MINIDUMP_USER_STREAM userstream; MINIDUMP_USER_STREAM_INFORMATION musi; - char msg[] = "****** Built on " __DATE__ " " __TIME__ ". ******"; + char msg[64]; + seprintf(msg, lastof(msg), "****** Built on %s. ******", _openttd_build_date); userstream.Type = LastReservedStream + 1; userstream.Buffer = msg; diff --git a/src/rev.cpp.in b/src/rev.cpp.in index e83c34771f..21e084709e 100644 --- a/src/rev.cpp.in +++ b/src/rev.cpp.in @@ -29,6 +29,14 @@ */ const char _openttd_revision[] = "!!VERSION!!"; +/** + * The text version of OpenTTD's build date. + * Updating the build date in this file is the safest as it generally gets + * updated for each revision in contrary to most other files that only see + * updates when they are actually changed themselves. + */ +const char _openttd_build_date[] = __DATE__ " " __TIME__; + /** * Let us know if current build was modified. This detection * works even in the case when revision string is overriden by diff --git a/src/rev.h b/src/rev.h index 485a77eba4..621a41c4ba 100644 --- a/src/rev.h +++ b/src/rev.h @@ -13,6 +13,7 @@ #define REV_H extern const char _openttd_revision[]; +extern const char _openttd_build_date[]; extern const byte _openttd_revision_modified; extern const uint32 _openttd_newgrf_version;