From c91a2e0f2655031c3b4cc70178021176699a1f9d Mon Sep 17 00:00:00 2001 From: tron Date: Fri, 3 Mar 2006 21:18:19 +0000 Subject: [PATCH] (svn r3751) -Fix: Correctly implement minimum search, so road vehicles head twoards the closest station, not the last one in the list --- roadveh_cmd.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/roadveh_cmd.c b/roadveh_cmd.c index e4b5ae6eb8..4500664f77 100644 --- a/roadveh_cmd.c +++ b/roadveh_cmd.c @@ -633,8 +633,9 @@ static void ProcessRoadVehOrder(Vehicle *v) if (order->type == OT_GOTO_STATION) { const Station* st = GetStation(order->station); - uint mindist = 0xFFFFFFFF; const RoadStop* rs; + TileIndex dest; + uint mindist; if (order->station == v->last_station_visited) { v->last_station_visited = INVALID_STATION; @@ -649,9 +650,17 @@ static void ProcessRoadVehOrder(Vehicle *v) return; } - for (; rs != NULL; rs = rs->next) { - if (DistanceManhattan(v->tile, rs->xy) < mindist) v->dest_tile = rs->xy; + dest = rs->xy; + mindist = DistanceManhattan(v->tile, rs->xy); + for (rs = rs->next; rs != NULL; rs = rs->next) { + uint dist = DistanceManhattan(v->tile, rs->xy); + + if (dist < mindist) { + mindist = dist; + dest = rs->xy; + } } + v->dest_tile = dest; } else if (order->type == OT_GOTO_DEPOT) { v->dest_tile = GetDepot(order->station)->xy; }