mirrors
/
blocky
mirror of https://github.com/0xERR0R/blocky.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Request duration metric is not populated if request resolution was faulty (#257)

This commit is contained in:
Dimitri Herzog 2021-08-30 21:43:21 +02:00
parent 26efda23bf
commit 48a3802b06
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
resolver/metrics_resolver.go
View File

@ -31,6 +31,15 @@ func (m *MetricsResolver) Resolve(request *Request) (*Response, error) {
"client": strings.Join(request.ClientNames, ","),
"type": dns.TypeToString[request.Req.Question[0].Qtype]}).Inc()
reqDurationMs := float64(time.Since(request.RequestTS).Milliseconds())
responseType := "err"
if response != nil {
responseType = response.RType.String()
}
m.durationHistogram.WithLabelValues(responseType).Observe(reqDurationMs)
if err != nil {
m.totalErrors.Inc()
} else {
@ -38,8 +47,6 @@ func (m *MetricsResolver) Resolve(request *Request) (*Response, error) {
"reason": response.Reason,
"response_code": dns.RcodeToString[response.Res.Rcode],
"response_type": response.RType.String()}).Inc()
reqDurationMs := float64(time.Since(request.RequestTS).Milliseconds())
m.durationHistogram.WithLabelValues(response.RType.String()).Observe(reqDurationMs)
}
}