From 8a93e4500c0de0110fdeae66e9c19eabaf7f3a0a Mon Sep 17 00:00:00 2001 From: ThinkChaos Date: Mon, 8 May 2023 12:09:53 -0400 Subject: [PATCH] style: fix all existing lint errors --- api/api_endpoints_test.go | 2 +- cmd/healthcheck.go | 1 + querylog/none_writer.go | 2 +- redis/redis_suite_test.go | 2 +- resolver/mocks_test.go | 12 ++++++------ 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/api/api_endpoints_test.go b/api/api_endpoints_test.go index 8acb2248..a6445b95 100644 --- a/api/api_endpoints_test.go +++ b/api/api_endpoints_test.go @@ -29,7 +29,7 @@ func (b *BlockingControlMock) EnableBlocking() { b.enabled = true } -func (b *BlockingControlMock) DisableBlocking(_ time.Duration, disableGroups []string) error { +func (b *BlockingControlMock) DisableBlocking(time.Duration, []string) error { b.enabled = false return nil diff --git a/cmd/healthcheck.go b/cmd/healthcheck.go index 37358e08..f772b968 100644 --- a/cmd/healthcheck.go +++ b/cmd/healthcheck.go @@ -25,6 +25,7 @@ func NewHealthcheckCommand() *cobra.Command { } func healthcheck(cmd *cobra.Command, args []string) error { + _ = args port, _ := cmd.Flags().GetUint16("port") c := new(dns.Client) diff --git a/querylog/none_writer.go b/querylog/none_writer.go index cad5f8b9..856b9551 100644 --- a/querylog/none_writer.go +++ b/querylog/none_writer.go @@ -6,7 +6,7 @@ func NewNoneWriter() *NoneWriter { return &NoneWriter{} } -func (d *NoneWriter) Write(entry *LogEntry) { +func (d *NoneWriter) Write(*LogEntry) { // Nothing to do } diff --git a/redis/redis_suite_test.go b/redis/redis_suite_test.go index 44b1e08e..34ee9133 100644 --- a/redis/redis_suite_test.go +++ b/redis/redis_suite_test.go @@ -19,4 +19,4 @@ func TestRedisClient(t *testing.T) { type NoLogs struct{} -func (l NoLogs) Printf(ctx context.Context, format string, v ...interface{}) {} +func (l NoLogs) Printf(context.Context, string, ...interface{}) {} diff --git a/resolver/mocks_test.go b/resolver/mocks_test.go index 567e0600..6769aafa 100644 --- a/resolver/mocks_test.go +++ b/resolver/mocks_test.go @@ -41,7 +41,7 @@ func (r *mockResolver) IsEnabled() bool { } // LogConfig implements `config.Configurable`. -func (r *mockResolver) LogConfig(logger *logrus.Entry) { +func (r *mockResolver) LogConfig(*logrus.Entry) { r.Called() } @@ -193,11 +193,11 @@ var aMockConn = &mockConn{} type mockConn struct{} -func (c *mockConn) Read(b []byte) (n int, err error) { +func (c *mockConn) Read([]byte) (n int, err error) { panic("not implemented") } -func (c *mockConn) Write(b []byte) (n int, err error) { +func (c *mockConn) Write([]byte) (n int, err error) { panic("not implemented") } @@ -213,14 +213,14 @@ func (c *mockConn) RemoteAddr() net.Addr { panic("not implemented") } -func (c *mockConn) SetDeadline(t time.Time) error { +func (c *mockConn) SetDeadline(time.Time) error { panic("not implemented") } -func (c *mockConn) SetReadDeadline(t time.Time) error { +func (c *mockConn) SetReadDeadline(time.Time) error { panic("not implemented") } -func (c *mockConn) SetWriteDeadline(t time.Time) error { +func (c *mockConn) SetWriteDeadline(time.Time) error { panic("not implemented") }