mirrors
/
ctop
mirror of https://github.com/bcicen/ctop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor string on multiple places to constant

This commit is contained in:
bartfokker 2018-10-25 22:23:44 +02:00
parent 8a0bd3cf8a
commit 3c83b7576b
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
container/main.go
View File

@ -13,6 +13,10 @@ var (
log = logging.Init() log = logging.Init()
) )
const (
running = "running"
)
// Metrics and metadata representing a container // Metrics and metadata representing a container
type Container struct { type Container struct {
models.Metrics models.Metrics
@ -60,12 +64,12 @@ func (c *Container) GetMeta(k string) string {
func (c *Container) SetState(s string) { func (c *Container) SetState(s string) {
c.SetMeta("state", s) c.SetMeta("state", s)
// start collector, if needed // start collector, if needed
if s == "running" && !c.collector.Running() { if s == running && !c.collector.Running() {
c.collector.Start() c.collector.Start()
c.Read(c.collector.Stream()) c.Read(c.collector.Stream())
} }
// stop collector, if needed // stop collector, if needed
if s != "running" && c.collector.Running() { if s != running && c.collector.Running() {
c.collector.Stop() c.collector.Stop()
} }
} }
@ -90,18 +94,18 @@ func (c *Container) Read(stream chan models.Metrics) {
} }
func (c *Container) Start() { func (c *Container) Start() {
if c.Meta["state"] != "running" { if c.Meta["state"] != running {
if err := c.manager.Start(); err != nil { if err := c.manager.Start(); err != nil {
log.Warningf("container %s: %v", c.Id, err) log.Warningf("container %s: %v", c.Id, err)
log.StatusErr(err) log.StatusErr(err)
return return
} }
c.SetState("running") c.SetState(running)
} }
} }
func (c *Container) Stop() { func (c *Container) Stop() {
if c.Meta["state"] == "running" { if c.Meta["state"] == running {
if err := c.manager.Stop(); err != nil { if err := c.manager.Stop(); err != nil {
log.Warningf("container %s: %v", c.Id, err) log.Warningf("container %s: %v", c.Id, err)
log.StatusErr(err) log.StatusErr(err)
@ -119,7 +123,7 @@ func (c *Container) Remove() {
} }
func (c *Container) Pause() { func (c *Container) Pause() {
if c.Meta["state"] == "running" { if c.Meta["state"] == running {
if err := c.manager.Pause(); err != nil { if err := c.manager.Pause(); err != nil {
log.Warningf("container %s: %v", c.Id, err) log.Warningf("container %s: %v", c.Id, err)
log.StatusErr(err) log.StatusErr(err)
@ -136,12 +140,12 @@ func (c *Container) Unpause() {
log.StatusErr(err) log.StatusErr(err)
return return
} }
c.SetState("running") c.SetState(running)
} }
} }
func (c *Container) Restart() { func (c *Container) Restart() {
if c.Meta["state"] == "running" { if c.Meta["state"] == running {
if err := c.manager.Restart(); err != nil { if err := c.manager.Restart(); err != nil {
log.Warningf("container %s: %v", c.Id, err) log.Warningf("container %s: %v", c.Id, err)
log.StatusErr(err) log.StatusErr(err)