mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-08-30 06:16:06 +02:00
![qwerty287](/assets/img/avatar_default.png)
* Add missing `X-Total-Count` and fix some related bugs
Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70)
)
* crash with index out of bounds, API issue/issueSubscriptions
I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.
Closes #13043
* fmt
* Update routers/api/v1/repo/issue_subscription.go
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Use FindAndCount
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
150 lines
4.9 KiB
Go
150 lines
4.9 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package models
|
|
|
|
import (
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
)
|
|
|
|
// IssueWatch is connection request for receiving issue notification.
|
|
type IssueWatch struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UserID int64 `xorm:"UNIQUE(watch) NOT NULL"`
|
|
IssueID int64 `xorm:"UNIQUE(watch) NOT NULL"`
|
|
IsWatching bool `xorm:"NOT NULL"`
|
|
CreatedUnix timeutil.TimeStamp `xorm:"created NOT NULL"`
|
|
UpdatedUnix timeutil.TimeStamp `xorm:"updated NOT NULL"`
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(IssueWatch))
|
|
}
|
|
|
|
// IssueWatchList contains IssueWatch
|
|
type IssueWatchList []*IssueWatch
|
|
|
|
// CreateOrUpdateIssueWatch set watching for a user and issue
|
|
func CreateOrUpdateIssueWatch(userID, issueID int64, isWatching bool) error {
|
|
iw, exists, err := getIssueWatch(db.GetEngine(db.DefaultContext), userID, issueID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if !exists {
|
|
iw = &IssueWatch{
|
|
UserID: userID,
|
|
IssueID: issueID,
|
|
IsWatching: isWatching,
|
|
}
|
|
|
|
if _, err := db.GetEngine(db.DefaultContext).Insert(iw); err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
iw.IsWatching = isWatching
|
|
|
|
if _, err := db.GetEngine(db.DefaultContext).ID(iw.ID).Cols("is_watching", "updated_unix").Update(iw); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetIssueWatch returns all IssueWatch objects from db by user and issue
|
|
// the current Web-UI need iw object for watchers AND explicit non-watchers
|
|
func GetIssueWatch(userID, issueID int64) (iw *IssueWatch, exists bool, err error) {
|
|
return getIssueWatch(db.GetEngine(db.DefaultContext), userID, issueID)
|
|
}
|
|
|
|
// Return watcher AND explicit non-watcher if entry in db exist
|
|
func getIssueWatch(e db.Engine, userID, issueID int64) (iw *IssueWatch, exists bool, err error) {
|
|
iw = new(IssueWatch)
|
|
exists, err = e.
|
|
Where("user_id = ?", userID).
|
|
And("issue_id = ?", issueID).
|
|
Get(iw)
|
|
return
|
|
}
|
|
|
|
// CheckIssueWatch check if an user is watching an issue
|
|
// it takes participants and repo watch into account
|
|
func CheckIssueWatch(user *user_model.User, issue *Issue) (bool, error) {
|
|
iw, exist, err := getIssueWatch(db.GetEngine(db.DefaultContext), user.ID, issue.ID)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
if exist {
|
|
return iw.IsWatching, nil
|
|
}
|
|
w, err := repo_model.GetWatch(db.DefaultContext, user.ID, issue.RepoID)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return repo_model.IsWatchMode(w.Mode) || IsUserParticipantsOfIssue(user, issue), nil
|
|
}
|
|
|
|
// GetIssueWatchersIDs returns IDs of subscribers or explicit unsubscribers to a given issue id
|
|
// but avoids joining with `user` for performance reasons
|
|
// User permissions must be verified elsewhere if required
|
|
func GetIssueWatchersIDs(issueID int64, watching bool) ([]int64, error) {
|
|
return getIssueWatchersIDs(db.GetEngine(db.DefaultContext), issueID, watching)
|
|
}
|
|
|
|
func getIssueWatchersIDs(e db.Engine, issueID int64, watching bool) ([]int64, error) {
|
|
ids := make([]int64, 0, 64)
|
|
return ids, e.Table("issue_watch").
|
|
Where("issue_id=?", issueID).
|
|
And("is_watching = ?", watching).
|
|
Select("user_id").
|
|
Find(&ids)
|
|
}
|
|
|
|
// GetIssueWatchers returns watchers/unwatchers of a given issue
|
|
func GetIssueWatchers(issueID int64, listOptions db.ListOptions) (IssueWatchList, error) {
|
|
return getIssueWatchers(db.GetEngine(db.DefaultContext), issueID, listOptions)
|
|
}
|
|
|
|
func getIssueWatchers(e db.Engine, issueID int64, listOptions db.ListOptions) (IssueWatchList, error) {
|
|
sess := e.
|
|
Where("`issue_watch`.issue_id = ?", issueID).
|
|
And("`issue_watch`.is_watching = ?", true).
|
|
And("`user`.is_active = ?", true).
|
|
And("`user`.prohibit_login = ?", false).
|
|
Join("INNER", "`user`", "`user`.id = `issue_watch`.user_id")
|
|
|
|
if listOptions.Page != 0 {
|
|
sess = db.SetSessionPagination(sess, &listOptions)
|
|
watches := make([]*IssueWatch, 0, listOptions.PageSize)
|
|
return watches, sess.Find(&watches)
|
|
}
|
|
watches := make([]*IssueWatch, 0, 8)
|
|
return watches, sess.Find(&watches)
|
|
}
|
|
|
|
// CountIssueWatchers count watchers/unwatchers of a given issue
|
|
func CountIssueWatchers(issueID int64) (int64, error) {
|
|
return countIssueWatchers(db.GetEngine(db.DefaultContext), issueID)
|
|
}
|
|
|
|
func countIssueWatchers(e db.Engine, issueID int64) (int64, error) {
|
|
return e.
|
|
Where("`issue_watch`.issue_id = ?", issueID).
|
|
And("`issue_watch`.is_watching = ?", true).
|
|
And("`user`.is_active = ?", true).
|
|
And("`user`.prohibit_login = ?", false).
|
|
Join("INNER", "`user`", "`user`.id = `issue_watch`.user_id").Count(new(IssueWatch))
|
|
}
|
|
|
|
func removeIssueWatchersByRepoID(e db.Engine, userID, repoID int64) error {
|
|
_, err := e.
|
|
Join("INNER", "issue", "`issue`.id = `issue_watch`.issue_id AND `issue`.repo_id = ?", repoID).
|
|
Where("`issue_watch`.user_id = ?", userID).
|
|
Delete(new(IssueWatch))
|
|
return err
|
|
}
|