mirrors
/
mermaid
mirror of https://github.com/mermaid-js/mermaid.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove `setConfig` and `resetConfig` in pie

This commit is contained in:
Reda Al Sulais 2023-08-12 21:18:07 +03:00
parent cb5f70c139
commit 3f3a7340e3
4 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/mermaid/src/diagram-api/types.ts
View File

@ -17,8 +17,6 @@ export interface InjectUtils {
*/ */
export interface DiagramDB { export interface DiagramDB {
// config // config
resetConfig?: () => void;
setConfig?: (config: BaseDiagramConfig) => void;
getConfig?: () => BaseDiagramConfig | undefined; getConfig?: () => BaseDiagramConfig | undefined;
// db // db

10
packages/mermaid/src/diagrams/pie/pie.spec.ts
View File

@ -159,8 +159,8 @@ describe('pie chart', () => {
}); });
describe('config', () => { describe('config', () => {
it('setConfig', () => { it.todo('setConfig', () => {
db.setConfig({ useWidth: 850, useMaxWidth: undefined }); // db.setConfig({ useWidth: 850, useMaxWidth: undefined });
const config = db.getConfig(); const config = db.getConfig();
expect(config.useWidth).toBe(850); expect(config.useWidth).toBe(850);
@ -171,9 +171,9 @@ describe('pie chart', () => {
expect(db.getConfig()).toStrictEqual(DEFAULT_PIE_DB.config); expect(db.getConfig()).toStrictEqual(DEFAULT_PIE_DB.config);
}); });
it('reset', () => { it.todo('resetConfig', () => {
db.setConfig({ textPosition: 0 }); // db.setConfig({ textPosition: 0 });
db.resetConfig(); // db.resetConfig();
expect(db.getConfig().textPosition).toStrictEqual(DEFAULT_PIE_DB.config.textPosition); expect(db.getConfig().textPosition).toStrictEqual(DEFAULT_PIE_DB.config.textPosition);
}); });
}); });

14
packages/mermaid/src/diagrams/pie/pieDb.ts
View File

@ -15,7 +15,6 @@ import type { ParseDirectiveDefinition } from '../../diagram-api/types.js';
import type { PieFields, PieDB, Sections } from './pieTypes.js'; import type { PieFields, PieDB, Sections } from './pieTypes.js';
import type { RequiredDeep } from 'type-fest'; import type { RequiredDeep } from 'type-fest';
import type { PieDiagramConfig } from '../../config.type.js'; import type { PieDiagramConfig } from '../../config.type.js';
import { cleanAndMerge } from '../../utils.js';
export const DEFAULT_PIE_CONFIG: Required<PieDiagramConfig> = { export const DEFAULT_PIE_CONFIG: Required<PieDiagramConfig> = {
useMaxWidth: true, useMaxWidth: true,
@ -31,18 +30,10 @@ export const DEFAULT_PIE_DB: RequiredDeep<PieFields> = {
let sections: Sections = DEFAULT_PIE_DB.sections; let sections: Sections = DEFAULT_PIE_DB.sections;
let showData: boolean = DEFAULT_PIE_DB.showData; let showData: boolean = DEFAULT_PIE_DB.showData;
let config: Required<PieDiagramConfig> = structuredClone(DEFAULT_PIE_CONFIG); const config: Required<PieDiagramConfig> = structuredClone(DEFAULT_PIE_CONFIG);
const setConfig = (conf: PieDiagramConfig): void => {
config = cleanAndMerge(DEFAULT_PIE_CONFIG, conf);
};
const getConfig = (): Required<PieDiagramConfig> => structuredClone(config); const getConfig = (): Required<PieDiagramConfig> => structuredClone(config);
const resetConfig = (): void => {
config = structuredClone(DEFAULT_PIE_CONFIG);
};
const parseDirective: ParseDirectiveDefinition = (statement, context, type) => { const parseDirective: ParseDirectiveDefinition = (statement, context, type) => {
_parseDirective(this, statement, context, type); _parseDirective(this, statement, context, type);
}; };
@ -51,7 +42,6 @@ const clear = (): void => {
sections = structuredClone(DEFAULT_PIE_DB.sections); sections = structuredClone(DEFAULT_PIE_DB.sections);
showData = DEFAULT_PIE_DB.showData; showData = DEFAULT_PIE_DB.showData;
commonClear(); commonClear();
resetConfig();
}; };
const addSection = (label: string, value: number): void => { const addSection = (label: string, value: number): void => {
@ -78,9 +68,7 @@ const setShowData = (toggle: boolean): void => {
const getShowData = (): boolean => showData; const getShowData = (): boolean => showData;
export const db: PieDB = { export const db: PieDB = {
setConfig,
getConfig, getConfig,
resetConfig,
parseDirective, parseDirective,
clear, clear,

2
packages/mermaid/src/diagrams/pie/pieTypes.ts
View File

@ -43,8 +43,6 @@ export interface D3Sections {
export interface PieDB extends DiagramDB { export interface PieDB extends DiagramDB {
// config // config
resetConfig: () => void;
setConfig: (config: PieDiagramConfig) => void;
getConfig: () => Required<PieDiagramConfig>; getConfig: () => Required<PieDiagramConfig>;
// common db // common db