mirrors
/
mermaid
mirror of https://github.com/mermaid-js/mermaid.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Address review comments

This commit is contained in:
Sidharth Vinod 2023-12-07 11:27:48 +05:30
parent 65a08efa00
commit 867686fe34
No known key found for this signature in database
GPG Key ID: FB5CCD378D3907CD
1 changed files with 18 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
packages/mermaid/src/diagrams/flowchart/flowDb.ts
View File

@ -56,7 +56,7 @@ export const lookUpDomId = function (id: string) {
*
*/
export const addVertex = function (
_id: string,
id: string,
textObj: FlowText,
type: 'group',
style: string[],
@ -64,18 +64,14 @@ export const addVertex = function (
dir: string,
props = {}
) {
if (!id || id.trim().length === 0) {
return;
}
let txt;
const id = _id;
if (id === undefined) {
return;
}
if (id.trim().length === 0) {
return;
}
if (vertices[id] === undefined) {
vertices[id] = {
id: id,
id,
labelType: 'text',
domId: MERMAID_DOM_ID_PREFIX + id + '-' + vertexCounter,
styles: [],
@ -95,7 +91,7 @@ export const addVertex = function (
vertices[id].text = txt;
} else {
if (vertices[id].text === undefined) {
vertices[id].text = _id;
vertices[id].text = id;
}
}
if (type !== undefined) {
@ -255,24 +251,24 @@ export const setDirection = function (dir: string) {
* @param className - Class to add
*/
export const setClass = function (ids: string, className: string) {
ids.split(',').forEach(function (_id) {
const id = _id;
if (vertices[id] !== undefined) {
for (const id of ids.split(',')) {
if (vertices[id]) {
vertices[id].classes.push(className);
}
if (subGraphLookup[id] !== undefined) {
if (subGraphLookup[id]) {
subGraphLookup[id].classes.push(className);
}
});
}
};
const setTooltip = function (ids: string, tooltip: string) {
ids.split(',').forEach(function (id) {
if (tooltip !== undefined) {
tooltips[version === 'gen-1' ? lookUpDomId(id) : id] = sanitizeText(tooltip);
}
});
if (!tooltip) {
return;
}
tooltip = sanitizeText(tooltip);
for (const id of ids.split(',')) {
tooltips[version === 'gen-1' ? lookUpDomId(id) : id] = tooltip;
}
};
const setClickFun = function (id: string, functionName: string, functionArgs: string) {
@ -491,10 +487,7 @@ export const addSubGraph = function (
return { nodeList, dir };
}
let nodeList: string[] = [];
const { nodeList: nl, dir } = uniq(list.flat());
nodeList = nl;
const { nodeList, dir } = uniq(list.flat());
if (version === 'gen-1') {
for (let i = 0; i < nodeList.length; i++) {
nodeList[i] = lookUpDomId(nodeList[i]);