mirrors
/
mermaid
mirror of https://github.com/mermaid-js/mermaid.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

added styles values validation + unit tests

This commit is contained in:
ilyes-ced 2024-02-07 00:57:05 +00:00
parent 17959f648a
commit c1cb171071
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
packages/mermaid/src/diagrams/quadrant-chart/quadrantDb.spec.ts
View File

@ -25,4 +25,26 @@ describe('quadrant unit tests', () => {
const result = quadrantDb.parseStyles(styles);
expect(result).toEqual({});
});
it('should throw an error for unacceptable style value', () => {
let styles: string[] = ['radius: f'];
expect(() => quadrantDb.parseStyles(styles)).toThrowError(
'value for radius f is unvalid, requires a number'
);
styles = ['color: ffaa'];
expect(() => quadrantDb.parseStyles(styles)).toThrowError(
'value for color ffaa is unvalid, requires a valid hex code'
);
styles = ['stroke-color: #f677779'];
expect(() => quadrantDb.parseStyles(styles)).toThrowError(
'value for stroke-color #f677779 is unvalid, requires a valid hex code'
);
styles = ['stroke-width: 30'];
expect(() => quadrantDb.parseStyles(styles)).toThrowError(
'value for stroke-width 30 is unvalid, requires a valid number of pixels (eg. 10px)'
);
});
});

16
packages/mermaid/src/diagrams/quadrant-chart/quadrantDb.ts
View File

@ -60,12 +60,28 @@ function parseStyles(styles: string[]): StylesObject {
for (const item of styles) {
const style = item.trim().split(/\s*:\s*/);
if (style[0] == 'radius') {
if (!/^\d+$/.test(style[1])) {
throw new Error(`value for radius ${style[1]} is unvalid, requires a number`);
}
stylesObject.radius = parseInt(style[1]);
} else if (style[0] == 'color') {
if (!/^#?([\dA-Fa-f]{6}|[\dA-Fa-f]{3})$/.test(style[1])) {
throw new Error(`value for color ${style[1]} is unvalid, requires a valid hex code`);
}
stylesObject.color = style[1];
} else if (style[0] == 'stroke-color') {
if (!/^#?([\dA-Fa-f]{6}|[\dA-Fa-f]{3})$/.test(style[1])) {
throw new Error(
`value for stroke-color ${style[1]} is unvalid, requires a valid hex code`
);
}
stylesObject.strokeColor = style[1];
} else if (style[0] == 'stroke-width') {
if (!/^\d+px$/.test(style[1])) {
throw new Error(
`value for stroke-width ${style[1]} is unvalid, requires a valid number of pixels (eg. 10px)`
);
}
stylesObject.strokeWidth = style[1];
} else {
throw new Error(`stlye named ${style[0]} is unacceptable`);