mirrors
/
munin-contrib
mirror of https://github.com/munin-monitoring/contrib.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Plugin xfs_frag: fix shellcheck issues

This commit is contained in:
Lars Kruse 2020-03-26 02:57:40 +01:00
parent 07c854f276
commit cdb9a4456f
2 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
plugins/disk/xfs_frag
View File

@ -32,7 +32,7 @@ Paul Saunders L<darac+munin@darac.org.uk>
=cut
declare -a ARRY
declare -a TOKENS
shopt -s nocasematch
case $1 in
@ -42,12 +42,12 @@ graph_title XFS fragmentation
graph_vlabel Percent
graph_category disk
EOF
cat /etc/mtab | awk '{print $2 " " $3}' | while read LINE
do
ARRY=($LINE)
if [[ ${ARRY[1]} =~ xfs ]]; then
FIELDNAME=$(echo ${ARRY[0]} | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
echo "$FIELDNAME.label ${ARRY[0]}"
awk '{print $2 " " $3}' </etc/mtab | while read -r LINE; do
# shellcheck disable=SC2206
TOKENS=($LINE)
if [[ ${TOKENS[1]} =~ xfs ]]; then
FIELDNAME=$(echo "${TOKENS[0]}" | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
echo "$FIELDNAME.label ${TOKENS[0]}"
echo "$FIELDNAME.type GAUGE"
fi
done
@ -55,13 +55,12 @@ EOF
;;
esac
cat /etc/mtab | awk '{print $2 " " $3 " " $1}' | while read LINE
do
ARRY=($LINE)
if [[ ${ARRY[1]} =~ xfs ]]; then
FIELDNAME=$(echo ${ARRY[0]} | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
FRAG=$(xfs_db -c frag -r ${ARRY[2]} | sed 's/.*fragmentation factor \(.*\)%.*/\1/')
echo $FIELDNAME.value $FRAG
awk '{print $2 " " $3 " " $1}' </etc/mtab | while read -r LINE; do
# shellcheck disable=SC2206
TOKENS=($LINE)
if [[ ${TOKENS[1]} =~ xfs ]]; then
FIELDNAME=$(echo "${TOKENS[0]}" | sed 's/^[^A-Za-z_]/_/; s/[^A-Za-z0-9_]/_/g')
FRAG=$(xfs_db -c frag -r "${TOKENS[2]}" | sed 's/.*fragmentation factor \(.*\)%.*/\1/')
echo "$FIELDNAME.value $FRAG"
fi
done

1
t/test-exception-wrapper.expected-failures
View File

@ -85,7 +85,6 @@ plugins/disk/raid-mismatch-count
plugins/disk/scsi_queue
plugins/disk/snmp__areca_
plugins/disk/useddisk
plugins/disk/xfs_frag
plugins/dkim/dkimproxy_mails
plugins/dovecot/dovecot
plugins/dovecot/dovecot_stats_