Commit Graph

4973 Commits

Author SHA1 Message Date
Lars Kruse 3934b4d0bd
Merge pull request #1235 from kmkr/master
Improve code readability and consistency
2021-08-19 00:39:49 +02:00
Kris-Mikael Krister b6cd969be0
Add example graphs for the deluge plugin 2021-08-17 20:59:18 +02:00
Kris-Mikael Krister edf886e0f8
Reformat deluge_ with black and flake8 2021-08-17 20:55:02 +02:00
shakemid 8f18f1f8bb Add swichbotmeter plugin 2021-08-17 22:48:18 +09:00
Kris-Mikael Krister 99c788031d
Improve code readability and consistency
This commit:

- Changes to Python 3 template string rather than the formatted string
  syntax.
- Calls the Deluge API once per plugin run for the "states" mode, rather
  than once per torrent. Lines of code are reduced. The readability is
  improved too, since the API call is similar to how the "peers" mode
  works.
- Updates the label for the "state" entry "paused" to match it's name in the
  libtorrent API: "stopped". "Queued" is split into "Queued seeding" and
  "Queued downloads" to match the libtorrent API too.
2021-08-11 14:41:27 +02:00
Lars Kruse 398a3ab289 Plugin pacman_pending_updates: switch to simple shell
The plugin did not use any bash-specific features.
2021-08-08 15:55:41 +02:00
Lars Kruse c2aa56531c Plugin pacman_pending_updates: handle absence of available updates properly
"checkupdates" returns the exit code 2, if no updates are pending.
Previously the plugin did not output anything in this case.

Closes: #1233
2021-08-08 15:55:41 +02:00
Kris-Mikael Krister 13b9078f76 Update the Deluge plugin to handle Deluge 2.x
Version 1.0.0 of this plugin requires version 1 of Deluge. Deluge 2 was
released in June 2019.

This commits bumps the plugin to version 2.0.0.

This plugin has three modes. The modes "bandwidth" and "states" are
working equally to the previous version.  The third mode, "connections",
is changed.

The connections mode previously printed one value: the total number of
connections.  That RPC call is removed in Deluge 2, and I'm instead
using `get_session_status`, which delegates the call to libtorrent [1].
libtorrent is much better documented, so it's easier to work with
compared to Deluge.

"Number of peers" replaces the previous "number of connections", and
I've added half open peers, and peers interested in download and upload
slots to the same graph.

[1]. https://libtorrent.org/manual-ref.html#session-statistics
2021-08-08 15:27:36 +02:00
Lars Kruse 0ab2cff07c
Merge pull request #1058 from jtsage/add-template-munstrap4
Add "munstrap4" template.
2021-08-08 15:10:53 +02:00
Lars Kruse 49b4197670 Plugin rtom_allsessions_vol: remove unused fields
These fields were never used.

Thanks, Matt Merhar!
2021-08-08 15:08:18 +02:00
Matt Merhar 9c8415ef7e rtom_vol: remove unused config parameters
Since there are no associated values for 'hashing', 'seeding', and
'active', a warning is seen in munin-update.log every time this plugin
is fetched.
2021-08-08 15:07:06 +02:00
Christian Neumann d6ed84a784 nvidia_gpu: fix units of Rx/Tx throughput (multiple gpus) 2021-07-27 23:59:42 +02:00
Andreas Perhab 323f69fd86 bind9_*_stats: fix using env variable stat_file
previously only stat_file would only be used for data cleanup not for
fetching the data. also fixed some shellcheck warnings.
2021-07-25 06:06:46 +02:00
kaihen 07e747a1e8 Fix for docker_containers 2021-07-22 13:58:03 +02:00
Lars Kruse 07220eebae
Merge pull request #1221 from shtrom/snmp__if_combined-stacked
Snmp  if combined stacked
2021-07-20 16:26:08 +02:00
Olivier Mehani ecb1d34814 [snmp__if_combined] Reindent 2021-07-20 11:08:49 +10:00
Olivier Mehani 6ac458ace1 [snmp__if_combined] Add support for stacked series in root graph
From a summary comment in the code:

    If a stacked graph is requested, plot the total. Rather than
    aggregating them with CDEFs of SUMs, we sum them in the script, which
    allows us to create real series than can be easily borrowed by other
    loaning graphs.

Those series are recv_bits and send_bits.

There are longstanding bugs with them (dating back to snmp__if). This
has been documented, as well as some potential ad hoc fixes for the
data.

Some outdated bug were also removed from the doc.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 11:08:49 +10:00
Olivier Mehani 61473dfdb0 [snmp__if_combined] fix error value
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani 57965df514 [snmp__if_combined] Fix issue with extrainfo
It was not collected / shown in the right spot, resulting in incorrect
information being shown.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani 6bb4a57983 [snmp__if_combined] Fix All interfaces titles so they are better grouped in category views
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani 2f2ed4e41a [snmp__if_combined] use snmp v2 description for root traffic graph
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:10 +10:00
Olivier Mehani e3c5515532 [internode_usage] loan from other graphs in root
Also, don't use mathlib with `bc`, as it's not needed, and only adds
spurious fractional bytes to the computed ideal usage.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-19 13:26:35 +02:00
Olivier Mehani e612fbbd46 [wunderground_] loan from other graphs in root
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-19 13:26:35 +02:00
Olivier Mehani f018bada38 [upnpc_] loan from other graphs in root
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-19 13:26:35 +02:00
Lars Kruse c3a1679d2d
Merge pull request #1206 from kimheino/amavis-guap
amavis_multi: multigraph plugin to monitor amavis mail filter
2021-07-17 05:29:54 +02:00
Lars Kruse e8afee7d3a
Merge pull request #1159 from cortices/master
openstack_swift_stats_: Add openstack_swift_stats_ plugin
2021-07-17 05:29:13 +02:00
s0 181f3ed970 Fix pod doc in header of file 2021-07-16 19:03:47 +10:00
Kim B. Heino 30328b3546 amavis_multi: fix spelling, it's "processes", not "childs" or "children" 2021-07-16 11:37:31 +03:00
Lars Kruse 839a29e942
Merge pull request #1217 from Wicloz/patch-1 (improve debian/debsecan_ plugin)
Add suggest capabilities to the debian/debsecan_ plugin.
2021-07-15 23:18:43 +02:00
s0 e70f572eeb Fix copy-paste bug where objects graph was never updated. 2021-07-15 19:55:24 +10:00
s0 4ed6c56f28 Refactor script to pure POSIX sh compliance.
Also includes recommended fixes
2021-07-15 17:52:56 +10:00
Wilco de Boer 5c048c989f Actually, echo suite even when sourcing `os-release` fails 2021-07-15 00:18:55 +02:00
Wilco de Boer d8dba4936e Source the `os-release` file in a subshell 2021-07-15 00:11:59 +02:00
Wilco de Boer a2556d0528 Make indenting consistent across the rest of the file 2021-07-14 23:54:37 +02:00
Wilco de Boer 31149eb05d Properly indent heredocs 2021-07-14 23:48:41 +02:00
Wilco de Boer e2b04d0b46 Cleanup all the `printf`s 2021-07-14 23:41:54 +02:00
Lars Kruse e641c80284 mysql_size_all: use clean fieldnames for databsaes with invalid characters
Thanks, Lokutos!

See: #1032
2021-07-14 22:57:40 +02:00
Lars Kruse 704a88ecda w1_multi: process multiple sensors (based on "w1_")
All temperatures are displayed in a single graph.
This should provide more convenience than the "w1_" plugin (being a
"suggest"-based wildcard plugin).

Additionally the label of each sensor can be overridden.
2021-07-14 22:40:13 +02:00
Kim B. Heino 085d7a9ba8 chrony_status: perlpod and small fixes 2021-07-14 22:30:51 +02:00
Kim B. Heino ebac55597d chrony: add multigraph plugin to monitor chrony's delay, freq time and stratum 2021-07-14 22:30:51 +02:00
Kim B. Heino 9f1f96f656 raid2: fix "raid -> raid2" in perlpod 2021-07-14 22:30:32 +02:00
Kim B. Heino 558360c412 raid2: use perlpod and small fixes 2021-07-14 22:30:32 +02:00
Kim B. Heino d3bcc2f9bf raid2: yet another raid+scrub monitoring plugin
Supports:
- mdstat
- btrfs
- cciss
- megasasctl
2021-07-14 22:30:32 +02:00
Kim B. Heino a92c9a9b67 varnish: rename, use perlpod and minor changes 2021-07-14 22:29:41 +02:00
Kim B. Heino b2a11780b3 varnish4_multigraph: multigraph version of varnish4_, rewritten in python 2021-07-14 22:29:41 +02:00
Kim B. Heino 7e48a2c8b5 hue: use perlpod and other small changes 2021-07-14 22:29:07 +02:00
Kim B. Heino 4f22cec97c hue: plugin to monitor Philips Hue light status and temperature sensors 2021-07-14 22:29:07 +02:00
Lars Kruse c633ff00ea docker_: ignore contains which are not running
Some containers may be in "restarting" state.  We should ignore these.

Thanks, ogmueller!

Closes: #1209
2021-07-14 22:20:51 +02:00
Lars Kruse a3ae1af155 docker_: use "exclude" filter for all graphs 2021-07-14 22:17:26 +02:00
Oliver 64d5d8af08 Added check to ensure network stats for container exist before reading them 2021-07-14 22:11:45 +02:00