From 26188e6d8a5c0eff129fe36a9548c67abbeea466 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Wed, 29 Apr 2020 12:29:34 +0200 Subject: [PATCH] Enable a couple of linters --- .golangci.yml | 8 +++++++- engine/list_generator.go | 1 - server/subsonic/api.go | 1 - 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index e99c18cd..6486669a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,8 +1,14 @@ linters: enable: + - bodyclose - goimports - - unconvert + - goprintffuncname - gosec + - interfacer + - misspell + - rowserrcheck + - unconvert + - whitespace issues: exclude-rules: diff --git a/engine/list_generator.go b/engine/list_generator.go index fa300e86..646fb8fe 100644 --- a/engine/list_generator.go +++ b/engine/list_generator.go @@ -181,7 +181,6 @@ func (g *listGenerator) GetNowPlaying(ctx context.Context) (Entries, error) { entries[i].MinutesAgo = int(time.Since(np.Start).Minutes()) entries[i].PlayerId = np.PlayerId entries[i].PlayerName = np.PlayerName - } return entries, nil } diff --git a/server/subsonic/api.go b/server/subsonic/api.go index 7b36622a..8ddefd93 100644 --- a/server/subsonic/api.go +++ b/server/subsonic/api.go @@ -38,7 +38,6 @@ type Router struct { func New(browser engine.Browser, cover engine.Cover, listGenerator engine.ListGenerator, users engine.Users, playlists engine.Playlists, ratings engine.Ratings, scrobbler engine.Scrobbler, search engine.Search, streamer engine.MediaStreamer, players engine.Players) *Router { - r := &Router{Browser: browser, Cover: cover, ListGenerator: listGenerator, Playlists: playlists, Ratings: ratings, Scrobbler: scrobbler, Search: search, Users: users, Streamer: streamer, Players: players} r.mux = r.routes()