From 769e8bedbadce9b8b92a059881246d4d83906e9f Mon Sep 17 00:00:00 2001 From: Deluan Date: Fri, 13 Jan 2023 19:43:27 -0500 Subject: [PATCH] Rename WeightedChooser's method Put to Add, a better name --- core/external_metadata.go | 2 +- utils/weighted_random_chooser.go | 2 +- utils/weighted_random_chooser_test.go | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/external_metadata.go b/core/external_metadata.go index 8c8db7d1..37825166 100644 --- a/core/external_metadata.go +++ b/core/external_metadata.go @@ -182,7 +182,7 @@ func (e *externalMetadata) SimilarSongs(ctx context.Context, id string, count in weight := topCount * (4 + artistWeight) for _, mf := range topSongs { - weightedSongs.Put(mf, weight) + weightedSongs.Add(mf, weight) weight -= 4 } return nil diff --git a/utils/weighted_random_chooser.go b/utils/weighted_random_chooser.go index 7f82d0fb..e7e26cd8 100644 --- a/utils/weighted_random_chooser.go +++ b/utils/weighted_random_chooser.go @@ -16,7 +16,7 @@ func NewWeightedRandomChooser() *WeightedChooser { return &WeightedChooser{} } -func (w *WeightedChooser) Put(value interface{}, weight int) { +func (w *WeightedChooser) Add(value interface{}, weight int) { w.entries = append(w.entries, value) w.weights = append(w.weights, weight) w.totalWeight += weight diff --git a/utils/weighted_random_chooser_test.go b/utils/weighted_random_chooser_test.go index 5dae561c..48c20ffa 100644 --- a/utils/weighted_random_chooser_test.go +++ b/utils/weighted_random_chooser_test.go @@ -10,7 +10,7 @@ var _ = Describe("WeightedRandomChooser", func() { BeforeEach(func() { w = NewWeightedRandomChooser() for i := 0; i < 10; i++ { - w.Put(i, i) + w.Add(i, i) } }) @@ -23,14 +23,14 @@ var _ = Describe("WeightedRandomChooser", func() { It("returns the sole item", func() { w = NewWeightedRandomChooser() - w.Put("a", 1) + w.Add("a", 1) Expect(w.GetAndRemove()).To(Equal("a")) }) It("fails when trying to choose from empty set", func() { w = NewWeightedRandomChooser() - w.Put("a", 1) - w.Put("b", 1) + w.Add("a", 1) + w.Add("b", 1) Expect(w.GetAndRemove()).To(BeElementOf("a", "b")) Expect(w.GetAndRemove()).To(BeElementOf("a", "b")) _, err := w.GetAndRemove()