8dc2502177
* Add PR checklist document. * Update docs/pr_checklist.md Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan <fauxpark@gmail.com> * Reword the lower/raise/adjust suggestion somewhat for clarity. * Add suggestion from @Didel for coding conventions. Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com>
35 lines
1.5 KiB
Markdown
35 lines
1.5 KiB
Markdown
<!--- Provide a general summary of your changes in the title above. -->
|
|
|
|
<!--- This template is entirely optional and can be removed, but is here to help both you and us. -->
|
|
<!--- Anything on lines wrapped in comments like these will not show up in the final text. -->
|
|
|
|
## Description
|
|
|
|
<!--- Describe your changes in detail here. -->
|
|
|
|
## Types of Changes
|
|
|
|
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply. -->
|
|
- [ ] Core
|
|
- [ ] Bugfix
|
|
- [ ] New feature
|
|
- [ ] Enhancement/optimization
|
|
- [ ] Keyboard (addition or update)
|
|
- [ ] Keymap/layout/userspace (addition or update)
|
|
- [ ] Documentation
|
|
|
|
## Issues Fixed or Closed by This PR
|
|
|
|
*
|
|
|
|
## Checklist
|
|
|
|
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
|
|
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
|
|
- [ ] My code follows the code style of this project: [**C**](https://docs.qmk.fm/#/coding_conventions_c), [**Python**](https://docs.qmk.fm/#/coding_conventions_python)
|
|
- [ ] I have read the [**PR Checklist** document](https://docs.qmk.fm/#/pr_checklist) and have made the appropriate changes.
|
|
- [ ] My change requires a change to the documentation.
|
|
- [ ] I have updated the documentation accordingly.
|
|
- [ ] I have read the [**CONTRIBUTING** document](https://docs.qmk.fm/#/contributing).
|
|
- [ ] I have added tests to cover my changes.
|
|
- [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
|