Commit Graph

16997 Commits

Author SHA1 Message Date
Michael Steenbeek 073e4b0ccc
Fix #7690: Problem with guests freezing on certain tiles of path (#9723) 2019-08-04 17:19:40 +02:00
Ted John c3234b1442 Refactor map animations and dynamically create on park load (#9705) 2019-08-03 22:18:33 +02:00
Ted John 1a6e5b5548 Fix #9680: invalid-read in ride_entry_get_supported_track_pieces (#9681) 2019-08-03 19:55:24 +02:00
Ted John a8f4db7b4b Fix #9717: Scroll bars do not render correctly when using OpenGL renderer 2019-08-03 11:02:44 +01:00
Ted John b7121553b4 Fix #9715: large scenery banners have incorrect colour and scrolling (#9716) 2019-08-02 21:18:42 +02:00
Ted John fcc41b4647 Fix #9701: GetRideEntry nullptr can cause stack overflow (#9702)
GetName calls GetRideEntry so we can't log the name of the ride. I don't think the log is necessary as we now assume rides can have a null ride entry and all callers should check for this.
2019-08-01 23:42:39 +02:00
Ted John e4ba170c87 Fix #9699: Crash when error message is shown for custom named ride
Increase size of error string format argument buffer so that the ride name arguments fit.
2019-08-01 17:22:28 +01:00
Ted John a5365b38b3 Fix #9502: Unhandled exception when object download fails (#9696) 2019-08-01 14:51:52 +02:00
Jim Armstrong 6458514361 Fix #9491: Access violation in window_ride_init_viewport 2019-08-01 11:11:59 +02:00
Michael Steenbeek 9236f5f10b
Merge pull request #9697 from jgottula/refactor/9676
Refactor #9676: Ride Ratings Refactoring
2019-08-01 11:03:05 +02:00
Michael Steenbeek c1fa86a843
Merge pull request #9623 from IntelOrca/refactor/remove-user-strings
Remove user string pool
2019-08-01 11:00:21 +02:00
Justin Gottula a28c5f947d Refactor #9676: Replace local var BP offset names with meaningful ones 2019-07-31 15:23:42 -07:00
Justin Gottula a9469b27cc Refactor #9676: Replace local var register names with meaningful ones 2019-07-31 15:23:38 -07:00
Justin Gottula f9c1b65356 Refactor #9676: Apply appropriate style casing to existing variables 2019-07-31 15:14:27 -07:00
Justin Gottula 594a220da2 Refactor #9676: Use std::clamp in place of std::min/std::max pair 2019-07-31 14:50:17 -07:00
Justin Gottula ae87f5037a Refactor #9676: Use compound assignment operators for trivial cases 2019-07-31 14:42:04 -07:00
Ted John 26db91f023 Fix ride list, status 2019-07-31 19:50:06 +01:00
Michael Steenbeek c24c15bfa7 Fix xcode project 2019-07-30 22:52:47 +01:00
Ted John b3531624a1 Fix saving of banner frame colour 2019-07-30 18:27:50 +01:00
Ted John 1f9f48e054 Fix flickering banners 2019-07-29 21:41:21 +01:00
Ted John af5daaec70 Fix importing and exporting of banner strings containing colour 2019-07-29 21:20:22 +01:00
Ted John 7287b8cf1a Fix formatting 2019-07-29 20:40:25 +01:00
Ted John 85e63cbe3b Do not include name in peep checksum 2019-07-29 20:21:02 +01:00
Ted John f539fdd79c Convert user strings to RCT2 encoding when exporting to S6 2019-07-29 20:01:49 +01:00
Ted John 7ce2f38c92 Fix formatting 2019-07-29 20:01:49 +01:00
Ted John 5af3bbf971 Fix compile errors 2019-07-29 20:01:49 +01:00
Ted John d28799ef18 Remove user strings 2019-07-29 20:01:37 +01:00
Duncan 77f1905271
Fix #8136. Fix incorrect calculation of excessive lateral G penalty. (#9667)
* Fix #8136. Fix incorrect calculation of excessive lateral G penalty.

This penalty had been modified for OpenRCT2 moving it from before certain other penalties were applied to after. The move accidently removed the ride type multiplier which caused a very large penalty to be applied. In addition the excitement penalty applied to the whole calculation instead of just the gforce bonus. This caused an excessive penalty to the excitement.

* Add changelog entry. Fix default initilisation.

* Increment network version
2019-07-29 19:35:04 +01:00
Ted John 767b3c8328 Build up the user string list and export in one go 2019-07-29 19:18:16 +01:00
Ted John 40d49b93d3 Do not use user strings for peep names 2019-07-29 19:18:16 +01:00
Ted John 61d64ab8c5 Do not use user strings for banners 2019-07-29 19:18:16 +01:00
Ted John 300ce9727e Protect against nullptr 2019-07-29 19:18:16 +01:00
Ted John 749b07e83f Use local variable for format arguments 2019-07-29 19:18:16 +01:00
Ted John 772475848b Fix formatting 2019-07-29 19:18:16 +01:00
Ted John eb4c9acb08 Fix compile errors and ride entry null edge case 2019-07-29 19:18:16 +01:00
Ted John 1d4c1958dd Do not allow duplicate ride names 2019-07-29 19:18:16 +01:00
Ted John f8b08b334e Fix a few more bugs 2019-07-29 19:18:16 +01:00
Ted John 3f8890afde Fix remaining errors and a few bugs 2019-07-29 19:18:16 +01:00
Ted John 3f45976009 Fix openrct2ui errors 2019-07-29 19:18:16 +01:00
Ted John 3155c661fa Refactor format peep action 2019-07-29 19:18:16 +01:00
Ted John 6fff2079f9 Refactor ride name to dynamic args and std::string 2019-07-29 19:18:16 +01:00
Ted John 3ee7824df4
Fix #9678: Korean scenario name is not saved (#9679) 2019-07-29 19:17:49 +01:00
Jim Armstrong a432a8a514 Fix #9487: Access violation in UpdateRideEnterVehicle (#9577)
* Fix #9487: Implement nullptr checks

Implemented nullptr checks for the ride and vehicle variables
in UpdateRideEnterVehicle()
2019-07-29 18:07:21 +01:00
Ted John 0315c9b741
Add lots of guards to track block get next / previous (#9661) 2019-07-29 16:37:51 +01:00
Aaron van Geffen 5066ebebf9
Fix #9574: Text overflow in scenario objective window. 2019-07-29 15:16:36 +02:00
Hielke Morsink 3ac43114a6 Fix: tile inspector hotkey does not work with debugging tools disabled (#9669)
* Fix: tile inspector hotkey does not work with debugging tools disabled

* Update changelog
2019-07-28 16:55:11 +02:00
Michał Janiszewski 83e26804e5 Limit scrolling text colour to valid options (#9639) 2019-07-27 14:23:34 +02:00
Michael Steenbeek 382935c50f
Merge pull request #9644 from IntelOrca/refactor/banners
Refactor banners
2019-07-27 10:59:57 +02:00
Ted John 0b4d989a67 Rename get_banner to GetBanner 2019-07-26 17:24:19 +01:00
Ted John 3bff25ab22 Use TileCoordsXY 2019-07-26 17:14:09 +01:00