X7123M3-256
5c81d7deb9
Use block brake sprite for last station tile
2020-10-15 20:27:33 +01:00
X7123M3-256
dd8dcc6136
Fix incorrect bounding boxes
2020-10-15 20:27:33 +01:00
X7123M3-256
15aca5fbb5
Remove unnecessary comments
2020-10-15 20:27:33 +01:00
X7123M3-256
6ca16e0a06
Make JSON objects able to use hybrid track
2020-10-15 20:27:33 +01:00
Simon Jarrett
65a8c58af7
Fix missing direction arrow for stations
2020-10-15 19:44:36 +01:00
Simon Jarrett
25ce8b3f6e
Fix #7443 : Construction arrows pulse at irregular intervals.
2020-10-15 19:44:10 +01:00
Łukasz Pękalski
26720eb345
Fix #5178 : Lighting effects cannot be disabled in software mode ( #13206 )
...
Lighting effect are now automatically turned off when software renderer is selected.
2020-10-15 17:05:39 +02:00
ζeh Matt
645289f4ec
Rename GameActionResult and use GameActions namespace instead ( #13184 )
2020-10-14 22:04:39 -03:00
ζeh Matt
92e7b6244b
Fix #13192 : Crash because of objects not properly loading ( #13197 )
2020-10-14 21:54:22 -03:00
Vinicius Sa
711dd00cde
Close #13000 : Refactor ObjectFactory to use unique_ptr
...
Employs the smart pointer unique_ptr for safer memory management.
Classes involved:
- ObjectRepository
- ObjectManager
2020-10-14 21:56:48 +02:00
Aaron van Geffen
0c283ba3e7
Ride window: position graph buttons properly
2020-10-14 17:51:58 +02:00
Duncan
250586cb45
Port some OpenLoco helper functions ( #13113 )
...
* Port some OpenLoco helper functions
Added a few helper functions from OpenLoco to make viewport code a bit simpler
2020-10-12 22:25:11 -03:00
aw20368
0c195d14b9
Close #8848 Refactor TimeInPark ( #13146 )
...
Split TimeInPark into a union: ParkEntryTime for guests, HireDate for staff
2020-10-12 21:36:38 -03:00
Duncan
feb188ecb2
Remove incorrect variable from interval names ( #13175 )
...
Not sure why this has ended up in the interval names as it is not a rct_string_id. Luckily nothing at present was accessing this.
2020-10-12 21:35:08 -03:00
Aaron van Geffen
a5a65fe974
Fix #13167 : Broken dropdown menu in rendering engine options ( #13169 )
2020-10-11 23:06:35 +02:00
Michael Steenbeek
0bf851cfb2
Merge pull request #13164 from Gymnasiast/feature/objective-options-in-cheats
...
Add Objective Options to Cheats menu
2020-10-11 19:28:50 +02:00
Gymnasiast
eb2f40f35c
Fix typo in WC_EDITOR_OBJECTIVE_OPTIONS
2020-10-11 19:28:25 +02:00
Gymnasiast
16ca892449
Add Objective Options to Cheats menu
2020-10-11 19:28:25 +02:00
Keith Stellyes
2265938e9b
Fix old-style-cast build errors on BenchSpriteSort.cpp ( #13148 ) ( #13150 )
2020-10-11 17:43:22 +01:00
Julia Pinheiro
cba1d48226
Close #12408 : Refactor CURSOR_ID to use strong enum
2020-10-11 18:01:14 +02:00
Tulio Leao
f56039abfd
Close #5520 : Use std::filesystem over fts.h for recursive deletion
2020-10-11 17:15:05 +02:00
Simon J
d7b9a99a0f
Entrance/exit construction state fixes in ride and maze construction ( #13098 )
...
* Fix #1324 : track selection visible when placing entrance or exit
* Improve maze construction window UX in entrance/exit mode
- Arrows are disabled when entrance and exit are being placed
- Clicking a construction mode will disable the entrance and exit mode
- Previous state restored when leaving entrance/exit construction mode
- Fix entrance/exit buttons not changing when the mode switches after placing the first entrance/exit
Co-authored-by: Simon Jarrett <simonjjarrett@gmail.com>
2020-10-11 12:22:41 +01:00
Aaron van Geffen
8726b37951
Remove remaining old style casts from macos.mm ( #13153 )
2020-10-10 23:45:50 +02:00
X123M3-256
9681ea4cea
Add "Hybrid Coaster" ride type ( #12110 )
...
* Add "Hybrid coaster" ride type
* Add turns
* Add diagonal slopes
* Add bank transitions
* Add diagonal bank transitions
* Add banked turns
* Add sloped turns
* Add sloped bank transitions
* Add sloped banked turns
* Add s bends
* Add helices
* Add barrel rolls
* Add half loops
* Start changing supports to wooden
* Switch diagonals and banked turns to wooden supports
* Finish switching supports to wooden
* Alter default supports for small turns and steep turns
* Split track sprites that were glitching
* Fix incorrect sprite indices on small helices
* Add supports for large flat to steep pieces
* Fix bug with b supports
* Add supports for quarter loops
* Finalize set of track elements
* Fix strange colors when track piece is highlighted
* Update sprites.json
* Add support for corkscrews
* Fix incorrect remap colors and default supports
* Add slope to banked turn transitions
* Add support for preview image in color selection window
* Fix static glitches
* Correct Z offset
* Set segment heights (and fix more static glitches)
* Improve sloped curve supports
* Fix slope to banked turn transitions
* Fix dynamic glitches
* Fix boosters
* Remove corkscrews
* Set ride data and implement ride rating function
* Fix glitches on steep turns and gentle to steep
* Format code
* Add sprites
* Add track color preview image
* Fix formatting
* Add files to MSVC project
* Fix Testpaint
* Revert removal of RIDE_TYPE_50 from GetClassification
* Introduce constant instead of hard coded number
* Fix stray change
* Improve legibility of ride_ratings_calculate_hybrid_coaster()
* Fix comments on byte_97B23C
* Fix two other stray changes
* Fix Xcode project
* Adjust bounding boxes to make clipping behaviour more consistent
* Fix two glitches on medium and large turns
* Address comments from DuncansPumpkin
* Fix incorrect ride ID
* Fix steep turn sprites
* Run PNG images through OptiPNG
* Update changelog
* Fix namespace error
* Use arrays for supports to handle additional elements
* Rename functions to TitleCase and add namespace
* Increment network version
Co-authored-by: Edward Calver <hx010973@reading.ac.uk>
Co-authored-by: tylerleamon <59478575+tylerleamon@users.noreply.github.com>
Co-authored-by: Gymnasiast <m.o.steenbeek@gmail.com>
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
Co-authored-by: Aaron van Geffen <aaron@aaronweb.net>
2020-10-10 20:27:12 +01:00
Michał Janiszewski
0c3de1fa00
Fix potential nullptr dereference ( #13149 )
...
This fixes optimised builds on ARM
2020-10-10 14:49:33 -03:00
Julia Pinheiro
b628bba704
Close #12429 : Refactor OBJECT_ERROR to use strong enum and typo fix in build.sh ( #13145 )
...
* Close #12429 : Refactor OBJECT_ERROR to use strong enum
* Typo Fix in build.sh: Unknown
2020-10-10 16:21:07 +01:00
Duncan
f28907a87d
Rework tooltip to be more logical ( #13137 )
2020-10-10 10:49:56 -03:00
Tulio Leao
61c8cbf88b
Fix #13118 : Closing construction window resets ride viewport ( #13123 )
2020-10-10 10:01:28 -03:00
Tulio Leao
f418acfe19
Merge pull request #11493 from OpenRCT2/Wold-style-cast
...
Enable -Wold-style-cast
2020-10-10 09:15:59 -03:00
Bryan DiLaura
7c95f594d3
Close #12413 : Refactor VISIBILITY_CACHE to use strong enum ( #13136 )
2020-10-09 19:12:14 -03:00
Keith Stellyes
3468d1fc6b
Close #13125 : Selecting the RCT2 files now uses localised dialogs
2020-10-09 21:13:14 +02:00
Duncan
e23c1cded7
Fix logical sort
2020-10-09 20:59:43 +02:00
Duncan
197bb897bb
Fix #7748 . Move tooltip timeout reset to correct location ( #13132 )
...
* Fix #7748 . Move tooltip timeout reset to correct location
Mistake made in implementation
* Add changelog entry
2020-10-09 16:53:31 +01:00
Duncan
84c9ff833a
Move formatter to separate file. Rework GetMeasurement ( #13131 )
...
* Move formatter to seperate file. Rework GetMeasurement
* Add Formatter source files to Xcode project
Co-authored-by: Aaron van Geffen <aaron@aaronweb.net>
2020-10-09 08:02:07 -03:00
Tulio Leao
bace4d62f8
Specify SYSTEM includes on CMAKE builds
2020-10-09 01:28:34 -03:00
Tulio Leao
32c2b7d449
Merge pull request #13122 from vjavs/strong-enum/PeepSpriteType
...
Refactor PeepSpriteType to use strong enum
2020-10-08 23:48:45 -03:00
Duncan
4fb4feb83c
Fix missing error message on ride graph ( #13129 )
...
* Fix missing error message on ride graph
Mistake made during implementation meant that the ride graph would not show the error message when the ride had not left the station. Another mistake meant that the tertiary colour of the ride window was not set to green. The tertiary colour was only used by this error message though so was not noticed.
2020-10-08 15:22:23 -03:00
Tulio Leao
1cf0f91199
Fix #4041 : Garbled park option on scenario editor with custom theme ( #13126 )
...
* Fix #4041 : Garbled park option on scenario editor with custom theme
* Remove duplicate string draw
2020-10-08 14:35:25 +01:00
aw20368
119bacdd44
Fix #13083 : Dialog cropped for conflicting track design rename ( #13124 )
...
Change description drawing from gfx_draw_string_centred to gfx_draw_string_centred_wrapped.
2020-10-07 23:17:52 -03:00
Ben Johnston
2524e9201a
Fixed console cursor rendering. ( #13025 )
...
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2020-10-07 21:45:57 -03:00
Vinicius Sa
01d237ad27
Use helper function GetSpriteBounds
...
It's intended to retrieve a rct_sprite_bounds from the global array
g_peep_animation_entries, given PeepSpriteType and PeepActionSpriteType
as parameters.
2020-10-07 17:34:27 -03:00
Vinicius Sa
80718f1774
Use helper function GetPeepAnimation
...
It's intended to retrieve a rct_peep_animation_entry from the global
array g_peep_animation_entries, given PeepSpriteType and
PeepActionSpriteType as parameters.
2020-10-07 17:34:25 -03:00
Vinicius Sa
4d28901cb0
Refactor PeepSpriteType to use strong enum
...
Issue: 12396
2020-10-07 17:34:21 -03:00
ζeh Matt
61b510db66
Merge pull request #13073 from ZehMatt/refactor/audio-cleanup
...
Minor cleanup around audio code
2020-10-07 21:18:59 +03:00
Tulio Leao
a1b058f648
Fix #10186 : Placing multiple saved rides ignores design name ( #13120 )
2020-10-07 12:45:19 -03:00
Tulio Leao
076544f490
Merge pull request #13084 from vjavs/PVS-Studio/Fixes
...
Make some PVS-Studio fixes
2020-10-07 08:24:59 -03:00
Mike Jones
7441001c4e
Close #12407 : Refactor CHAT_INPUT to use strong enum ( #13116 )
2020-10-06 21:37:08 -03:00
Tulio Leao
db728d61a7
Fix signed/unsigned mismatch
2020-10-06 21:32:59 -03:00
Matt
7045fd9e9f
Minor cleanup
2020-10-07 01:10:53 +03:00
Matt
091145037e
Move the audio code into OpenRCT2 namespace
2020-10-07 00:34:42 +03:00
Vinicius Sa
22a1df32d7
Remove redundant assignment in CustomListView::MouseUp
...
Reported by PVS-Studio (Warning: V1048).
Fix 7/7.
Issue: 12523
2020-10-06 18:21:28 -03:00
Vinicius Sa
c6b7893d77
Verify pointer against nullptr before using it
...
Reported by PVS-Studio (Warning: V1004).
Fix 6/7.
Issue: 12523
2020-10-06 18:21:26 -03:00
Vinicius Sa
579e008590
Refactor process_mouse_over()
...
- Remove unnecessary local variables and assignments
- Remove unreached if-statement branch
Reported by PVS-Studio (Warning: V587).
Fix 5/7.
Issue: 12523
2020-10-06 18:21:24 -03:00
Vinicius Sa
59e9162137
Give a variable for an arithmetic operation used as a condition
...
Avoid reverse logic around if-statement for the sake of readability.
Reported by PVS-Studio (Warning: V793).
Fix 4/7.
Issue: 12523
2020-10-06 18:21:21 -03:00
Vinicius Sa
d583911997
Avoid variable shadowing in derived struct RCT12BannerElement
...
Give a more meaningful name to its private member that caused the
shadowing, as well as in the struct BannerElement.
Reported by PVS-Studio (Warning: V703).
Fix 3/7.
Issue: 12523
2020-10-06 18:21:19 -03:00
Vinicius Sa
b93024039a
Remove redundant sub-expression involving or bitwise
...
Reported by PVS-Studio (Warning: V501).
Fix 2/7.
Issue: 12523
2020-10-06 18:21:11 -03:00
Vinicius Sa
8e73dfd440
Fix possible memory leak in CreateObjectFromJson
...
As reported by PVS-Studio. Warning: V773.
Fix 1/7.
Issue: 12523
2020-10-06 18:20:37 -03:00
Matt
86b1c0dbe1
Minor cleanup around audio code
2020-10-06 23:31:51 +03:00
Tulio Leao
e53cde1d5d
Fix #6086 : Cannot install existing track design with another name ( #13082 )
2020-10-06 08:27:38 -03:00
Duncan
eb3f3edc1b
Use RemoveViewport helper function ( #13104 )
2020-10-06 10:27:56 +01:00
Ishmael King
fb47b3bb90
Close #9568 : Replace RRC lift sounds LiftWood to match SFRC ( #13071 )
...
* refactor: Replace RRC lift sounds LiftWood to match SFRC
* refactor: Replace SLC lift sounds with Classic lift sound
* Update replays for change in lift sound
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2020-10-05 23:14:43 -03:00
Vinicius Sa
bd8c633ea3
Close #12394 : Refactor PeepNauseaTolerance to use strong enum ( #13106 )
2020-10-05 22:13:44 -03:00
Aaron van Geffen
797fe48b0f
Merge pull request #13068 from mwnciau/json-compilation-performance
...
Fix #13055 : Replace includes of Json.hpp in header files with json_fwd.hpp
2020-10-06 01:09:41 +02:00
Aaron van Geffen
0ad7e9787e
Add JsonFwd.hpp to the Xcode project
2020-10-06 00:16:21 +02:00
Simon Jarrett
134371f03c
Change includes of nlohmann/json_fwd.hpp to new core/JsonFwd.hpp
2020-10-06 00:16:21 +02:00
Michael Steenbeek
b835477542
Add Esperanto to language list ( #13096 )
2020-10-05 08:21:27 -03:00
Aaron van Geffen
fe54eee07c
Tab-specific event functions for Options window ( #13058 )
...
* Options window: move event lists and open function.
* Options: split off display tab events; add event lists for each tab
* Options: split off rendering tab events
* Options: split off culture tab events
* Options: split off audio tab events
* Options: split off control/interface tab events
* Options: split off misc tab events
* Options: split off advanced tab events; remove old event functions
* Reduce code duplication with common mouseup event
2020-10-04 17:08:10 +02:00
Tulio Leao
f4b588256d
Merge pull request #13066 from tupaschoal/fix-5904
...
Light Tile Inspector Improvements
2020-10-03 15:16:10 -03:00
Michael Steenbeek
8e60ecc022
Do not output error if the sourceGame parameter is omitted ( #13079 )
...
Since >90% of objects in the wild are custom objects, it make sense if this
parameter can be safely omitted. Only warn if this field contains garbage.
2020-10-03 14:41:52 -03:00
Simon J
7f963c4901
Fix entrance and exit ghosts not being removed for mazes ( #13074 )
...
* Fix entrance and exit ghosts not being removed for mazes
Co-authored-by: Simon Jarrett <simonjjarrett@gmail.com>
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2020-10-03 09:33:28 -03:00
Matt
0d43f1fd91
Directly use enums for serialisation
2020-10-03 06:15:13 +03:00
Matt
13f332d5b8
Ensure/Cleanup member initialization for game actions
2020-10-03 05:58:57 +03:00
Matt
82916f6824
Use default constructor
2020-10-03 05:55:33 +03:00
Julia Pinheiro
6a76547c5b
Close #12412 : Refactor PROMPT_MODE to use strong enum ( #13076 )
2020-10-02 23:04:59 -03:00
Mike Jones
4c26fb09b3
Close #12435 : Refactor FILEDIALOG_TYPE to use strong enum ( #13072 )
...
* Close #12435 : Refactor FILEDIALOG_TYPE to use strong enum
2020-10-02 22:43:06 -03:00
Julia Pinheiro
8800c32e52
Close #12404 : Refactor DRAWING_ENGINE to use strong enum ( #13070 )
2020-10-02 22:41:30 -03:00
Simon Jarrett
9c5e9f8dbc
Replace includes of Json.hpp in header files with json_fwd.hpp
2020-10-02 11:31:20 +01:00
Tulio Leao
09bb66848c
Change windowTileInspectorTile to TileCoordsXY type
2020-10-02 01:45:08 -03:00
Tulio Leao
e4d72cefaa
Fix #5904 : Empty errors on tile inspector base height change
2020-10-02 01:06:54 -03:00
Tulio Leao
0981b49e99
Fix #8957 : Error title missing when building w/ insufficient funds ( #13020 )
2020-10-01 23:19:34 -03:00
Julia Pinheiro
c36ec5c5ce
Close #12425 : Refactor SOCKET_STATUS to use strong enum ( #13064 )
2020-10-01 22:10:51 -03:00
Julia Pinheiro
657106d4c6
Close #12424 : Refactor NetworkStatisticsGroup to use strong enum ( #13056 )
2020-10-01 22:07:48 -03:00
Tulio Leao
29955f28e0
Merge pull request #12976 from mwnciau/Refactor-TRACK_ELEM-enum
...
Refactor TRACK_ELEM_* enum
2020-10-01 22:05:44 -03:00
Simon Jarrett
088db4a7c3
Fix incorrect const names of long base pieces
...
- Fix function names referring to that of the renamed consts
- Fix incorrect mirror of TrackType::FlatToDown60Long in TrackData
2020-10-01 19:57:52 +01:00
Simon Jarrett
52209af94d
Rename TRACK_ELEM_* enums to TrackElemType::*
...
- Replace enum in Track.h with namespace and constexpr
- Find and replace all instances of TRACK_ELEM_* enums
2020-10-01 19:57:52 +01:00
Sam J Gunner
55b4c4c6f1
Fix #13046 : Simplify block sectioned comparisons ( #13049 )
2020-10-01 09:06:28 -03:00
Duncan
ea036a38fd
Use MapCanConstructWithClear in LandSetHeightAction ( #13037 )
2020-10-01 08:41:35 -03:00
Michael Steenbeek
e255c7bb58
Fix #13044 : Rides in RCT1 saves all have "0 customers per hour" ( #13045 )
2020-10-01 10:32:51 +01:00
Bryan DiLaura
56e8cc77c6
Close #12409 : Refactor CONSOLE_INPUT to use strong enum ( #13052 )
2020-10-01 10:31:03 +01:00
Duncan
afbc983a94
Fix #13050 : Mistake during refactor removed drawing cached track count ( #13051 )
2020-10-01 09:57:46 +02:00
Duncan
2063aea5ef
Remove common format formatter where possible ( #13034 )
...
* Remove common format formatter where possible
Eventually should have it limited to tooltips, window titles and widget args
* Remove remaining paint functions using common
* Remove misuse of gCommonFormatArgs
2020-09-30 22:42:04 +01:00
Michael Steenbeek
e4068b9fa8
Fix #8015 : RCT2 files are not found when put into the OpenRCT2 folder ( #13043 )
...
As mentioned in #8015 , gExePath is never set, so I removed that variable altogether.
2020-09-30 18:37:50 -03:00
rpstester
3508bdc37d
Close #12390 : Refactor PeepRideSubState to enum class
...
Also made a RideSubState as a union with SubState and SittingSubState
Updated all values across all files, and the corresponding assert.
2020-09-30 23:33:58 +02:00
Vinicius Sa
41820cd3c2
Close #12392 : Refactor PeepActionType to use strong enum
2020-09-30 23:19:10 +02:00
Tulio Leao
b92328ce34
Merge pull request #13004 from vjavs/strong-enum/PeepActionSpriteType
...
Refactor PeepActionSpriteType to use strong enum
2020-09-29 23:38:23 -03:00
ζeh Matt
30307ec42d
Merge pull request #13030 from ZehMatt/fix-4617-2
...
Fix #4617 : Crash when rotating with invalid viewport open
2020-09-30 00:53:32 +03:00
Matt
005e1e0e1f
Final cleanup
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:51 +03:00
Matt
850b10f1fd
Fix memory leak
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:41 +03:00
Matt
f765ed2f94
Use unique_ptr for TitleSequenceParkHandle Stream
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:28 +03:00
Matt
e3a4d6a245
Use std::string for TitleSequenceParkHandle HintPath
...
Co-authored-by: Gabriel Guedes <gabriel.guedesaz@gmail.com>
2020-09-29 23:23:01 +03:00