mirrors
/
OpenRCT2
mirror of https://github.com/OpenRCT2/OpenRCT2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
24,282 Commits 7 Branches 39 Tags 352 MiB
Commit Graph

3590 Commits

Author SHA1 Message Date
Gymnasiast 418c5a6708
Use GetColourButtonImage() for remaining windows 2022-10-11 14:44:45 +02:00
Gymnasiast 89cd86da4d
Fix #18290: Ride and plug-in window colours not appearing 2022-10-11 14:44:07 +02:00
Rik Smeets 0c78a27d9f
Fix missing validation on invalid characters in file name (#18287) 
When saving a new file with a name containing '/' or '\' on Windows, the incorrect file name would be determined since these characters represent a new folder. This would trigger a failure on save.

The user's input should be validated in all cases. Before, it was only executed for folder names. This change also applies the validation on file names.
 2022-10-11 13:27:11 +02:00
Michael Steenbeek 6fe19878f6
More ImageId cleanup (#18258) 
* Remove more usages of uint32 image indices

* Remove unused gfx_get_sprite_size()

* Remove uint32 images from text drawing

* Remove now-unused ImageId overload

* Default-initialise ttfRunIndex

* Suppress false-alarm GCC error
 2022-10-10 19:42:40 +01:00
Silent 9ea6351708
Windows: Use a modern file/folder picker 2022-10-09 17:12:46 +02:00
Gymnasiast c33e377d7c
Close #17341: Always allow loading with incorrect checksum 2022-10-08 22:58:23 +02:00
Michael Steenbeek bfd333bb38
Merge pull request #18217 from CookiePLMonster/fix-18200 
Refactor Windows locales and remove the last non-Unicode functions
 2022-10-08 21:47:12 +02:00
Michael Steenbeek c31482a3c3
Merge pull request #18255 from Gymnasiast/refactor/load-s6-s4 
Remove old S6/S4 loading functions
 2022-10-08 21:46:32 +02:00
Rik Smeets 8e33cf580f Code style: Remove snakes from virtual floor 2022-10-08 20:50:59 +02:00
Gymnasiast d5f6a5b285
Replace context_load_park_from_file() with object equivalent 2022-10-08 20:12:35 +02:00
Duncan 5dba30778d
Code style: Remove more snakes from the park, maphelper, scenery. (#18222) 2022-10-08 06:56:17 -03:00
Haven Kim 34170d6814
Fix #17853: Invention name tears while being dragged (#18223) 2022-10-08 06:52:32 -03:00
Hielke Morsink d4774293d5
Fix #18064: Unable to dismiss notification messages 2022-10-07 16:44:06 +02:00
Silent 0f978fe907
Remove the last non-Unicode Windows functions 2022-10-07 15:05:43 +02:00
leoleotte 0dee78bfe5
Close #13774: Refactor Footpath window to class 2022-10-06 19:41:31 +00:00
Michael Steenbeek fa81f119c2
Merge pull request #18208 from Gymnasiast/fix/18204 
Fix #18204: Crash opening New Ride window with invalid highlight
 2022-10-06 10:54:19 +02:00
ZeeMajora e6df43b7c9
Extras tab: add Tycoon park, keep competitions apart 2022-10-05 20:51:37 +00:00
Michael Steenbeek 051ede1598
Merge pull request #18213 from duncanspumpkin/codeStyle4 
Code style: Remove snakes from Location, LargeScenery and MapAnimation
 2022-10-05 22:36:39 +02:00
Michael Steenbeek 99e13e023e
Name unknown_15 window event as ScrollSelect 
Co-authored-by: leoleotte <leoleotte@users.noreply.github.com>
 2022-10-05 21:59:20 +02:00
Rik Smeets c5904d81d6
Code Style: Remove snakes from paint tile elements (#18212) 2022-10-05 21:27:38 +02:00
duncanspumpkin 16581e9288 Address snakes in mapgen and map animation 2022-10-05 20:22:51 +01:00
duncanspumpkin 2a593b6029 Remove snake cases from Location and LargeScenery 2022-10-05 20:21:56 +01:00
Gymnasiast 33f5fed0e2
Make GetFirstNonNullRideType() member function 2022-10-05 20:24:15 +02:00
Gymnasiast 79f3e28b07
Fix #18204: Crash opening New Ride window with invalid highlight 2022-10-05 20:13:11 +02:00
duncanspumpkin 3e8dc1b2ac Remove snakes from the foopaths 2022-10-04 20:08:14 +01:00
duncanspumpkin 2c29190ff8 Remove snakes from entrance 2022-10-04 20:07:35 +01:00
Michael Steenbeek 2e6595fe8a
Merge pull request #18050 from IntelOrca/assetpacks-audio 
Add asset pack manager and asset packs
 2022-10-04 19:08:38 +02:00
73 8c3ff1bfa8
Replace Transparancy with Transparency 2022-10-04 18:28:15 +02:00
Ted John 0defe35d75 Update look of asset packs window 2022-10-03 20:16:01 +01:00
Stephan Spengler 9e1937d144
[Plugin] Widget tooltips can now be read and changed 2022-10-03 20:50:19 +02:00
Duncan 3565a0172d
Attack snakes in banners and climate (#18163) 2022-10-01 18:54:15 +02:00
Ted John 2415b2e608 Fix compiler errors 2022-10-01 14:35:23 +01:00
Ted John 9bb47d0aa1 Add tooltips and new reload icon 2022-10-01 13:53:18 +01:00
Ted John 06e5b7cc1a Remove toggle button 2022-10-01 13:28:47 +01:00
Ted John 717e265c19 Add checkboxes to asset pack window 2022-10-01 13:07:13 +01:00
Ted John edb37a9fba Fix win32 builds 2022-10-01 13:06:55 +01:00
Ted John bf85e6de4c Implement loading / saving asset pack config 2022-10-01 13:06:55 +01:00
Ted John 331a5961b1 Implement asset packs for audio 2022-10-01 13:06:52 +01:00
73 b9e677945d
Replace 20XX with 2022 (#18158) 
* Replace 2020 with 2022

Replace all 2020 headers with 2022

* replace other years with 2022

add missing years
 2022-10-01 08:42:14 +01:00
Gymnasiast 26c080a0d7
Remove unused symbols, fixes 2022-09-30 00:01:13 +02:00
Gymnasiast cedccf9b0e
Use const ImageId in drawing functions 2022-09-29 21:17:15 +02:00
73 a8073f6bd5
Increase limit on Loan Interest from 80% to 255% 
Co-authored-by: Gymnasiast <m.o.steenbeek@gmail.com>
 2022-09-27 12:20:01 +02:00
Michael Steenbeek 36b775e573
Fix #17811: Erratic “same price” for photos if gSamePriceThroughoutPark is corrupted 2022-09-26 19:58:19 +02:00
Meehoi 61d74eaa4b
Part of #15589: Make numpad enter able to confirm input 2022-09-25 18:33:02 +00:00
Hielke Morsink cf6de246ea
Merge pull request #16873 2022-09-25 18:58:52 +02:00
Michael Steenbeek a3b7ac5a90
Create category for DLC and BYO scenarios 2022-09-25 12:59:35 +02:00
Rik Smeets 425000bfca
Don't prompt to 'Save game as' when saving (#16819) 
After loading a saved game and choosing 'Save game', the 'Save game as' window would open the first time every time after loading the save.
Now, it will be saved using the existing save path, except when an autosave is loaded which the player probably doesn't want to overwrite.
 2022-09-25 08:33:28 +02:00
Hielke Morsink c77a685225
Fix invalidation issues 2022-09-25 00:19:35 +02:00
Alex b00b158464
Refactor of TileInspector to Window class 2022-09-25 00:19:29 +02:00
Stephan Spengler 6be41893a4
Fix #18059: Width and height of custom window not changeable via script (#18061) 2022-09-24 07:06:26 +02:00
Meehoi d6ca1a3da9
Fix #18035: Favourited servers don't get their online status updated 
From fetching flow, list will always have favourited servers but no code to update those entries, only append.
This code updates those favourited servers in the list with new data from internet by matching address.
This will fix list having 2 duplicate servers too. (one favourited and one not)
 2022-09-23 22:51:05 +02:00
Michael Steenbeek 31e2d7692c
Rename more instances of “vehicle” to “train” 2022-09-22 11:22:18 +02:00
Hielke Morsink 8d08c13fa6
Fix #17963: Opening research tab breaks marketing tab 2022-09-21 14:49:08 +00:00
Gymnasiast 67c82b75e6
Fix: Cannot build banked turns on the Bobsleigh RC 2022-09-21 15:21:28 +02:00
Gymnasiast 97aec235e7
Fix #18053: Ride types without vehicles get all pieces disabled 2022-09-21 15:10:59 +02:00
Hielke Morsink 43dbf9eb18
Fix #18032: non-interactive widgets produce sound 2022-09-19 20:38:34 +00:00
Michael Steenbeek 0a571cce29
Fix #17992: Virginia Reel doesn't show sloped tracks 2022-09-12 22:39:40 +02:00
Michael Steenbeek b258298b69
Close #13772: Refactor EditorScenarioOptions to class (#17983) 2022-09-11 17:58:54 +02:00
Fruitsalad f17b1a970e
Remove headless servers from the player list UI 2022-09-06 23:28:33 +02:00
Michael Steenbeek 99a0876ad6
Disable track elements if no train supports them (#17909) 
This can be useful in several situations:
- In RCT1 scenarios, or when playing with ported RCT1 vehicles, it will disable elements like banked turns
- We can add extra elements to existing coaster types by default, even if no RCT2 train supports them
 2022-09-06 21:24:02 +00:00
Henry Cheng 121f121d4e
#17735 Track elements are listed twice when building backwards 
Fix: Instead of checking whether bank has the value TRACK_BANK_UPSIDE_DOWN, instead check bank_start, as bank is not guaranteed to be bank_start.
 2022-09-06 23:21:22 +02:00
Stephan Spengler 1b5f50fd32
Fix #17974: Setting tabIndex of custom window does not work 2022-09-06 22:17:40 +02:00
Michael Steenbeek 34c7bed26b
Use vertical tabs in the New Game dialog 2022-09-03 23:08:43 +02:00
spacek531 8c8dc632b8
Implement #17806: Warn user if fallback images are used 
Warns user on the object debug info, when closing the object selection window after selecting objects, and when opening a park.
 2022-09-03 13:56:23 +00:00
Henry Cheng 5f24099f39
Close #17868: Allow scripting to change active tab 2022-08-31 23:13:02 +02:00
Henry Cheng 0c76872869
Fix #17816: Option to pause Steam Overlay not greyed out when using OpenGL 2022-08-31 23:08:36 +02:00
Michael Steenbeek 9dd28c90d7
Merge pull request #17908 from Gymnasiast/refactor/window-clean 
Small window symbol cleanup
 2022-08-29 22:04:13 +02:00
Hielke Morsink 61c35c8f1c
Fix #17905: chain button enabled for rectangular maps 2022-08-28 09:36:18 +02:00
Gymnasiast 45e7ee6a73
Rename rct_window_event_list to WindowEventList 2022-08-27 16:56:52 +02:00
Gymnasiast 5647fc8506
Fix flag usage 2022-08-27 16:52:29 +02:00
Gymnasiast ae8b2b8374
Remove unused window events 2022-08-27 16:50:02 +02:00
spacek531 74ff5429a9
Add Classic Wooden Roller Coaster 
Co-authored-by: Gymnasiast <Gymnasiast@users.noreply.github.com>
 2022-08-26 23:53:03 +02:00
leoleotte 83e4277cea
Close #13807: Refactor Themes window to class 2022-08-24 21:33:37 +02:00
Gymnasiast a088537b65
Rename rct_widgetindex to WidgetIndex 2022-08-21 18:49:23 +02:00
Hielke Morsink 7f29e4e39c
Make `rct_windowclass` strong type `WindowClass` 
This already revealed some places where implicit conversions were done, including some where its use was nonsense (MouseInput.cpp).
The changes to the Intent class were necessary to keep things working, and this splits things up more neatly.
 2022-08-21 18:38:25 +02:00
Ted John 05f2995d71
Fix #17843: New ride window incorrectly shows track design list 2022-08-21 16:19:43 +02:00
skdltmxn 4fcdafc0f4
Fix #17834: finance window becomes blank after 4096 years 2022-08-17 23:05:18 +02:00
ale 7f33e4886d
Fix #17544: Placement rule in Invention List window does not move 2022-08-15 19:52:20 -04:00
ale 3a5a8d4f78
Fix #17754: Scenery Group thumbnails missing in Invention List window 2022-08-15 19:50:01 -04:00
Michael Steenbeek 354df90ab1
Fix #17815,#17818: Special... dropdown and brake settings glitches 2022-08-14 20:37:32 +00:00
Gymnasiast 5945f7110a
Move gGotoStartPlacementMode to windows/RideConstruction.cpp 2022-08-13 23:00:54 +02:00
Gymnasiast f8a94c2e12
Move two functions out of _legacy.cpp 2022-08-13 23:00:53 +02:00
Michael Steenbeek d9e23e9dfa
Use ride_type_t instead of uint8_t in more places (#17803) 
Part of preparation for making ride types into objects.
 2022-08-13 21:49:19 +02:00
Michael Steenbeek 49215a52cf
Remove unnecessary pops from some strings (#17805) 2022-08-13 20:12:30 +02:00
Gymnasiast 4832e67d14
Fix crash in ride_scroll_to_track_error() 2022-08-13 17:21:34 +02:00
frutiemax 2202f8d060
Add ConstructionWindowContext field to RTD (#17749) 2022-08-13 09:18:56 -03:00
Michael Steenbeek 5661da1c68
Unwrap game action compat wrappers 2022-08-11 00:00:58 +02:00
Michael Steenbeek 93807ec5bf
Remove ride type checks for log bumps/rapids string 2022-08-10 23:43:00 +02:00
Michael Steenbeek 980e3cbc4c
Remove superfluous line from MSVC project file 2022-08-06 16:34:10 +02:00
Michael Steenbeek a7e66535d9
Change ‘restroom’ to ‘toilet’ in the code 2022-08-06 14:33:37 +00:00
frutiemax 6868b3dcaf
Rename IS_SHOP to IS_SHOP_OR_FACILITY and use it for RideObject 2022-08-06 15:00:52 +02:00
frutiemax 2d75858589
Add IS_FIRST_AID flag 2022-08-06 15:00:52 +02:00
frutiemax 76104cbbee
Use RIDE_TYPE_FLAG_IS_TOILET 2022-08-06 15:00:52 +02:00
AuraSpecs 5249ae1426
Enlarge Special Elements dropdown 
Enlarging the Special Element dropdown to accomodate for the new longest name "Large Corkscrew (right)" so you can at least make out which direction it's turning in.
 2022-08-06 11:25:25 +02:00
Michał Janiszewski a9fe4da279 Use SDL_ShowMessageBox's 'close' value for dummy UI context 2022-08-04 18:42:34 +02:00
Michał Janiszewski a6e84fab5c Add a message box with buttons to UiContext 2022-08-04 18:42:33 +02:00
Nikolas Parshook a44ddd5adc
Refactor NewRideWindow to use Window class 2022-08-03 21:59:03 +02:00
Michael Steenbeek 80f0d952ad
Merge pull request #17638 from X123M3-256/new_track_pieces 
Add new track pieces to the hybrid and single rail
 2022-08-01 23:24:22 +02:00
Henry Cheng 281cf137f4
Fix #17639: Duplicate special elements when building upside down 2022-07-31 21:51:08 +00:00
Gymnasiast 9841b4e9e0
Fix naming conflicts 2022-07-31 22:30:18 +02:00
Gymnasiast d3fd31c611
Rename rct_string_id to StringId 2022-07-31 22:30:13 +02:00
Hielke Morsink 7cb2113252
Apply clang-format rules 2022-07-31 20:34:32 +02:00
Hielke Morsink d6525e3cd0
Refactor window functions to take references 7 2022-07-31 17:23:18 +02:00
Hielke Morsink d05d675ed9
Refactor window functions to take references 6 2022-07-31 17:23:17 +02:00
Hielke Morsink 755deeef8e
Refactor window functions to take references 5 2022-07-31 17:23:17 +02:00
Hielke Morsink a258008bef
Refactor window functions to take references 4 2022-07-31 17:23:16 +02:00
Hielke Morsink 523bb8136e
Refactor window functions to take references 3 2022-07-31 17:23:16 +02:00
Hielke Morsink c8605a8763
Refactor window functions to take references 2 2022-07-31 17:23:15 +02:00
Hielke Morsink 76c1bc8980
Refactor window functions to take references 1 2022-07-31 17:23:15 +02:00
frutiemax e96f428c7b
Add RIDE_TYPE_FLAG_HAS_SEAT_ROTATION for multi-dim rollercoaster 2022-07-31 12:01:22 +02:00
X123M3-256 da710557de Fix bug in ride construction window 2022-07-31 10:22:46 +01:00
X123M3-256 ffbf8f4706 Fix bit shifts in ride construction window 2022-07-31 10:22:45 +01:00
X123M3-256 c6a5a6da5f Allow more than 32 special pieces in construction menu 2022-07-31 10:22:04 +01:00
Michał Janiszewski 3c4a07859b
Provide enough space in temp buffer 
```
src/openrct2-ui/windows/Ride.cpp:3338:44: error: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Werror=format-truncation=]
 3338 |     snprintf(buffer, std::size(buffer), "%u", currentValue);
      |

(...)

/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘__builtin___snprintf_chk’ output between 2 and 6 bytes into a destination of size 5
```
 2022-07-30 23:19:52 +02:00
Michael Steenbeek 0bfc151ab9
Remove remaining usages of gGameCommandErrorText 2022-07-30 18:04:59 +02:00
Ted John 142b9ff243
Optimise object selection search 
* Do case insensitive string matching for object search.
* Return as soon as first field is a hit.
 2022-07-30 16:50:54 +02:00
Michael Steenbeek 5a5b107245
Refactor Twist rotations, fix truncating of operating value (#17636) 2022-07-30 16:32:22 +02:00
Hielke Morsink e2da19f0f7
Add missing includes 2022-07-29 18:45:10 +02:00
Michael Steenbeek 2b859c7099
Remove __ENABLE_LIGHTFX__ define 
It is already enabled for all our builds, and upcoming changes to RTD would add a slew more.
Discussed in team chat with Duncan and Hielke.
 2022-07-28 21:34:02 +00:00
Gymnasiast 5e8b749277
Fix #17542: Stalls will autorotate towards paths outside the park 2022-07-28 21:26:11 +02:00
Raymond Zhao 7399163a3c
Use more smart ptrs and u8strings (#17611) 
* Use smart ptr for PlatformUiContext and WindowManager

* Remove more delete calls

* Apply PR feedback
 2022-07-28 18:19:38 +01:00
Michael Steenbeek e5d2e3001d
Fix buffer size handling for ride operations input 
Ensure a nicely terminated string
 2022-07-28 14:24:19 +02:00
Michael Steenbeek 1a8660d59d
Pass window reference to tool_set (#17625) 2022-07-27 22:22:22 -03:00
Gymnasiast 39f60c3412
Input current value; fix dodgems mode detection 2022-07-27 23:13:01 +02:00
Rik Smeets 1eb3a86770
Ride operating settings can be set via text input 
Both minimum and maximum wait time and operating settings for flat rides can now be set via text input.
 2022-07-27 22:50:04 +02:00
Michael Steenbeek 30f477972c
Close #15358: Increase park name character limit 2022-07-27 17:35:15 +02:00
Duncan 7433119749
Fix #17620. Missing setting ride id for construction window (#17622) 
This would eventually cause a crash when trying to reset the window on last track piece deletion. Mistake made in refactor #17578
 2022-07-27 16:06:33 +01:00
Raymond Zhao 4f23e5e9ec
Refactor struct TrackDesignFileRef 
- Refactors track_design_file_ref to TrackDesignFileRef and replaces the utf8* fields of that struct with u8string
- Gets rid of some String::Duplicate() and delete calls
- Uses a bunch of c_str() calls to interface with older functions
 2022-07-26 16:12:46 +00:00
Nikolas Parshook 628da77c0e
Refactor ride construction window (#17578) 2022-07-26 15:17:25 +01:00
Ted John bd6817cb45
Fix #17533: Missing audio when specifying --rct2-data-path 2022-07-25 14:26:28 +00:00
Henry Cheng 08e0b9ae8d
Fix #17508: Grid Doesn't Disable After Setting Patrol Area (#17574) 
* Move show_gridlines to only run under condition

* Update changelog.txt

Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-07-25 13:39:19 +00:00
jazzysoggy c0853b56ad
Fix Format_VA. Rename Format to StdFormat. 
author jazzysoggy <39224097+jazzysoggy@users.noreply.github.com> 1655955994 -0400
committer jazzysoggy <39224097+jazzysoggy@users.noreply.github.com> 1656516326 -0400

Fixed Format_VA and renamed Format to StdFormat. Both now output to Std::String, while taking the same input as before. Changed functions that use these two to account for this output difference
 2022-07-24 19:30:57 +02:00
AuraSpecs d82360cc16
Add Authors to the list of things you can search for in the Object Selection menu (#17575) 
* Add Authors to Search option

Joint effort from Spacek and karst

* Update changelog.txt

* Apply code review comment

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-07-23 20:28:39 +00:00
Duncan 3edcc91e40
Fix #17339. Reset Scaleing frame buffers on scale change (#17598) 
* Fix #17339. Poor visuals due to scalling incorrectly

Mistake made during refactor meant that the scaleing framebuffers were
kept enabled even though at integer numbers of scale they are not meant
to be used.

* Update changelog
 2022-07-23 20:11:00 +00:00
Henry Cheng 46a2047309
Refactor Server Start Window to Class (#17592) 
* Refactor first

* Update refactor

* Add fixes requested

* Dropped static
 2022-07-23 20:47:17 +01:00
Michał Janiszewski 5688eb511d
Use SDL_free to release SDL_RWops (#17591) 2022-07-22 22:28:58 +00:00
Raymond Zhao 71ad3af930
Use more smart pointers in openrct2-ui (#17582) 
* Use more smart ptrs

* Use move instead of copy ctor
 2022-07-22 11:48:43 +01:00
Raymond Zhao f4df6be8ae
Remove some calls to free (#17577) 2022-07-21 07:50:43 +01:00
Henry Cheng 3bad01a704
Fix #17553: Crash when moving invention list items to empty list (#17555) 
* Fix content check

* Add change log entry

Co-authored-by: Duncan <duncans_pumpkin@hotmail.co.uk>
 2022-07-17 07:12:29 +00:00
Cory Sanin 37a38af6a5
Fix: [#17503] Correct staff refactor issue (#17546) 2022-07-17 07:43:32 +01:00
8street 213696ea27
Add option to sell merchandise in random colours 
Co-authored-by: 8street <nikolai_e@rambler.ru>
 2022-07-12 22:20:49 +00:00
Michael Steenbeek 11614d7170
Merge pull request #17486 from duncanspumpkin/inventionWnd 
Invention List Window Class Refactor
 2022-07-12 19:49:03 +02:00
Gymnasiast 06c368694a
Update variables containing a CarEntry 2022-07-11 18:06:22 +02:00
Duncan 5d896c65b5
Refactor Guest Window to Class 2022-07-03 22:00:37 +02:00
Hielke Morsink 43a98680ac
Fix: Fallback when selecting RCT1 titles while it's not installed 2022-07-03 16:39:27 +02:00
Hielke Morsink d06f564506
Clean up some title sequence code 2022-07-03 16:20:23 +02:00
Cory Sanin 05f1007dd9
Fix #16989: Re-focusing maximised window triggers a restore and maximise 
Fixes #16989 by removing an SDL hack. Originally added to address issue #2158, I can't reproduce this issue with the hack removed. Tested on Linux (by CorySanin) and Windows (by Broxzier).
 2022-07-02 21:48:43 +02:00
Artem Yanenko 019ed54a48
Fix #17377: Park entrance can be placed without path in Scenario Editor 2022-07-02 14:02:27 +00:00
Sadret 544770c0fb
Fix #16539: CustomListView header unclickable when scrolled 2022-07-02 12:34:12 +02:00
duncanspumpkin 8492453702 Refactor to conform to style. Move uncommon items out of rct_window 2022-07-02 07:53:46 +01:00