Commit Graph

2784 Commits

Author SHA1 Message Date
Michael Steenbeek 95111047b0
Merge pull request #15249 from Broxzier/feature/make_ptr
Refactor use of std::unique_ptr
2021-08-21 21:50:42 +02:00
ζeh Matt 8de2965f13
Merge pull request #15231 from ZehMatt/fix-15169
Refactor out capturing of window pointers with GA callbacks
2021-08-21 06:07:35 -07:00
Hielke Morsink 15d3a4a9da
Update more include guards (#15254) 2021-08-21 12:55:28 +02:00
Hielke Morsink dd2467d805
Update include guards
- Update from C-style to pragma once
- Add missing include guard to ui.h
2021-08-21 09:43:26 +02:00
Michael Steenbeek f5935931e3
Port remaining DrawTextWrapped calls with void args to Formatter 2021-08-21 09:42:05 +02:00
ZehMatt 8d801d9126
Apply review suggestion 2021-08-21 01:10:36 +03:00
Hielke Morsink 6011478590 Directly use std::unique_ptr prvalues
This removes the unnecessary constructor calls and improves flexibility in case of typename changes.
All cases, except for the one in Context.cpp, are temporaries.
2021-08-20 23:38:15 +02:00
Michael Steenbeek c6a7829554
Fix #15245: Excitement factors are all listed as 0% 2021-08-20 13:05:54 +02:00
Margen67 a371d1ff11
Disallow opening problematic windows in multiplayer 2021-08-19 12:04:49 +02:00
Basssiiie 399f6f27b4
Fix #15176: Incorrect base height in tile inspector for track pieces (#15233) 2021-08-17 17:10:33 +01:00
ZehMatt f4602f49c7
Remove capture of window pointer in RideConstruction.cpp 2021-08-17 00:43:03 +03:00
ZehMatt b7a4b00a07
Remove capture of window pointer in Player.cpp 2021-08-17 00:42:39 +03:00
Duncan 940cab87d3
Map size refactors from NSF (#15112)
* Support large map sizes

* Fix top spin painting

* Fix crooked house

* Increase bb size

* Decrease limit back

* Clang format

* Remove asserts and apply review comments

* Fix rebase mistake

Co-authored-by: Ted John <ted@brambles.org>
2021-08-16 20:51:16 +01:00
ζeh Matt 758ad547ce
Remove strdup in ObjectLoadError.cpp fixing a memory leak (#15218) 2021-08-16 14:18:22 +01:00
ζeh Matt 1553c904ea
Fix #15221: Update tile inspector highlighted element when order changes (#15223) 2021-08-16 10:36:02 +01:00
Kane 767dbfe41c
Issue #13814: Refactor window to class: Viewport (#15217)
* Issue #13814: Refactor window to class: Viewport

* Code style

* Code improvements

* Code improvements

Removes unnecessary private var _viewportWindowNumber
GetFreeViewportNumber function updates window->number
2021-08-15 16:09:08 +01:00
Saad Rehman d6ad9b67e7
Fix #15161 #15159 one-off error when getting stationIndex (#15163)
* Fix #14918 refactor stationIndex and loop to avoid in/decrement to null

Fix #15161 #15159 one-off error when getting stationIndex

* Add const and remove unused variable

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2021-08-12 17:20:15 +01:00
Kane cf9bb4cd2c
Fix issue #15211: Rename RideConstructionState::Build to ...::MazeBuild (#15212)
Pull #15203 commited enum RideConstructionState missing the "Maze" part in "MazeBuild"
2021-08-12 16:43:34 +01:00
Michael Steenbeek e547dd96db
Make RideConstructionState a strong enum 2021-08-11 17:51:59 +02:00
ZehMatt 575a24956d
Feature #15164: Highlight selected Tile Inspector element 2021-08-10 16:49:41 +03:00
Ted John 40a4a993de
Fix #15170: Plugin: incorrect label text alignment (#15175)
Initialise CustomWidgetDesc::TextAlign.
2021-08-04 21:47:13 +02:00
Michael Steenbeek 2beed229a9
Fix negative Gs display (#15171) 2021-08-03 05:25:06 +01:00
Michael Steenbeek 3c86d56933
Merge pull request #15129 from ZehMatt/refactor/clang-tidy-01
Minor cleanup
2021-08-02 22:04:08 +02:00
Ted John 5f853df1fd
Remove gS6Info 2021-08-02 20:38:02 +02:00
Ted John 417c0f584f
Handle > 255 rides in ride list window 2021-08-01 15:18:15 +02:00
Gymnasiast 85043cb367
Fix abs error 2021-08-01 15:14:43 +02:00
Gymnasiast 93515f4414
Use money64 for land and water tools
Should hopefully also fix CI.
2021-08-01 15:14:43 +02:00
Gymnasiast 676ef7205e
Change all calls to DrawTextBasic to use Formatter 2021-08-01 15:14:43 +02:00
Gymnasiast c06d37021b
Change gClearSceneryCost to money64 2021-08-01 15:14:43 +02:00
Matt d9003b05ef
Use money64 for track design costs 2021-08-01 15:14:43 +02:00
Gymnasiast f1a67dda61
Fix water window cost display 2021-08-01 15:14:42 +02:00
Ted John 58ae6bbd8a
Fix money64 issue in scenario options 2021-08-01 15:14:42 +02:00
Ted John e56b7ae4a4
Fix more money64 issues 2021-08-01 15:14:42 +02:00
Ted John 74de598cc0
Fix money formatting on cheat window 2021-08-01 15:14:42 +02:00
Ted John 77a46a3d34
Another money64 fix 2021-08-01 15:14:42 +02:00
Ted John 407fafbced
Fix more money64 issues 2021-08-01 15:14:42 +02:00
Ted John 70d9c1438e
Change most things and formatting to money64 2021-08-01 15:14:42 +02:00
Kane 9ba19689d7
Fix #15148: Track Designs Manager delete confirmation window doesn't display properly (#15150)
* Fix #15148: Track Designs Manager delete confirmation window doesn't display properly

* Fix #15148: Track Designs Manager delete window doesn't display properly

* More descriptive name for window size constants.

* More constants usage, and fixed code style.

* Fix code formatting.
2021-08-01 11:55:44 +01:00
Kane bd8d3934e0
Close #15143: Add a shortcut key for Giant Screenshot 2021-08-01 09:20:34 +02:00
saad 2febffb721 Fix #14918 remove whitespace 2021-07-31 00:34:47 +04:00
ZehMatt 2a3b25af9a
Mark values constexpr in FileAudioSource 2021-07-30 21:31:10 +03:00
ZehMatt b111e104e3
Add missing return statement for the nullptr path 2021-07-30 21:31:10 +03:00
ZehMatt b992951bb2
Default initialize SortOrder in ListViewColumn 2021-07-30 21:31:10 +03:00
ZehMatt 0f74591f40
Use std::vector<> instead of malloc/free in CursorRepository.cpp 2021-07-30 21:31:10 +03:00
saad ab96ca8516 Fix #14918 rename eax and refactor while loop to avoid overflow 2021-07-30 19:34:42 +04:00
saad fd823c8acb Fix #14918 refactor while loop and int variable size 2021-07-30 18:38:42 +04:00
Michael Steenbeek 1ea9bbbb1b
Fix formatting 2021-07-29 13:32:48 +02:00
Kane dbdca55645
Fix #14316: Closing the Track Designs Manager window causes broken state
When exiting the Track Design Manager window the user was placed into the scenario editor in a broken state.
User is now returned to the main menu when the window is closed.
2021-07-29 12:44:24 +02:00
Michael Steenbeek ab18612882
Remove Music Acknowledgements window (#15116)
It was of limited use to us anyway since we didn’t license the music ourselves, but now the actual track names and composers are shown in the Object Selection, the window lost its last bit of usefulness.
2021-07-28 10:26:35 +02:00
Michael Steenbeek 9c2fb84a53
Invalidate screen when toggling transparent water flag
Pointed out here: https://github.com/OpenRCT2/OpenRCT2/issues/14753#issuecomment-849024680
2021-07-27 12:16:36 +02:00