Commit Graph

15190 Commits

Author SHA1 Message Date
Hielke Morsink 0fc4cad80f
Fix tile inspector errors for banner (#7640)
This is likely the least used page of the tile inspector, since two things have been broken for months apparently.

- The checkboxes for the blocked edges weren't being positioned correctly
- Rotating a banner that has either 0 or more than 1 edges blocked, the blocked edges weren't updated correctly
2018-06-09 17:16:04 +02:00
Aaron van Geffen e920871d67
Fix #7601: Always-researched items not rendered with inset. (#7638)
This re-introduces the use of buffers to work around colours not being set properly.

For clipping strings, we also now manually invoke `gfx_clip_string` instead of relying
on `gfx_draw_string_left_clipped` to do it for us. The latter resets the current font,
meaning it prevents the use of `MEDIUM_EXTRA_DARK` bases. This issue should be addressed
in a later commit.
2018-06-08 22:57:29 +02:00
Aaron van Geffen 98e8ef784e
Merge pull request #7639 from AaronVanGeffen/xcode-warnings
Enable more warnings in Xcode project
2018-06-08 22:51:47 +02:00
Aaron van Geffen ee4b8c11ae Prevent invoking a copy constructor in some ranged for loops. 2018-06-08 22:29:42 +02:00
Aaron van Geffen afba902b8b Enable more warnings in Xcode project. 2018-06-08 22:26:36 +02:00
Aaron van Geffen b2b997c328
Fix #6647: Prevent changelog window from painting lines out of view. (#7611) 2018-06-08 09:30:20 +02:00
Michał Janiszewski a4e803c03f
Update Windows linked libraries in CMakeLists.txt 2018-06-07 23:06:45 +02:00
Michał Janiszewski 1958266e11
Merge pull request #7635 from janisozaur/logical-op
Add -Wlogical-op
2018-06-06 23:04:39 +02:00
Michał Janiszewski bfffa50180 Provide static_assert checking for EAGAIN == EWOULDBLOCK
Allows turning on -Wlogical-op
2018-06-06 22:31:35 +02:00
Michał Janiszewski e0dd51cc5d Add -Wlogical-op compiler warning 2018-06-06 22:31:23 +02:00
Michał Janiszewski 320eee0d59
Fix -Wunreachable-code-break and add it to deafult warnings (#7634) 2018-06-06 22:30:21 +02:00
Michał Janiszewski cee74a06e1
Fix #7595: Docker image fails to build (#7633) 2018-06-06 22:23:01 +02:00
Michał Janiszewski dea1d88b0d
Merge pull request #7598 from Broxzier/refactor/more-unused-arguments
Mark unused arguments in the libopenrct2 project
2018-06-06 21:17:44 +02:00
Hielke Morsink 8c1ed596ce Apply review changes
- Print warning/error code in log message
- Remove attribute from Object::SetSourceGame which has a FIXME comment already instead
2018-06-06 21:03:11 +02:00
Hielke Morsink 204dd4439b Mark unused arguments in the libopenrct2 project
For dummy classes and functions with empty bodies I've only commented out the arguments, for all others I used C++17's [[maybe_unused]].
2018-06-06 21:03:11 +02:00
Michał Janiszewski 27b684e785
Merge pull request #7629 from Broxzier/missing-field-initializers
Fix missing field initializers
2018-06-06 20:28:41 +02:00
Hielke Morsink b9590f14b1
Merge pull request #7627 from Broxzier/scrolling-spin-uh-steppers
Allow scrolling on spinners/steppers
2018-06-06 20:00:38 +02:00
Ted John f94018ef37 Fix #7630: Server disconnects clients immediately
Clear the length of the sprite hash buffer. It was growing longer and longer every time the hash was calculated.
2018-06-05 23:19:31 +01:00
Hielke Morsink 184c46992c Fix remaining non-empty list initializers 2018-06-05 16:07:54 +02:00
Hielke Morsink de3cab59bb Fix warnings reported by travis 2018-06-05 16:07:54 +02:00
Hielke Morsink 88e9a37d78 Add warning to cmakelist 2018-06-05 15:03:20 +02:00
Hielke Morsink 832da93a87 Fix type error in openrct2-dll project 2018-06-05 14:38:14 +02:00
Hielke Morsink 8aa122f54e Use empty initializer lists in the openrct2ui project 2018-06-05 14:37:24 +02:00
OpenRCT2 git bot 5c7d477199 Merge Localisation/master into OpenRCT2/develop. 2018-06-05 04:00:36 +00:00
Hielke Morsink 9c8c2a2820 Missing field initializers part 2
This commit tackles the more difficult-to-fix warnings that -Wmissing-field-initializers reported. I've compares the new tables in TrackData with the old ones through a script to make sure they are in fact the same.
2018-06-05 00:18:07 +02:00
Hielke Morsink 5d0022a5cb Remove argument list from zero-initializers with zero/false/nullptr value 2018-06-04 19:50:46 +02:00
Michael Steenbeek a14d59028f
Modify some commands to use CoordsXY 2018-06-04 19:18:52 +02:00
Aaron van Geffen 5b6ae9d9cb Fix appearance of brake/booster speed widgets 2018-06-04 18:51:37 +02:00
Hielke Morsink cb1c55def5 Add extra checks to verify the widget belongs to a toolsize or stepper
It's possible that widgets are arranged in such a way that the roder of buttons matches the order of tool-size widgets or steppers. Now instead of just checking the types, also their content will be checked.
2018-06-04 15:49:05 +02:00
Hielke Morsink 32c4dab6c8 Move cut-away stepper logic to mousedown handler
This makes scrolling work for the stepper widget, and overrides behaviour for scrolling anywhere else in the window.
2018-06-04 13:41:27 +02:00
Michał Janiszewski 2edec95212
Merge pull request #7625 from janisozaur/headers-check-2
Verify compilability of headers on Travis v2
2018-06-04 12:21:54 +02:00
Michał Janiszewski 30e6cf1787 Remove OpenGLAPIProc.h from headers check target 2018-06-04 12:05:54 +02:00
Michał Janiszewski 798a4fe1a7 Add header verification for openrct2-ui 2018-06-04 12:05:54 +02:00
Michał Janiszewski 6307d3532b
Make headers-check an object library
This will skip linking step
2018-06-04 07:49:29 +02:00
Hielke Morsink 15c908e4af Remove no longer needed global widget indices 2018-06-04 01:11:00 +02:00
Hielke Morsink a82d6cb195 Allow scrolling up and down on steppers to change their values 2018-06-04 01:10:57 +02:00
Michał Janiszewski 32b419c868
Mark set_format_arg_body as maybe_unused 2018-06-03 23:20:58 +02:00
Michał Janiszewski 949321762b Verify compilability of headers on Travis v2
Using approach described in
https://github.com/OpenRCT2/OpenRCT2/pull/7369#issuecomment-393973857
with updates to ease readability and maintenance.

Submitted as different PR, to keep history of the old approach.
Supersedes #7369.
2018-06-03 22:56:34 +02:00
Michał Janiszewski 5126786842
Merge pull request #7624 from janisozaur/test-libzip
Updates for CMakeLists
2018-06-03 22:46:33 +02:00
Michał Janiszewski b43a9a6ccf Update SDL2 includes to non-system 2018-06-03 22:32:10 +02:00
Michał Janiszewski 93370ec956 Switch libzip to non-system includes
This should now work after many changes to upstream
2018-06-03 22:31:00 +02:00
Michał Janiszewski 7f285a0384
Merge pull request #7620 from janisozaur/remove-unused-func
Remove unused function
2018-06-03 20:10:54 +02:00
Michał Janiszewski 995d72f262 Remove function unused with HTTP disabled 2018-06-03 19:56:11 +02:00
Michał Janiszewski 6e72ac350f Remove function unused in no-network builds 2018-06-03 19:56:11 +02:00
Michał Janiszewski 7adc3d41a0 Restore the unused-function warning 2018-06-03 19:56:11 +02:00
Michał Janiszewski f0525d23ae Remove unused function
Last call was removed in 66a6aa95f6
2018-06-03 19:56:11 +02:00
Aaron van Geffen 35242f4815 Improve scrolling behaviour in object selection window (#7607) 2018-06-03 14:46:17 +02:00
Ted John 3b8c0703f4
Merge pull request #7609 from IntelOrca/refactor/openssl-usage
Refactor OpenSSL usage
2018-06-02 22:22:04 +01:00
Hielke Morsink 7aada25ed2 Clarify disabling of warnings for unused function (#7617) 2018-06-02 22:30:41 +02:00
Michał Janiszewski debb6cd46c Remove declarations of unimplemented functions (#7615) 2018-06-02 13:51:23 +02:00