mirrors
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Codechange: std::filesystem::rename does not need remove first. (#12484)

This commit is contained in:
Peter Nelson 2024-04-12 12:51:42 +01:00 committed by GitHub
parent bb9b8b90c7
commit 003906becb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/strgen/strgen.cpp
View File

@ -274,9 +274,6 @@ struct HeaderFileWriter : HeaderWriter, FileWriter {
std::filesystem::remove(this->path, error_code); // Just ignore the error
} else {
/* else rename tmp.xxx into filename */
# if defined(_WIN32)
std::filesystem::remove(this->real_path, error_code); // Just ignore the error, file probably doesn't exist
# endif
std::filesystem::rename(this->path, this->real_path, error_code);
if (error_code) FatalError("rename({}, {}) failed: {}", this->path, this->real_path, error_code.message());
}