Fix #11748: Incorrect clamping of negative service interval values (#11749)

This commit is contained in:
Loïc Guilloux 2024-01-10 16:23:36 +01:00 committed by GitHub
parent 86b046cd26
commit f7bd70baec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -1849,7 +1849,7 @@ void DeleteVehicleOrders(Vehicle *v, bool keep_orderlist, bool reset_order_indic
* @param interval proposed service interval * @param interval proposed service interval
* @return Clamped service interval * @return Clamped service interval
*/ */
uint16_t GetServiceIntervalClamped(uint interval, bool ispercent) uint16_t GetServiceIntervalClamped(int interval, bool ispercent)
{ {
return ispercent ? Clamp(interval, MIN_SERVINT_PERCENT, MAX_SERVINT_PERCENT) : Clamp(interval, MIN_SERVINT_DAYS, MAX_SERVINT_DAYS); return ispercent ? Clamp(interval, MIN_SERVINT_PERCENT, MAX_SERVINT_PERCENT) : Clamp(interval, MIN_SERVINT_DAYS, MAX_SERVINT_DAYS);
} }

View File

@ -37,6 +37,6 @@ static const uint DEF_SERVINT_PERCENT = 50;
static const uint MIN_SERVINT_PERCENT = 5; static const uint MIN_SERVINT_PERCENT = 5;
static const uint MAX_SERVINT_PERCENT = 90; static const uint MAX_SERVINT_PERCENT = 90;
uint16_t GetServiceIntervalClamped(uint interval, bool ispercent); uint16_t GetServiceIntervalClamped(int interval, bool ispercent);
#endif /* ORDER_FUNC_H */ #endif /* ORDER_FUNC_H */