Commit Graph

113 Commits

Author SHA1 Message Date
Olivier Mehani ada3160e9c snmp__if_combined: use instance name in graph titles
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-03-08 21:34:55 +11:00
Olivier Mehani b14e2347f4 snmp__if_combined: add env.stackedMax to work around sum spikes
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-01-18 22:35:54 +11:00
Olivier Mehani baf24f9c94 snmp__if_combined: don't set max speed if reported as 0
Some SNMP implementations actively report the interface speed as 0 (e.g., when disconnected). This led the plugin to report both min and max to be 0, which later confuses RRDTool, with errors such as

    [ERROR] Unable to create '/var/lib/munin/example.net/192.2.0.1-snmp_if_combined_vlan-37-send-d.rrd': failed to parse data source 600:0:0: min must be less than max in DS definition

when trying to creates the RRDs. Ultimately, this would prevent the graph creation from suceeding with errors such as

    [ERROR] In RRD: Error updating /var/lib/munin/example.net/192.2.0.1-snmp_if_combined_vlan-37-send-d.rrd: opening '/var/lib/munin/example.net/192.2.0.1-snmp_if_combined_vlan-37-send-d.rrd': No such file or directory

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-01-18 22:35:54 +11:00
Olivier Mehani 4262dc8564 snmp__if_combined: add support for multiple instances
This allows to split the data into smaller groups, e.g., per ifType.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2022-01-18 22:35:53 +11:00
Olivier Mehani ecb1d34814 [snmp__if_combined] Reindent 2021-07-20 11:08:49 +10:00
Olivier Mehani 6ac458ace1 [snmp__if_combined] Add support for stacked series in root graph
From a summary comment in the code:

    If a stacked graph is requested, plot the total. Rather than
    aggregating them with CDEFs of SUMs, we sum them in the script, which
    allows us to create real series than can be easily borrowed by other
    loaning graphs.

Those series are recv_bits and send_bits.

There are longstanding bugs with them (dating back to snmp__if). This
has been documented, as well as some potential ad hoc fixes for the
data.

Some outdated bug were also removed from the doc.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 11:08:49 +10:00
Olivier Mehani 61473dfdb0 [snmp__if_combined] fix error value
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani 57965df514 [snmp__if_combined] Fix issue with extrainfo
It was not collected / shown in the right spot, resulting in incorrect
information being shown.

Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani 6bb4a57983 [snmp__if_combined] Fix All interfaces titles so they are better grouped in category views
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:11 +10:00
Olivier Mehani 2f2ed4e41a [snmp__if_combined] use snmp v2 description for root traffic graph
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
2021-07-20 08:29:10 +10:00
Lars Kruse 3a2f2ec7ec Plugin snmp__airport: port to python3 2020-10-28 21:22:12 +01:00
Lars Kruse 09b88141b3 Improve documantion of many plugins
Specifically the configuration examples are now indented properly.
2020-10-24 17:29:08 +02:00
Lars Kruse a9c0e2bb59 Unify spelling of author "Dagfinn Ilmari Mannsåker"
Previously some occurrences lacked the special character.
2020-10-19 21:04:03 +02:00
Lars Kruse 809639ab65 Ruby plugins: apply code changes as suggested by "rubocop --auto-correct" 2020-08-25 17:44:17 +02:00
Lars Kruse b0b39b018e Ruby plugins: apply style changes as suggested by "rubocop --fix-layout" 2020-08-25 17:44:17 +02:00
Lars Kruse 8713eb3722 Fix spelling mistakes in comments and descriptions
Thanks, codespell!
2020-03-26 04:23:21 +01:00
Lars Kruse ba732fd7ec Plugin snmp__airport: fix code style issues reported by flake8 2019-08-14 00:09:29 +02:00
Lars Kruse 2ec4e4c1f7 Improve incorrect or unspecific output for "autoconf"
Some plugins emit wrongly formatted "no" messages or lack the "yes"
message on success.
2018-09-16 15:13:38 +02:00
Lars Kruse e4cd049b01 Fix trivial instances of wrong autoconf exitcodes 2018-09-16 04:03:31 +02:00
Lars Kruse 17f784270a Whitespace cleanup
* remove trailing whitespace
* remove empty lines at the end of files
2018-08-02 02:33:25 +02:00
Lars Kruse 33e95e6ff9 Review and unify category assignments of plugins 2018-08-01 23:56:56 +02:00
Lars Kruse 7a37bfb1d8 Plugins: unify shebang for ruby scripts 2018-07-11 19:35:32 +02:00
Lars Kruse 4e47cb5d85 plugin categories: other -> sensors 2018-03-28 04:29:25 +02:00
Lars Kruse 989f09e66c rename plugin example graphs for plugin gallery visualization
Some example graphs did not follow the naming convention required by the
plugin gallery.
2018-03-24 04:03:08 +01:00
Lars Kruse 7c62b9b6de added executable permission for multiple plugins 2018-03-09 00:18:30 +01:00
Kai 56bcc8cda1 Add files via upload 2017-08-24 21:59:35 -04:00
klemens 8589c6df43 spelling fixes (2nd try) 2017-04-17 22:43:38 +02:00
dipohl 7fdb4741fe Plugin-Gallery: Get better 2nd level headings
Review of category "system"
2017-02-24 23:54:53 +01:00
dipohl e777037d06 Plugin-Gallery: Get better 2nd level headings
Review of category processes, system, snmp
2017-02-24 19:50:15 +01:00
dipohl 4b400a7320 Plugin-Gallery: Get better 2nd level headings
amule -> filetransfer (amule)
torrent -> filetransfer (rtorrent)
2017-02-24 18:29:14 +01:00
dipohl 95de964ec9 Plugin-Gallery: Get better 2nd level headings
sensors, weather, snmp
2017-02-24 17:30:35 +01:00
dipohl 37d658526b Plugin-Gallery: move to more specific categories 2017-02-24 16:13:05 +01:00
dipohl f769371079 Plugin-Gallery: Better 2nd level headings 2017-02-24 16:11:20 +01:00
dipohl ae4e85ab60 Plugin-Gallery: Better 2nd level headings 2017-02-24 03:13:08 +01:00
dipohl 63351ab535 Reduce number of categories
riak -> other (riak)
smf -> forum (smf)
reddit -> other (reddit)
sge -> htc (sge)
netscaler -> loadbalancer (netscaler)
nutcracker -> other (twemproxy)
requesttracker -> other (requesttracker)
passenger -> webserver (passenger)
gearman -> other (gearman)
2017-02-23 23:12:19 +01:00
dipohl e08a6448ce Category Tree: Reduce number of categories
sphinx -> search
unicorn -> webserver
moved some plugins to other dirs to get better seconde level heading
2017-02-23 02:22:08 +01:00
dipohl 444c7939de Category Tree: Reduce number of categories
tomcat -> webserver (tomcat)
radiator -> auth (radiator)
ups -> sensors (ups)
2017-02-23 01:51:44 +01:00
dipohl f523f095f9 Category Tree: Reduce number of categories
netapp -> san
2017-02-22 19:44:59 +01:00
dipohl 7042351e74 Category Tree: Reduce number of categories
and mv some from "others" to specific category
2017-02-22 19:09:05 +01:00
dipohl 8af93fce06 Category Tree: Reduce number of categories
Don't use variable to set category, plugin gallery build script needs the pure string..
2017-02-21 00:41:40 +01:00
dipohl 8172d38c2d Category Tree: Reduce number of categories 2017-02-20 16:42:38 +01:00
Lionel Sausin e607ac7708 Correctly detect the Routing Engines on Virtual Chassis
The current recommended firmware for EX3400 (JUNOS 15.1X53-D55.5) lists the routing engines as 'Routing engine <member id>' when the switches are stacked in a Virtual Chassis.
The former code failed to detect these strings, so I relaxed it a bit.
This matches the documentation found here: https://kb.juniper.net/InfoCenter/index?page=content&id=KB17526&actp=search
2017-02-09 16:01:20 +01:00
jmdevince 4fac7e61b8 Plugin monitoring CPU on Cisco SB Devices 2015-09-02 16:00:24 -05:00
Thomas A c40eabee7e Add snmp__synology_* plugins
Synology specific snmp plugins for:
- System temperature
- HDD temperature
- UPS Charge & Load
2015-06-18 19:37:42 +02:00
Stig Sandbeck Mathisen a70f7e48b2 Merge pull request #553 from vlajos/typofixes-vlajos-20141204
typofixes - https://github.com/vlajos/misspell_fixer
2015-03-02 23:11:18 +01:00
Veres Lajos fba800ae52 typofixes - https://github.com/vlajos/misspell_fixer
Suspicious sections:
plugins/mail/postfix_mail_stats		recieved.label
plugins/nginx/nginx_vhost_traffic
2015-03-02 11:51:38 +00:00
Steve Schnepp eeaf47c6b2 Merge pull request #584 from rrzefox/updatesnmpupsplugin
overhaul of snmp__ups_ plugin.
2015-02-27 17:49:50 +01:00
Michael 'PoempelFox' Meier 94438298d1 new plugin for monitoring Knuerr RMS Compact II rack monitoring units 2015-02-13 17:18:36 +01:00
Michael 'PoempelFox' Meier 7a306e6223 overhaul of snmp__ups_ plugin.
Changes:
- More queries supported (inputpower, batterycurrent, batteryruntime (how long
  have we been running on battery), batterypercent (percent remaining),
  inputlinebads (how often was input bad))
- fix a few wrong units (e.g. current is measured in amp, not in watt)
- some UPSes violate RFC 1628 by not returning the number of input-/
  output-lines they have. In this case assume 3 lines instead of 0
  (and just printing nothing at all).
- Make mode parameters all lowercase instead of camelcase - camelcase
  just looks retarded in the plugin-symlink-names.
- some more smaller fixes
2015-02-13 16:58:26 +01:00
Stig Sandbeck Mathisen fefcad986e Work around false positive in checkbashisms
- Nothing wrong with the plugin, but checkbashisms triggers on the
   presence of a variable called $HOSTNAME

 - Changing the variable name in the plugin is the "easy way out".
2014-10-05 15:49:54 +02:00