Fix some JS console errors

This commit is contained in:
Deluan 2020-11-12 20:51:26 -05:00
parent 25db696c06
commit 08399c4854
4 changed files with 23 additions and 9 deletions

View File

@ -17,7 +17,14 @@ import { formatBytes } from '../utils'
import { useMediaQuery } from '@material-ui/core'
import config from '../config'
const AlbumActions = ({ className, ids, data, record, ...rest }) => {
const AlbumActions = ({
className,
ids,
data,
record,
permanentFilter,
...rest
}) => {
const dispatch = useDispatch()
const translate = useTranslate()
const isDesktop = useMediaQuery((theme) => theme.breakpoints.up('md'))

View File

@ -32,5 +32,4 @@ export const AddToPlaylistButton = ({ resource, selectedIds, className }) => {
AddToPlaylistButton.propTypes = {
resource: PropTypes.string.isRequired,
selectedIds: PropTypes.arrayOf(PropTypes.string).isRequired,
className: PropTypes.object,
}

View File

@ -58,5 +58,4 @@ BatchPlayButton.propTypes = {
action: PropTypes.func.isRequired,
label: PropTypes.string.isRequired,
icon: PropTypes.object.isRequired,
className: PropTypes.object,
}

View File

@ -1,4 +1,10 @@
import React, { useState, isValidElement, cloneElement, useMemo } from 'react'
import React, {
useState,
isValidElement,
cloneElement,
useMemo,
useCallback,
} from 'react'
import { useDispatch } from 'react-redux'
import { Datagrid, DatagridBody, DatagridRow } from 'react-admin'
import { TableCell, TableRow, Typography } from '@material-ui/core'
@ -106,7 +112,7 @@ export const SongDatagridRow = ({
SongDatagridRow.propTypes = {
record: PropTypes.object,
children: PropTypes.node,
multiDisc: PropTypes.bool,
firstTracks: PropTypes.instanceOf(Set),
contextAlwaysVisible: PropTypes.bool,
onClickDiscSubtitle: PropTypes.func,
}
@ -123,10 +129,13 @@ export const SongDatagrid = ({
const dispatch = useDispatch()
const { ids, data } = rest
const playDisc = (discNumber) => {
const idsToPlay = ids.filter((id) => data[id].discNumber === discNumber)
dispatch(playTracks(data, idsToPlay))
}
const playDisc = useCallback(
(discNumber) => {
const idsToPlay = ids.filter((id) => data[id].discNumber === discNumber)
dispatch(playTracks(data, idsToPlay))
},
[dispatch, data, ids]
)
const firstTracks = useMemo(() => {
const set = new Set(