Use `ffmpeg` extractor by default on Windows

This is to avoid issue with unicode chars in filenames. See #810

conf/configuration.go

@@ -214,7 +214,7 @@ func init() {
 	viper.SetDefault("reverseproxyuserheader", "Remote-User")
 	viper.SetDefault("reverseproxywhitelist", "")
 
-	viper.SetDefault("scanner.extractor", "taglib")
+	viper.SetDefault("scanner.extractor", DefaultScannerExtractor)
 	viper.SetDefault("scanner.genreseparators", ";/,")
 
 	viper.SetDefault("agents", "lastfm,spotify")

conf/defaults.go

@@ -0,0 +1,5 @@
+// +build !windows
+
+package conf
+
+const DefaultScannerExtractor = "taglib"

conf/defaults_win.go

@@ -0,0 +1,5 @@
+// +build windows
+
+package conf
+
+const DefaultScannerExtractor = "ffmpeg"

scanner/metadata/metadata.go

@@ -23,20 +23,20 @@ type Parser interface {
 	Parse(files ...string) (map[string]map[string][]string, error)
 }
 
-func Extract(files ...string) (map[string]*Tags, error) {
-	var e Parser
+var parsers = map[string]Parser{
+	"ffmpeg": &ffmpeg.Parser{},
+	"taglib": &taglib.Parser{},
+}
 
-	switch conf.Server.Scanner.Extractor {
-	case "taglib":
-		e = &taglib.Parser{}
-	case "ffmpeg":
-		e = &ffmpeg.Parser{}
-	default:
-		log.Warn("Invalid 'Scanner.Extractor' option. Using default 'taglib'", "requested", conf.Server.Scanner.Extractor,
-			"validOptions", "ffmpeg,taglib")
-		e = &taglib.Parser{}
+func Extract(files ...string) (map[string]*Tags, error) {
+	p, ok := parsers[conf.Server.Scanner.Extractor]
+	if !ok {
+		log.Warn("Invalid 'Scanner.Extractor' option. Using default", "requested", conf.Server.Scanner.Extractor,
+			"validOptions", "ffmpeg,taglib", "default", conf.DefaultScannerExtractor)
+		p = parsers[conf.DefaultScannerExtractor]
 	}
-	extractedTags, err := e.Parse(files...)
+
+	extractedTags, err := p.Parse(files...)
 	if err != nil {
 		return nil, err
 	}