mirrors
/
navidrome
mirror of https://github.com/navidrome/navidrome.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix XML marshaling of OpenSubsonic structured lyrics (#3041)

This commit is contained in:
Drew Weymouth 2024-05-22 09:15:14 -07:00 committed by GitHub
parent f88d3f82da
commit b6fce0e686
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
server/subsonic/responses/.snapshots/Responses LyricsList with data should match .XML
View File

@ -1,20 +1,12 @@
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
<lyricsList>
<structuredLyrics displayArtist="Rick Astley" displayTitle="Never Gonna Give You Up" lang="eng" offset="100" synced="true">
<line start="18800">
<value>We&#39;re no strangers to love</value>
</line>
<line start="22801">
<value>You know the rules and so do I</value>
</line>
<line start="18800">We&#39;re no strangers to love</line>
<line start="22801">You know the rules and so do I</line>
</structuredLyrics>
<structuredLyrics displayArtist="Rick Astley" displayTitle="Never Gonna Give You Up" lang="xxx" offset="100" synced="false">
<line>
<value>We&#39;re no strangers to love</value>
</line>
<line>
<value>You know the rules and so do I</value>
</line>
<line>We&#39;re no strangers to love</line>
<line>You know the rules and so do I</line>
</structuredLyrics>
</lyricsList>
</subsonic-response>

2
server/subsonic/responses/responses.go
View File

@ -458,7 +458,7 @@ type JukeboxPlaylist struct {
type Line struct {
Start *int64 `xml:"start,attr,omitempty" json:"start,omitempty"`
Value string `xml:"value" json:"value"`
Value string `xml:",chardata" json:"value"`
}
type StructuredLyric struct {