mirrors
/
navidrome
mirror of https://github.com/navidrome/navidrome.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Expose OpenSubsonic release date for album (#2906) 

* [enhancement]: OS expose release date for album, make original optional

* not optional

* remove omitempty
This commit is contained in:
Kendall Garner 2024-04-03 11:30:01 +00:00 committed by GitHub
parent e81bf5125f
commit f12dfb485a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
server/subsonic/helpers.go
View File

@ -321,6 +321,7 @@ func buildAlbumID3(ctx context.Context, album model.Album) responses.AlbumID3 {
dir.IsCompilation = album.Compilation
dir.SortName = album.SortAlbumName
dir.OriginalReleaseDate = toItemDate(album.OriginalDate)
dir.ReleaseDate = toItemDate(album.ReleaseDate)
return dir
}

5
server/subsonic/responses/.snapshots/Responses AlbumWithSongsID3 with data should match .JSON
View File

@ -36,6 +36,11 @@
"month": 2,
"day": 4
},
"releaseDate": {
"year": 2000,
"month": 5,
"day": 10
},
"song": [
{
"id": "1",

1
server/subsonic/responses/.snapshots/Responses AlbumWithSongsID3 with data should match .XML
View File

@ -5,6 +5,7 @@
<discTitles disc="1" title="disc 1"></discTitles>
<discTitles disc="2" title="disc 2"></discTitles>
<originalReleaseDate year="1994" month="2" day="4"></originalReleaseDate>
<releaseDate year="2000" month="5" day="10"></releaseDate>
<song id="1" isDir="true" title="title" album="album" artist="artist" track="1" year="1985" genre="Rock" coverArt="1" size="8421341" contentType="audio/flac" suffix="flac" starred="2016-03-02T20:30:00Z" transcodedContentType="audio/mpeg" transcodedSuffix="mp3" duration="146" bitRate="320" isVideo="false" bpm="127" comment="a comment" sortName="sorted song" mediaType="song" musicBrainzId="4321">
<genres name="rock"></genres>
<genres name="progressive"></genres>

3
server/subsonic/responses/.snapshots/Responses AlbumWithSongsID3 without data should match .JSON
View File

@ -13,6 +13,7 @@
"isCompilation": false,
"sortName": "",
"discTitles": [],
"originalReleaseDate": {}
"originalReleaseDate": {},
"releaseDate": {}
}
}

1
server/subsonic/responses/.snapshots/Responses AlbumWithSongsID3 without data should match .XML
View File

@ -1,5 +1,6 @@
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.8.0" type="navidrome" serverVersion="v0.0.0" openSubsonic="true">
<album id="" name="" userRating="0" musicBrainzId="" isCompilation="false" sortName="">
<originalReleaseDate></originalReleaseDate>
<releaseDate></releaseDate>
</album>
</subsonic-response>

1
server/subsonic/responses/responses.go
View File

@ -232,6 +232,7 @@ type AlbumID3 struct {
SortName string `xml:"sortName,attr" json:"sortName"`
DiscTitles DiscTitles `xml:"discTitles" json:"discTitles"`
OriginalReleaseDate ItemDate `xml:"originalReleaseDate" json:"originalReleaseDate"`
ReleaseDate ItemDate `xml:"releaseDate" json:"releaseDate"`
}
type ArtistWithAlbumsID3 struct {

1
server/subsonic/responses/responses_test.go
View File

@ -178,6 +178,7 @@ var _ = Describe("Responses", func() {
MusicBrainzId: "1234", IsCompilation: true, SortName: "sorted album",
DiscTitles: DiscTitles{{Disc: 1, Title: "disc 1"}, {Disc: 2, Title: "disc 2"}},
OriginalReleaseDate: ItemDate{Year: 1994, Month: 2, Day: 4},
ReleaseDate: ItemDate{Year: 2000, Month: 5, Day: 10},
}
t := time.Date(2016, 03, 2, 20, 30, 0, 0, time.UTC)
songs := []Child{{