Commit Graph

936 Commits

Author SHA1 Message Date
Deluan 5dce499d6d Fix/Optimized Playlist tracks deletion 2021-10-26 14:05:28 -04:00
Deluan fbd87ba577 Fix console error "Cannot convert undefined or null to object PlaylistsSubMenu" 2021-10-26 14:05:05 -04:00
Steve Richter 85185e3b98
Misc small changes (#1433)
* Fix React key warning in HelpDialog

* Change "lyric" to "lyrics" in en.json
2021-10-26 08:57:20 -04:00
Deluan ed1ca65ad5 Show hotkeys as chips, for easier reading 2021-10-25 11:14:43 -04:00
Deluan 31c598de07 Fix drag-n-drop from a playlist, also fix useDrag memoization 2021-10-23 20:25:28 -04:00
Deluan 2e2a647e67 Make SmartPlaylists read-only 2021-10-23 20:25:28 -04:00
Deluan 1494be9aaa Add playCount and playDate columns to album songs list 2021-10-23 20:25:28 -04:00
Deluan d0ce030386 Add PlayCount and PlayDate columns to PlaylistSongs 2021-10-23 20:25:28 -04:00
Deluan 2a756eab88 Show external links on all resolutions but mobile 2021-10-21 10:30:53 -04:00
Deluan 104679ca6e Guard against record being `undefined`. Fix error `Cannot read properties of undefined (reading 'id')` 2021-10-19 20:22:56 -04:00
Deluan 3214783ce9 Remove double-retching playlist's tracks 2021-10-19 12:54:21 -04:00
Chirag Lulla 34b01c2cbf
Display lyrics on UI if synced lyrics present in metadata (#1406)
Signed-off-by: Chirag Lulla <lullachirag239@gmail.com>
2021-10-19 10:21:20 -04:00
Deluan b7fedddfd8 Guard against record being `undefined`. Fix error `Cannot read properties of undefined (reading 'albumId')` 2021-10-16 20:29:31 -04:00
Dnouv 1d742cf8c7
Artist page improvements (#1391)
* Seperate mobile desktop components

* Fix err

* Rename classes and fix some styles

* Add lastFM button and remove console log

* Add Mbiz Icon

* render bio as dangerouslySetInnerHTML and remove unused css classes

* Add Fav and Stars

* Remove unstandardised class selector

* Remove ext link from m view

* Fix naming and simplify rounded styling

* Refactor ArtistShow:

- Extracted DesktopArtistDetails to its own file
- Removed album count as it was incorrect, it is not considering compilations
- Show bio and image from Native API, if it is available, before calling `getArtistInfo`

Co-authored-by: Deluan <deluan@navidrome.org>
2021-10-15 21:02:11 -04:00
certuna ba0ee6aba4
Rename manifest.json to manifest.webmanifest (#1399)
* Rename manifest.json to manifest.webmanifest

browser consoles keep complaining that the manifest doesn't have the `.webmanifest` extension.

* FIx manifest.webmanifest references

Co-authored-by: Deluan <deluan@navidrome.org>
2021-10-12 20:06:09 -04:00
Deluan ee8943f338 Fix semantic classes for currently playing song
Fix #1364
2021-10-07 19:49:27 -04:00
Serguey Parkhomovsky 86a87b4bb1
Fix default volume (#1395)
With the update in #1378, the default volume is now erroneously set to 25% instead of 50%. Remove the Math.pow and set it to 50% instead.
2021-10-07 17:21:08 -04:00
Deluan 152836a01c Bump @testing-library/react from 12.1.1 to 12.1.2 in /ui 2021-10-04 17:30:01 -04:00
Deluan 6139338e80 Bump react-icons from 4.2.0 to 4.3.1 in /ui 2021-10-04 17:29:27 -04:00
Dnouv a6311259fd
Fix layout error in ArtistShow (#1387) 2021-10-04 17:14:38 -04:00
Deluan e673360087 Limit number of playlists displayed in the sidebar, to avoid UI freezes 2021-10-02 21:39:33 -04:00
Deluan 9c29ee3651 Check permissions before adding songs to playlists 2021-10-02 13:23:17 -04:00
Deluan 6c3e45de41 Add songs to playlists with drag and drop 2021-10-02 13:14:33 -04:00
dependabot[bot] 0cbba80284
Bump react-router-dom from 5.2.0 to 5.3.0 in /ui (#1330)
Bumps [react-router-dom](https://github.com/ReactTraining/react-router) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/ReactTraining/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ReactTraining/react-router/compare/v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: react-router-dom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-01 10:34:37 -04:00
Deluan f9d910473f Bump react-admin to 3.18.3 2021-10-01 09:45:28 -04:00
Igor Rzegocki be3a6dc7a3
Use local copy of workbox service worker scripts (#1358)
* Use local copy of workbox service worker scripts

* Refactor workbox integration:

- Only add prod js, without maps. Reduces the size from 170k to 24k
- Removed it from build. As it is small now, we can add it to source, and have a script to just update it whenever it is required
- Fixed relative paths in navidrome-service-worker.js, should now work with BaseUrl != ''

Co-authored-by: Deluan <deluan@navidrome.org>
2021-10-01 09:14:15 -04:00
Deluan b1e7760996 Preload next song 2021-10-01 08:43:59 -04:00
Serguey Parkhomovsky 24fef584ad
Bump react-jinke-music-player from 4.24.0 to 4.24.2 (#1378)
This should fix #1367.
2021-10-01 08:42:02 -04:00
Deluan 694056010c Bump @testing-library/react from 12.1.0 to 12.1.1 in /ui 2021-09-27 13:27:59 -04:00
Deluan 4fda895a64 Bump blueimp-md5 from 2.18.0 to 2.19.0 in /ui 2021-09-27 13:26:31 -04:00
Deluan f664af5559 Bump react-admin from 3.18.1 to 3.18.2 in /ui 2021-09-27 13:26:31 -04:00
Deluan c6868ff8a0 Don't show Artist Page for "Various Artists" 2021-09-27 11:52:23 -04:00
Deluan 0b65a4e34e Fix comment word wrapping 2021-09-27 09:48:31 -04:00
Deluan 24872e6c2a Fix biography word wrapping and requests for `undefined` resource 2021-09-27 09:47:16 -04:00
Deluan b4e5c662dc Fix JS console warning 2021-09-26 17:36:30 -04:00
Dnouv 482c2dec0c
Artist Detail Page (first cut) (#1287)
* Configure fetching from API and route

* pretty

* Remove errors

* Remove errors

* Remove errors

* Complete page for Desktop view

* Fix error

* Add xs Artist page

* Remove unused import

* Add styles for theme

* Change route path

* Remove artId useEffect array

* Remove array

* Fix cover load err

* Add redirect on err

* Remove route

* What's in a name? consistency :)

* Fix err

* Fix UI changes

* Fetch album from resource

* Renaming done

* Review changes

* Some touch-up

* Small refactor, to make naming and structure more consistent with AlbumShow

* Make artist's album list similar to original implementation

* Reuse AlbumGridView, to avoid duplication

* Add feature flag to enable new Artist Page, default false

* Better biography styling. Small refactorings,

* Don't encode quotes and other symbols

* Moved AlbumShow to correct folder

Co-authored-by: Deluan <deluan@navidrome.org>
2021-09-26 15:32:40 -04:00
Samarjeet 0c0bd2967d
Replace expanded with a dialog (#1258)
* Replace expanded with a dialog

* Change `info` label to "Get Info"

* Rename things for consistency

Co-authored-by: Deluan <deluan@navidrome.org>
2021-09-20 20:30:43 -04:00
Miguel A. Arroyo e12a14a87d feat: Adds Audio Channel Metadata - #1036 2021-09-20 19:33:50 -04:00
Deluan 0079a9b938 Close Sidebar when going to Playlists list 2021-09-20 19:00:37 -04:00
Deluan 892c2bfd58 Revert "Disable mini-player (bubble) dragging. Should fix #1217"
This reverts commit abf6318a8b.
2021-09-20 18:24:18 -04:00
dependabot[bot] 7a15ed0740 Bump prettier from 2.4.0 to 2.4.1 in /ui
Bumps [prettier](https://github.com/prettier/prettier) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.4.0...2.4.1)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-09-20 17:45:50 -04:00
dependabot[bot] f2ed3f2d86
Bump prettier from 2.3.2 to 2.4.0 in /ui (#1341)
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.2 to 2.4.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.3.2...2.4.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-13 16:12:29 -04:00
dependabot[bot] b23ab1ccec
Bump @testing-library/react from 12.0.0 to 12.1.0 in /ui (#1342)
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 12.0.0 to 12.1.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/react-testing-library/compare/v12.0.0...v12.1.0)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-13 16:10:07 -04:00
Deluan abf6318a8b Disable mini-player (bubble) dragging. Should fix #1217 2021-09-13 11:17:06 -04:00
Deluan b55f3a6946 Add paddingBottom to the whole sidebar menu, to avoid playlists to be covered by the player 2021-09-12 21:24:07 -04:00
Deluan Quintão 79363d6c07
Move Playlists to the sidebar menu (#1339)
* Show playlists in sidebar menu

* Fix menu

* Refresh playlist submenu when adding new playlist

* Group shared playlists below user's playlists

* Fix text overflow in menu options

* Add button in playlist menu to go to Playlists list

* Add config option `DevSidebarPlaylists` to enable this feature (default false)
2021-09-11 13:11:15 -04:00
Deluan a7017e4bb0 Fix JS console warning 2021-09-10 18:04:38 -04:00
Deluan dc0ec32dbf Fix menu items highlight 2021-09-10 16:17:08 -04:00
Salman Inayat 06b1a1a25c
Album size overflow fixed (#1071)
* Added back button

* Added back button

* Added back button

* Fixed Album size overflow

* Fixed Album size overflow

* Fixed album size overflowing

* Fixed album size overflowing

* Fixed album size overflowing

* Fixed album size overflow on small screen

* Changes reverted in PlayerEdit.js

* prettier formatting issue resolved

Co-authored-by: Deluan <deluan@navidrome.org>
2021-09-09 11:56:48 -04:00
Deluan 6ac2fefaf3 Make AppBar stick on scroll 2021-09-09 11:21:16 -04:00
Samarjeet 2e921cd793
Fix sidebar scroll height (#1338)
* Fix sidebar scroll height

* Prettier

Co-authored-by: Deluan <deluan@navidrome.org>
2021-09-09 09:33:38 -04:00
Deluan 94083f85d2 Bump @testing-library/react-hooks version 2021-09-09 00:16:44 -04:00
Deluan f0ef5187b2 Bump react-redux version 2021-09-09 00:16:13 -04:00
Deluan 8444c28bed Upgrade react-admin to 3.18.1
This makes the sidebar fixed when users scroll vertically. This supersedes #1024, even though it also hides the hamburger menu...
2021-09-08 22:50:03 -04:00
Tucker Kern fb11080545
Improve performance of placeholder images (#1325)
* Don't include updatedAt field when fetching album art placeholder. This will allow browers to cache the place holder

* Apply resizing to placeholder image

* Fix issues discovered by CI linter and prettier

* Updates from PR review
2021-09-06 22:34:37 -04:00
Deluan cf042ed83d Fix random volume changes 2021-08-22 12:18:26 -04:00
Tucker Kern aa72d3d41b
Add missing song information to players and apply EnableCoverAnimation to mobile player. (#1268)
* Disable mobile player cover animation when EnableCoverAnimation is set to false. Also increase cover art size and remove rounded borders.

* Display song album and year in mobile player view

* Remove default singer element from mobile player and reduce vertical white space

* Only add song year if it exists

* Add song year to desktop player when present

* Increase non-animated cover size to 85% and set a limit on the width of 600px.

* Explain what what the styles impact

* Remove unused style for songArtist

* Apply prettier

* Adjust player styles to handle nonsquare album art better. Should probably push this upstream too

* Also fix desktop player's handling of non square cover art.
2021-08-17 13:57:48 -04:00
dependabot[bot] 0a5f966047 Bump redux from 4.1.0 to 4.1.1 in /ui
Bumps [redux](https://github.com/reduxjs/redux) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/reduxjs/redux/releases)
- [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reduxjs/redux/compare/v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: redux
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-13 20:11:05 -04:00
Deluan db4165f27c Bum react-admin to 3.17.2. Fix SearchInput border 2021-08-13 19:45:18 -04:00
Deluan a8cf887e87 Adjust icon size 2021-08-03 22:01:57 -04:00
Deluan Quintão 63000ab5ae Update en.json (POEditor.com) 2021-08-03 21:41:32 -04:00
Deluan bcafe88ef9 Don't autoplay when reloading play queue from Redux store 2021-08-01 19:49:17 -04:00
Deluan c0fc36da63 Make album genres clickable 2021-07-27 13:22:35 -04:00
Deluan e68b22ea5d Don't send invalid scrobbles when clearing the player's queue 2021-07-26 16:50:50 -04:00
Sitansh Rajput fb4eefced5
"Add to Playlist" on AlbumList actions (#1257)
* added a dependency npm was complaining about

added playlist to album actions

* removed chokidar dependency

Co-authored-by: Skrtansh Rajput <srajput@alienvault.com>
2021-07-26 15:00:38 -04:00
Deluan 615cac2ec4 Extract ExternalLinks into its own component 2021-07-26 13:25:31 -04:00
dependabot[bot] 72f9e3e80a Bump @testing-library/user-event from 13.2.0 to 13.2.1 in /ui
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.2.0 to 13.2.1.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.2.0...v13.2.1)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-26 13:25:19 -04:00
Deluan 763bcafdac Use Tooltip in links to external sites 2021-07-24 19:52:15 -04:00
Deluan 7bd506accc Retrieve all options for Genre filters 2021-07-24 16:00:27 -04:00
Deluan a89bdfbb8d Fix build 2021-07-20 20:22:15 -04:00
Deluan 7540881695 Small refactorings 2021-07-20 19:18:29 -04:00
Deluan 1471e1240d Show songs' genres as text instead of Chips 2021-07-20 17:45:08 -04:00
Deluan 58ee4c60ca Add Links to external sites 2021-07-20 17:45:08 -04:00
Deluan 054b5eafdb Add Genres as "Chips" in Album details and Song details 2021-07-20 17:45:08 -04:00
Deluan 20b7e5c49b Add Genre filters to UI 2021-07-20 17:45:08 -04:00
dependabot[bot] d886c63122
Bump react-image-lightbox from 5.1.1 to 5.1.4 in /ui (#1252)
Bumps [react-image-lightbox](https://github.com/frontend-collective/react-image-lightbox) from 5.1.1 to 5.1.4.
- [Release notes](https://github.com/frontend-collective/react-image-lightbox/releases)
- [Changelog](https://github.com/frontend-collective/react-image-lightbox/blob/master/CHANGELOG.md)
- [Commits](https://github.com/frontend-collective/react-image-lightbox/compare/v5.1.1...v5.1.4)

---
updated-dependencies:
- dependency-name: react-image-lightbox
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-19 13:20:44 -04:00
dependabot[bot] 5b828cd7ef
Bump @testing-library/user-event from 13.1.9 to 13.2.0 in /ui (#1253)
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.1.9 to 13.2.0.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.1.9...v13.2.0)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-19 13:20:28 -04:00
Deluan 97f87416a4 Bump @testing-library dependencies 2021-07-14 11:02:11 -04:00
Deluan 8396b51a9c Upgrade React-Admin to 3.17.0 2021-07-14 10:39:48 -04:00
Deluan 4a25fa0920 Make the default volume 50% (compensate for logarithmic volume).
Closes #1052
2021-07-14 09:58:50 -04:00
dependabot[bot] 8e71f308c2
Bump prettier from 2.3.1 to 2.3.2 in /ui (#1210)
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-09 21:29:51 -04:00
Deluan 53fe2e98c5 Remove `eject` script, hopefully it will never be used 2021-07-08 21:09:38 -04:00
Deluan b34d77f85a Don't show "playing/paused" icon on the first song when calling "Play Now" 2021-07-05 21:45:20 -04:00
Deluan 24d4c81b34 Change default volume to 50%
Should fix #1052
2021-07-04 21:36:41 -04:00
Deluan 189d0c0ab3 Restore volume when playing a song...
... or continuing to play a paused one
2021-07-04 21:36:41 -04:00
Deluan 1922eaaab2 Make cover rectangular in player when cover animation is disabled 2021-07-04 12:52:59 -04:00
Deluan 5d9bea5087 Fix Album grid responsiveness on small screens.
Potentially fixes #647
2021-07-04 12:09:30 -04:00
Deluan 69afb69959 Fix Disc context menu not visible in mobile 2021-07-04 11:44:41 -04:00
Deluan 27ba267b38 Fix play single song action 2021-07-03 22:29:59 -04:00
Deluan fa8b4d40b4 Fix arranging songs in PlayQueue 2021-07-03 21:34:24 -04:00
Deluan ace5c905eb Made the Player behaviour more consistent 2021-07-02 23:36:33 -04:00
certuna 77f6bc83ac
Update SongList.js (#1219)
Genre and Comments columns in Songs listview (hidden by default)
2021-07-02 10:18:45 -04:00
Deluan cfb113bd33 Disable Last.FM features based on `LastFM.Enabled` config option 2021-07-02 10:04:41 -04:00
Deluan 4ea0f235e1 Fix scrollbar colour for Dark/ExtraDark theme. Fixes #1216 2021-06-29 12:29:00 -04:00
Deluan fd82b8f2dc Default for `EnableCoverAnimation` in dev mode is true 2021-06-28 17:18:32 -04:00
Deluan a73f885afb Add option to disable album cover animation in the player. Closes #1185 2021-06-28 17:11:05 -04:00
Deluan 25f0e11562 Add 'AlbumArtist' column to SongList 2021-06-28 09:54:17 -04:00
Deluan 292cf99f49 Add 'Year' column to Album and Playlists song list 2021-06-28 09:45:30 -04:00
Deluan 26bcf0b877 Enable Last.fm scrobbling by default (still requires user's authorization) 2021-06-25 23:09:09 -04:00
Deluan a1551074bb Add a hacky way to style the react-player. 2021-06-25 18:19:57 -04:00