Commit Graph

24825 Commits

Author SHA1 Message Date
Michał Janiszewski 0871525850
Use precompiled headers for libopenrct2 with MSVC (#15997)
* Use precompiled headers for libopenrct2 with MSVC

* Exclude PCH from duktape

duktape needs all the warnings turned off and forcing PCH also enables
warnings. As there is nothing duktape would consume from our header,
remove forcing inclusion of that header into duktape.

* Provide msbuild parameter for using PCH only in CI
2023-05-07 21:53:50 +02:00
Matthias Moninger 4afa56e373
Merge pull request #20143 from janisozaur/gcc-13.1
Fix compatibility with GCC 13.1
2023-05-07 22:09:17 +03:00
Michał Janiszewski 6f2bf26ce1 Do the seekg thing 2023-05-07 20:46:05 +02:00
Michał Janiszewski 01f32a660f Fix length calculation 2023-05-07 20:00:37 +02:00
Matthias Moninger 4cb5620f43
Fix #20145: Add missing OnRidePhoto to the special element table (#20147) 2023-05-07 19:52:11 +02:00
Michał Janiszewski 851632510f Use unique_ptr 2023-05-07 19:37:56 +02:00
spacek531 61d820e614
Refactor special track elements list part 2 (#19951)
Part 2 of #19922
Fixes #19964

There are a lot of files changed, so this PR is structured to be easy to follow by looking at individual commits.

This PR refactors how the special track element list is created. The refactors include:

Divorces creating the list from RideConstructionWindow for modularity, including potential plugin API
Adds list of special track elements which can be re-ordered for more sensible organization
Same-named track elements will collapse into as few entries as possible
Separates up helixes from down helixes in track flags
Track flag separation was done to remove special code related to alpine coaster. Refactors to ride construction window were tested against and confirmed working with:

alpine coaster
suspended swinging coaster
hybrid coaster
inverted coaster
2023-05-07 09:13:22 +00:00
Michał Janiszewski be145da783 Fix compatibility with GCC 13.1 2023-05-06 23:02:26 +02:00
Matthias Moninger 1917a0b3f5
Merge pull request #20135 from ZehMatt/fix-20134
Fix #20134: Don't update grass length outside of the actual map
2023-05-06 19:27:20 +03:00
ζeh Matt 5683cf9520
Bump up network version 2023-05-06 18:25:27 +03:00
ζeh Matt 627a4f69c2
Update changelog.txt 2023-05-06 18:25:27 +03:00
ζeh Matt 4c78c8e512
Remove pointless masking 2023-05-06 18:25:27 +03:00
ζeh Matt cc1eee5bee
Fix #20134: Don't update grass length outside of the actual map 2023-05-06 18:25:27 +03:00
Meehoi 936f017147
Fix #20096: Server list window scroll is glitched when server list is empty (#20099)
* Fix initial scroll size of server list and change cast to int32_t

* set actual width for server list too

* add indentation

* fix pixel size of other scroll

* revert unnecessary changes

* add changelog entry
2023-05-06 17:01:14 +03:00
Matthias Moninger 756c516540
Merge pull request #20138 from ZehMatt/contributors-update
Update contributors.md
2023-05-06 16:14:07 +03:00
Michał Janiszewski 733eb07dd2
Run ctest tests in parallel (#20137) 2023-05-06 15:54:33 +03:00
Jochen Löppenberg 8627a5875f
Fix #20007: Wrong Error message when raising land or water: "Too low!" (#20123) 2023-05-06 12:23:17 +00:00
ζeh Matt e66fd199cc
Update contributors.md 2023-05-06 14:57:29 +03:00
Michał Janiszewski 21e15918a9
Use compiler hash instead of volatile mtime for macOS ccache
The mtime is volatile in macOS jobs, causing cache misses.

As compiler binary is the same, use compiler's binary hash instead of its mtime.

See https://github.com/hendrikmuhs/ccache-action/issues/146

When upstream action is updated, this can be adapted
2023-05-06 12:03:26 +02:00
kyphii 6f55454ae8
Add ratings modifier for reversed trains (#20091)
* Add ratings modifier for reversed trains

* Add test save file and ratings for this

* Changelog entry

* Bump network version

* Modify changelog

* Changelog edit

---------

Co-authored-by: Trevor Finney <8711258+finneyt@users.noreply.github.com>
2023-05-06 02:40:41 +03:00
OpenRCT2 git bot c964ced43f Merge Localisation/master into OpenRCT2/develop 2023-05-04 04:01:43 +00:00
Matthias Moninger e9c480c66e
Fix #20121: Guard against nullptr on viewport scroll (#20122) 2023-05-03 20:15:02 +01:00
Ted John 530dfac7c9
Fix #20104: [Plugin] Some network APIs use player index and group index (#20115)
Change all APIs that took a player index or group index so that they now take unique IDs.
2023-05-02 15:25:05 +01:00
Michał Janiszewski 42fa4cb6b9
Update backtrace token (#20117) 2023-05-01 23:03:30 +02:00
OpenRCT2 git bot 87b0ccdf5e Merge Localisation/master into OpenRCT2/develop 2023-05-01 04:01:53 +00:00
kyphii fe219281ec
Refactor Ride Ratings 2023-04-29 22:03:25 +02:00
kyphii 4237a02105
Fix mine train diagonal piece drawing incorrectly (#20082)
Co-authored-by: Trevor Finney <8711258+finneyt@users.noreply.github.com>
2023-04-29 07:41:49 +01:00
Tom c2042d541a
Refactor window to class: Research (#19910)
* Refactor window to class: Research (#13794)

- Update Research window to new window class

- Refactor dependant windows (Finances and NewRides)

* Refactor window to class: Research (#13794)

- Refactor all shared logic for both pages in research window. Reused by Finances and NewRides windows.

* Refactor window to class: Research (#13794)

- Fix style issues

* Refactor window to class: Research

- Fix style issues, again

* Refactor window to class: Research

- Override Window class methods

* Refactor window to class: Research

- Remove old method comments

* Refactor window to class: Research

- Addresses code review comments

* Refactor window to class: Research

- Adds ResearchWindow ctor

* Refactor window to class: Research

- Hide funding dropdown in no money scenarios
- Addresses code review comments
2023-04-28 23:54:02 -03:00
OpenRCT2 git bot d464e71b1a Merge Localisation/master into OpenRCT2/develop 2023-04-28 04:01:57 +00:00
Die4Ever 74c1f5a695
Fix openrct2.d.ts duplicate slopes25Banked67 (#20065) 2023-04-27 18:53:24 +01:00
Matthias Moninger 79af072cf4
Merge pull request #20055 from ZehMatt/dirty-grid
Improve dirty grid rendering performance.
2023-04-27 18:16:33 +03:00
spacek531 1bbdba40b5
Implement paint code for spiral lifthill down (#19567)
* spiral lifthill down paintcode

* rename string anyway

* add some stuff I forgot and add documentation

* use static assert on SpriteGroupMultiplier

* add slope to list of opposite slopes

* bump scripting version

* update openrct2.d.ts

* improve documentation
2023-04-27 15:11:22 +01:00
Matthias Moninger f975a914eb
Merge pull request #20054 from ZehMatt/rating-tests
Add BigTestMap to ride rating tests
2023-04-27 15:43:54 +03:00
Tulio Leao c849a75bc8
Close #13782: Refactor Multiplayer window to class (#19948) 2023-04-27 07:05:14 -03:00
OpenRCT2 git bot a38fc1109c Merge Localisation/master into OpenRCT2/develop 2023-04-27 04:02:07 +00:00
ζeh Matt 5bb267e0c9
Update changelog.txt 2023-04-26 23:21:55 +03:00
ζeh Matt d6b340b34d
Fix comments 2023-04-26 21:58:44 +03:00
ζeh Matt 5439c7ffeb
Improve dirty grid rendering performance. 2023-04-26 18:37:00 +03:00
ζeh Matt c6c29dbf64
Add BigTestMap to ride rating tests 2023-04-26 17:48:38 +03:00
Chase d6ebeca483
Fix #19935: Part of old multiplayer name remains when entering a shorter name (#20004)
* clear _playerName

* Change _playerName to a u8string

* Explicitly set underlying string ptr on change
2023-04-26 08:34:39 +01:00
Michael Steenbeek c96762517f
Use strong enum for metal supports (#20045) 2023-04-24 21:46:33 -03:00
Duncan ee100f59c0
Fix #19800. Crash when more than 62 stations on a ride (#20039)
* Fix #19800. Crash when more than 62 stations on a ride

This is a bit of a temporary fix. The crash happens due to exhausting the space in the formatter but the format string only ever handled 4 stations so it was still not going to work for 5 <=> 62 stations. So for the time being capped the output at 4 stations.

* Add changelog entry

* Apply review comment
2023-04-24 21:16:21 +00:00
Ted John 9dac7f889f
Fix #18583: Land dropdown is incorrect if there are surface entry holes (#20035) 2023-04-24 22:00:12 +01:00
Ted John 0cf24f0100
Fix #20033: Asset packs cannot reference game data (#20034) 2023-04-24 21:55:36 +01:00
Michael Steenbeek 2f25d4054b
Refactor/wooden supports 2 (#20005)
* Use new enum in MiniatureRailway.cpp

* Add new paint functions for Wooden B supports

* Update and consolidate Wooden B supports calls for Minetrain RC

* Consolidate Wooden A supports calls for Minetrain RC

* Replace some unnecessary calls to PaintAddImageAsParentRotated()
2023-04-24 21:54:16 +01:00
Hielke Morsink 5f798d98db
Undo removal of entry that was no regression 2023-04-24 22:43:41 +02:00
Hielke Morsink 5dea828769
Changelog fixes 0.4.5 2023-04-24 07:33:59 +00:00
kyphii c74e69b8a0
Fix #20027: Looping coaster with the reverse train option makes the wrong sound (#20028)
* Always use carEntry 0 for friction sound

* Use front car entry for sound index

* Add note for carEntry sound properties

* Bump network version

---------

Co-authored-by: Trevor Finney <8711258+finneyt@users.noreply.github.com>
2023-04-24 08:03:01 +01:00
Matthias Moninger 21a0ccbb77
Merge pull request #20024 from ZehMatt/fix-20018
Fix #20018: Shops not calculating up-keep cost
2023-04-23 01:29:37 +03:00
ζeh Matt d5f93fe6ae
Update changelog.txt 2023-04-23 00:16:54 +03:00