Commit Graph

23577 Commits

Author SHA1 Message Date
Cory Sanin 05f1007dd9
Fix #16989: Re-focusing maximised window triggers a restore and maximise
Fixes #16989 by removing an SDL hack. Originally added to address issue #2158, I can't reproduce this issue with the hack removed. Tested on Linux (by CorySanin) and Windows (by Broxzier).
2022-07-02 21:48:43 +02:00
Gymnasiast def2a714ab
Add #12328 to changelog
[ci skip]
2022-07-02 16:48:52 +02:00
Artem Yanenko 019ed54a48
Fix #17377: Park entrance can be placed without path in Scenario Editor 2022-07-02 14:02:27 +00:00
Henry Cheng f58bd0319c
Fix #17052: Incorrect wording for guests/staff visibility
Issue: Text options states that selecting it will cause guest/staff to be invisible. In actuality, it causes them to be transparent.
Fix: Changed description of "See-Through" to "Invisible"
2022-07-02 15:42:32 +02:00
Sadret 544770c0fb
Fix #16539: CustomListView header unclickable when scrolled 2022-07-02 12:34:12 +02:00
Gymnasiast 5f71d2788c
Add #17464 to changelog
[ci skip]
2022-07-02 12:30:48 +02:00
Henry Cheng 2246851f6b
Fix #17464: Green Tarmac footpath does not show up in Track Designer 2022-07-02 12:29:41 +02:00
Michael Steenbeek f173ee0d89
Merge pull request #17483 from Gymnasiast/fix/17481
Fix #17481: Roto-drop cars try going up to the wrong top pieces
2022-07-02 12:27:18 +02:00
duncanspumpkin 8492453702 Refactor to conform to style. Move uncommon items out of rct_window 2022-07-02 07:53:46 +01:00
duncanspumpkin 144cd5ada7 Complete moving into class 2022-07-02 07:28:16 +01:00
Gymnasiast d42e67ddfe
Reformat the ifs, remove unnecessary parameter 2022-07-01 23:26:40 +02:00
Gymnasiast d936aa48e1
Fix #17481: Roto-drop cars try going up to the wrong top pieces 2022-07-01 18:23:03 +02:00
duncanspumpkin 22f50b8199 Start creating invention list class 2022-07-01 14:57:24 +01:00
Hielke Morsink 9c595ccaa7
Replace 16 with new constant WATER_HEIGHT_STEP 2022-07-01 00:09:27 +02:00
Hielke Morsink 8e509d9669
Remove ObjectType++ operator, ensure ObjectTypes size 2022-06-30 23:13:40 +02:00
Duncan 43562a6899
Window Class Refactor: Invention List Drag (#17415)
* Start working on drag

* Finish moving invention drag into window class

* Refactor drag item into a window variable

* Remove rct2 comment
2022-06-30 10:25:18 +01:00
Hielke Morsink ac7331f878
Include <array> and use page count for size 2022-06-30 07:25:24 +00:00
Duncan d6e188d289
Park Window to class (#17364)
* Start base of class

* Start moving things into class

* Finish porting over

* Refactor to conform more with style

* Add no discard to imageid

* Fix objective window position

* Fix audio on viewport

* Make further fixes

* Move nodiscard again
2022-06-30 05:37:43 +01:00
Karst 7345dd58fe
Fix: Footpath Railing tooltip showing incorrect tooltip (#17461)
* Fix Footpath Railing tooltip

* Add changelog entry

* Update src/openrct2-ui/windows/Footpath.cpp

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2022-06-28 21:15:44 -03:00
Henry Cheng 36f43285ad
Close #16688: Remove unused variables on RideConstruction (#17453)
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2022-06-28 21:15:15 -03:00
Hielke Morsink e39fd9226f
Merge pull request #17426 from Broxzier/refactor/variadic-title-commands 2022-06-28 22:55:47 +02:00
Hielke Morsink 2936de5c86
Replace hardcoded 255/0xFF with TUNE_ID_NULL 2022-06-28 22:55:25 +02:00
Ted John 17a736bab6 Update the changelog 2022-06-28 21:11:40 +01:00
Hielke Morsink 79ae03fc5e
Rename `command` to avoid ghosting
It's curious that gcc complains about ghosting here, since the lambda has its own stack pointer, and doesn't capture the outer `command`.
2022-06-28 21:57:29 +02:00
Hielke Morsink 8e439b9895
Zero-initialize all command arguments 2022-06-28 21:57:29 +02:00
Hielke Morsink 6a017ac761
use std::decay helper type 2022-06-28 21:57:28 +02:00
Hielke Morsink 0e5cfce073
Maintain centre view position when screen resizes 2022-06-28 21:57:28 +02:00
Hielke Morsink 43f49f2483
Fix: commands used as tags don't save in scripting 2022-06-28 21:57:28 +02:00
Hielke Morsink 2b52df87ce
Move scripting command names to command classes
This way, new commands are required to have this field, or a compiler error will occur.
2022-06-28 21:57:27 +02:00
Hielke Morsink c8537d57b3
Note for commands used as tags 2022-06-28 21:57:27 +02:00
Hielke Morsink 3da305b82f
Implement follow entity command 2022-06-28 21:57:27 +02:00
Hielke Morsink 239dcb1677
Update title sequence scripting part 2022-06-28 21:57:26 +02:00
Hielke Morsink 1fc2312abd
Move most command logic from sequence player
This commit also moves everything related to the OpenRCT2::Title namespace.

Can be compiled with ENABLE_SCRIPTING disabled.
2022-06-28 21:57:26 +02:00
Hielke Morsink 6bfba88845
Move title commands to their own source files 2022-06-28 21:57:26 +02:00
Hielke Morsink debdb0bcda
Make title sequence commands list variadic 2022-06-28 21:54:25 +02:00
Ted John 854655af55
Fix #17466: New object types not packed in save files (#17467) 2022-06-28 19:59:09 +01:00
Ted John c823bf5f7e
Merge pull request #17465 from IntelOrca/fix/17462-audio-crash
Fix #17462: Crash when zooming or moving around the park
2022-06-28 19:58:54 +01:00
Sadret 1b154b1b6e
Fix #17450: Ducks can swim on three-corners-up land tile. (#17456) 2022-06-27 21:37:00 -03:00
Ted John 00014adec9 Fix #17462: Crash when zooming or moving around park
Lock the mixer while disposing an audio source.
2022-06-28 00:25:57 +01:00
Ted John 83758de284 Prevent ride music popping in loudly 2022-06-28 00:16:40 +01:00
Ted John 585ebed600
Fix #17297: Crash when switching language (#17370)
* Refactor all uses of IAudioChannel and the audio mixer.
* Use shared_ptr to avoid dead pointers hanging about.
* Reload particular audio channels where necessary after object reload.
2022-06-27 17:41:53 +01:00
giraty 0d6a8af643
Typo in changelog.txt (#17458)
* Typo in changelog.txt

* Found one more typo in changelog.txt

Co-authored-by: octavianputra <octavianputra@yummycorp.com>
2022-06-27 14:54:36 +01:00
Basssiiie 4d8dd516bf
Fix plugin ‘Car.travelBy()’ moving other cars as well (#17369) 2022-06-26 20:28:54 +01:00
Nicolas Espinosa Mooser 69ff925b1e
Refactor window to class: Staff (#17400)
* Refactor window to class: Staff
Close OpenRCT2/OpenRCT2#13806
2022-06-26 07:07:59 +01:00
jazzysoggy f77611dcd2
Fix #17229: Rename G1_FLAG_BMP to G1_FLAG_HAS_TRANSPARENCY (#17441)
* Renamed All Instance of G1_FLAG_BMP

Renamed all instances of G1_FLAG_BMP to GA_FLAG_HAS_TRANSPARENCY

* Fixed comments and labels

Fixed comments and labels to be more in line with new definitions
2022-06-25 07:04:40 +01:00
Hielke Morsink fb7be451e5
Add changlog entry for #17433 2022-06-23 11:50:31 +02:00
ywnico 2d9e2de603
Fix: Wrong T-shirt colors when riding Twist (#17433)
A typo in the code had caused the wrong ImageId object to be used when
painting the peeps, resulting in their T-shirts being set to the ride
colors. The peeps are now painted with the correct T-shirt colors.
2022-06-23 07:07:59 +01:00
Hielke Morsink 5b2d1c2527
Use viewport flag constants in window_scroll_to_location (#17427) 2022-06-21 21:49:56 -03:00
Gymnasiast c76d90932e
Add #15787 to changelog, reword #16911 2022-06-21 20:38:55 +02:00
Artem Yanenko 790e237b80
Fix #15787: toggling upper case banners only works after 10 secs 2022-06-21 20:37:45 +02:00