Commit Graph

23577 Commits

Author SHA1 Message Date
Hielke Morsink 274ab7190d
Remove unused function definitions 2022-07-31 20:34:32 +02:00
Hielke Morsink d6525e3cd0
Refactor window functions to take references 7 2022-07-31 17:23:18 +02:00
Hielke Morsink d05d675ed9
Refactor window functions to take references 6 2022-07-31 17:23:17 +02:00
Hielke Morsink 755deeef8e
Refactor window functions to take references 5 2022-07-31 17:23:17 +02:00
Hielke Morsink a258008bef
Refactor window functions to take references 4 2022-07-31 17:23:16 +02:00
Hielke Morsink 523bb8136e
Refactor window functions to take references 3 2022-07-31 17:23:16 +02:00
Hielke Morsink c8605a8763
Refactor window functions to take references 2 2022-07-31 17:23:15 +02:00
Hielke Morsink 76c1bc8980
Refactor window functions to take references 1 2022-07-31 17:23:15 +02:00
Rik Smeets 889293f2b7
Lower default price for the Crooked House (#17655)
Guests didn't want to pay the previous default price,
even if the ride was brand new.
2022-07-31 14:07:36 +02:00
frutiemax e96f428c7b
Add RIDE_TYPE_FLAG_HAS_SEAT_ROTATION for multi-dim rollercoaster 2022-07-31 12:01:22 +02:00
frutiemax aab94437dc
Add RIDE_TYPE_FLAG_HAS_ONE_STATION for gokarts and minigolf 2022-07-31 02:16:48 +02:00
Michał Janiszewski 575bae7ac4
Rename global variable text_palette -> gTextPalette (#17647) 2022-07-30 23:21:34 +02:00
Michał Janiszewski 3c4a07859b
Provide enough space in temp buffer
```
src/openrct2-ui/windows/Ride.cpp:3338:44: error: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Werror=format-truncation=]
 3338 |     snprintf(buffer, std::size(buffer), "%u", currentValue);
      |

(...)

/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘__builtin___snprintf_chk’ output between 2 and 6 bytes into a destination of size 5
```
2022-07-30 23:19:52 +02:00
Michael Steenbeek 92d7c79ac8
Fix #17532: Object Selection allows unselecting all stations
While it shouldn’t be possible to unselect them under normal circumstances,
I added checks for terrain surfaces and edges as well for good measure.
2022-07-30 20:01:42 +02:00
Michael Steenbeek 0bfc151ab9
Remove remaining usages of gGameCommandErrorText 2022-07-30 18:04:59 +02:00
Ted John 142b9ff243
Optimise object selection search
* Do case insensitive string matching for object search.
* Return as soon as first field is a hit.
2022-07-30 16:50:54 +02:00
frutiemax d556eafc73
Add LightFXAddLightsMagicVehicle to RTD (#17211) 2022-07-30 16:45:41 +02:00
Michael Steenbeek 5a5b107245
Refactor Twist rotations, fix truncating of operating value (#17636) 2022-07-30 16:32:22 +02:00
Hielke Morsink e2da19f0f7
Add missing includes 2022-07-29 18:45:10 +02:00
Michael Steenbeek 2b859c7099
Remove __ENABLE_LIGHTFX__ define
It is already enabled for all our builds, and upcoming changes to RTD would add a slew more.
Discussed in team chat with Duncan and Hielke.
2022-07-28 21:34:02 +00:00
Duncan 5f9b0da5ff
Parkinfo object query (#16283)
* Add basic parkinfo object query

* Cleanup output and remove remnants of future work

* Make review changes

* Update changelog
2022-07-28 21:20:55 +00:00
Michael Steenbeek 34a7421b98
Remove last references to WINNT 5.1 (#17631)
Probable oversight from https://github.com/OpenRCT2/OpenRCT2/pull/17411.
2022-07-28 22:39:04 +02:00
Hielke Morsink 0392925450
Close #16840: Add support for rectangular heightmaps 2022-07-28 20:24:37 +00:00
Michael Steenbeek 43bc0b0cd9
Merge pull request #17626 from Gymnasiast/fix/17542
Fix #17542: Stalls will autorotate towards paths outside the park
2022-07-28 21:56:42 +02:00
Gymnasiast 5e8b749277
Fix #17542: Stalls will autorotate towards paths outside the park 2022-07-28 21:26:11 +02:00
Gymnasiast f0777e5418
Introduce constant for construction rights clearance 2022-07-28 21:25:42 +02:00
Raymond Zhao 7399163a3c
Use more smart ptrs and u8strings (#17611)
* Use smart ptr for PlatformUiContext and WindowManager

* Remove more delete calls

* Apply PR feedback
2022-07-28 18:19:38 +01:00
Michael Steenbeek e5d2e3001d
Fix buffer size handling for ride operations input
Ensure a nicely terminated string
2022-07-28 14:24:19 +02:00
Michael Steenbeek 6852b184b6
Fix #17541: Station style not correctly saved to TD6 2022-07-28 14:23:53 +02:00
Michael Steenbeek a75cc10dd5
Refactor Ride::Open, Ride::Test not to use gGameCommandErrorText 2022-07-28 14:23:33 +02:00
Michael Steenbeek 1a8660d59d
Pass window reference to tool_set (#17625) 2022-07-27 22:22:22 -03:00
frutiemax a3ce24658c
Add StartRideMusic field to RTD 2022-07-27 23:50:20 +00:00
Michael Steenbeek 8c88a8684c
Merge pull request #17107 from rik-smeets/text-input-ride-operating-window
Feature: Change ride operating settings via text input
2022-07-27 23:39:05 +02:00
Gymnasiast 39f60c3412
Input current value; fix dodgems mode detection 2022-07-27 23:13:01 +02:00
Rik Smeets 1eb3a86770
Ride operating settings can be set via text input
Both minimum and maximum wait time and operating settings for flat rides can now be set via text input.
2022-07-27 22:50:04 +02:00
Michael Steenbeek 30f477972c
Close #15358: Increase park name character limit 2022-07-27 17:35:15 +02:00
Duncan 7433119749
Fix #17620. Missing setting ride id for construction window (#17622)
This would eventually cause a crash when trying to reset the window on last track piece deletion. Mistake made in refactor #17578
2022-07-27 16:06:33 +01:00
Michael Steenbeek 710e0e30db
Replace ride type check in S4Importer
This is more preparation needed to make ride types into objects. Supersedes #17209.
2022-07-27 12:44:15 +02:00
OpenRCT2 git bot a516b0ce34 Merge Localisation/master into OpenRCT2/develop 2022-07-27 04:21:03 +00:00
frutiemax bc72c7e24c
Add UpdateLeaveEntrance field to the RTD (#16986)
Co-authored-by: frutiemax <frutiemax@users.noreply.github.com>
2022-07-26 19:33:54 -03:00
Hielke Morsink 4bac31c997
Improve placeholder text for steps to reproduce
Move value to placeholder, so the field is empty and the user has to write something in this field themselves.
Provide simple example steps to make it more clear what we expect.
2022-07-26 23:58:14 +02:00
Michael Steenbeek 3f56a0eac9
Fix stray white line 2022-07-26 20:08:05 +01:00
Hielke Morsink 6f48ffdf41
Fix #17430: Crash when modifying tile when in multiplayer 2022-07-26 19:47:38 +02:00
Raymond Zhao 4f23e5e9ec
Refactor struct TrackDesignFileRef
- Refactors track_design_file_ref to TrackDesignFileRef and replaces the utf8* fields of that struct with u8string
- Gets rid of some String::Duplicate() and delete calls
- Uses a bunch of c_str() calls to interface with older functions
2022-07-26 16:12:46 +00:00
Duncan 68ded02b14
Fix #17605. Prevent crash when parks include missing objects (#17606)
* Fix #17605. Prevent crash when parks include missing objects

Specifically the park needs to have had removed an object that is referenced within a scenery group object.
2022-07-26 14:33:30 +00:00
Nikolas Parshook 628da77c0e
Refactor ride construction window (#17578) 2022-07-26 15:17:25 +01:00
OpenRCT2 git bot e63e682731 Merge Localisation/master into OpenRCT2/develop 2022-07-26 04:28:26 +00:00
Ted John bd6817cb45
Fix #17533: Missing audio when specifying --rct2-data-path 2022-07-25 14:26:28 +00:00
Henry Cheng 08e0b9ae8d
Fix #17508: Grid Doesn't Disable After Setting Patrol Area (#17574)
* Move show_gridlines to only run under condition

* Update changelog.txt

Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2022-07-25 13:39:19 +00:00
OpenRCT2 git bot e33b35a04d Merge Localisation/master into OpenRCT2/develop 2022-07-25 04:19:38 +00:00