Commit Graph

2603 Commits

Author SHA1 Message Date
Hielke Morsink 523bb8136e
Refactor window functions to take references 3 2022-07-31 17:23:16 +02:00
Hielke Morsink c8605a8763
Refactor window functions to take references 2 2022-07-31 17:23:15 +02:00
Hielke Morsink 76c1bc8980
Refactor window functions to take references 1 2022-07-31 17:23:15 +02:00
frutiemax e96f428c7b
Add RIDE_TYPE_FLAG_HAS_SEAT_ROTATION for multi-dim rollercoaster 2022-07-31 12:01:22 +02:00
Michał Janiszewski 3c4a07859b
Provide enough space in temp buffer
```
src/openrct2-ui/windows/Ride.cpp:3338:44: error: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Werror=format-truncation=]
 3338 |     snprintf(buffer, std::size(buffer), "%u", currentValue);
      |

(...)

/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘__builtin___snprintf_chk’ output between 2 and 6 bytes into a destination of size 5
```
2022-07-30 23:19:52 +02:00
Michael Steenbeek 0bfc151ab9
Remove remaining usages of gGameCommandErrorText 2022-07-30 18:04:59 +02:00
Ted John 142b9ff243
Optimise object selection search
* Do case insensitive string matching for object search.
* Return as soon as first field is a hit.
2022-07-30 16:50:54 +02:00
Michael Steenbeek 5a5b107245
Refactor Twist rotations, fix truncating of operating value (#17636) 2022-07-30 16:32:22 +02:00
Hielke Morsink e2da19f0f7
Add missing includes 2022-07-29 18:45:10 +02:00
Gymnasiast 5e8b749277
Fix #17542: Stalls will autorotate towards paths outside the park 2022-07-28 21:26:11 +02:00
Raymond Zhao 7399163a3c
Use more smart ptrs and u8strings (#17611)
* Use smart ptr for PlatformUiContext and WindowManager

* Remove more delete calls

* Apply PR feedback
2022-07-28 18:19:38 +01:00
Michael Steenbeek e5d2e3001d
Fix buffer size handling for ride operations input
Ensure a nicely terminated string
2022-07-28 14:24:19 +02:00
Michael Steenbeek 1a8660d59d
Pass window reference to tool_set (#17625) 2022-07-27 22:22:22 -03:00
Gymnasiast 39f60c3412
Input current value; fix dodgems mode detection 2022-07-27 23:13:01 +02:00
Rik Smeets 1eb3a86770
Ride operating settings can be set via text input
Both minimum and maximum wait time and operating settings for flat rides can now be set via text input.
2022-07-27 22:50:04 +02:00
Michael Steenbeek 30f477972c
Close #15358: Increase park name character limit 2022-07-27 17:35:15 +02:00
Duncan 7433119749
Fix #17620. Missing setting ride id for construction window (#17622)
This would eventually cause a crash when trying to reset the window on last track piece deletion. Mistake made in refactor #17578
2022-07-27 16:06:33 +01:00
Raymond Zhao 4f23e5e9ec
Refactor struct TrackDesignFileRef
- Refactors track_design_file_ref to TrackDesignFileRef and replaces the utf8* fields of that struct with u8string
- Gets rid of some String::Duplicate() and delete calls
- Uses a bunch of c_str() calls to interface with older functions
2022-07-26 16:12:46 +00:00
Nikolas Parshook 628da77c0e
Refactor ride construction window (#17578) 2022-07-26 15:17:25 +01:00
Ted John bd6817cb45
Fix #17533: Missing audio when specifying --rct2-data-path 2022-07-25 14:26:28 +00:00
Henry Cheng 08e0b9ae8d
Fix #17508: Grid Doesn't Disable After Setting Patrol Area (#17574)
* Move show_gridlines to only run under condition

* Update changelog.txt

Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2022-07-25 13:39:19 +00:00
AuraSpecs d82360cc16
Add Authors to the list of things you can search for in the Object Selection menu (#17575)
* Add Authors to Search option

Joint effort from Spacek and karst

* Update changelog.txt

* Apply code review comment

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
2022-07-23 20:28:39 +00:00
Henry Cheng 46a2047309
Refactor Server Start Window to Class (#17592)
* Refactor first

* Update refactor

* Add fixes requested

* Dropped static
2022-07-23 20:47:17 +01:00
Raymond Zhao 71ad3af930
Use more smart pointers in openrct2-ui (#17582)
* Use more smart ptrs

* Use move instead of copy ctor
2022-07-22 11:48:43 +01:00
Raymond Zhao f4df6be8ae
Remove some calls to free (#17577) 2022-07-21 07:50:43 +01:00
Henry Cheng 3bad01a704
Fix #17553: Crash when moving invention list items to empty list (#17555)
* Fix content check

* Add change log entry

Co-authored-by: Duncan <duncans_pumpkin@hotmail.co.uk>
2022-07-17 07:12:29 +00:00
Cory Sanin 37a38af6a5
Fix: [#17503] Correct staff refactor issue (#17546) 2022-07-17 07:43:32 +01:00
8street 213696ea27
Add option to sell merchandise in random colours
Co-authored-by: 8street <nikolai_e@rambler.ru>
2022-07-12 22:20:49 +00:00
Michael Steenbeek 11614d7170
Merge pull request #17486 from duncanspumpkin/inventionWnd
Invention List Window Class Refactor
2022-07-12 19:49:03 +02:00
Gymnasiast 06c368694a
Update variables containing a CarEntry 2022-07-11 18:06:22 +02:00
Duncan 5d896c65b5
Refactor Guest Window to Class 2022-07-03 22:00:37 +02:00
Artem Yanenko 019ed54a48
Fix #17377: Park entrance can be placed without path in Scenario Editor 2022-07-02 14:02:27 +00:00
duncanspumpkin 8492453702 Refactor to conform to style. Move uncommon items out of rct_window 2022-07-02 07:53:46 +01:00
duncanspumpkin 144cd5ada7 Complete moving into class 2022-07-02 07:28:16 +01:00
duncanspumpkin 22f50b8199 Start creating invention list class 2022-07-01 14:57:24 +01:00
Duncan 43562a6899
Window Class Refactor: Invention List Drag (#17415)
* Start working on drag

* Finish moving invention drag into window class

* Refactor drag item into a window variable

* Remove rct2 comment
2022-06-30 10:25:18 +01:00
Hielke Morsink ac7331f878
Include <array> and use page count for size 2022-06-30 07:25:24 +00:00
Duncan d6e188d289
Park Window to class (#17364)
* Start base of class

* Start moving things into class

* Finish porting over

* Refactor to conform more with style

* Add no discard to imageid

* Fix objective window position

* Fix audio on viewport

* Make further fixes

* Move nodiscard again
2022-06-30 05:37:43 +01:00
Karst 7345dd58fe
Fix: Footpath Railing tooltip showing incorrect tooltip (#17461)
* Fix Footpath Railing tooltip

* Add changelog entry

* Update src/openrct2-ui/windows/Footpath.cpp

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2022-06-28 21:15:44 -03:00
Henry Cheng 36f43285ad
Close #16688: Remove unused variables on RideConstruction (#17453)
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
2022-06-28 21:15:15 -03:00
Ted John 585ebed600
Fix #17297: Crash when switching language (#17370)
* Refactor all uses of IAudioChannel and the audio mixer.
* Use shared_ptr to avoid dead pointers hanging about.
* Reload particular audio channels where necessary after object reload.
2022-06-27 17:41:53 +01:00
Nicolas Espinosa Mooser 69ff925b1e
Refactor window to class: Staff (#17400)
* Refactor window to class: Staff
Close OpenRCT2/OpenRCT2#13806
2022-06-26 07:07:59 +01:00
jazzysoggy f77611dcd2
Fix #17229: Rename G1_FLAG_BMP to G1_FLAG_HAS_TRANSPARENCY (#17441)
* Renamed All Instance of G1_FLAG_BMP

Renamed all instances of G1_FLAG_BMP to GA_FLAG_HAS_TRANSPARENCY

* Fixed comments and labels

Fixed comments and labels to be more in line with new definitions
2022-06-25 07:04:40 +01:00
Artem Yanenko 790e237b80
Fix #15787: toggling upper case banners only works after 10 secs 2022-06-21 20:37:45 +02:00
Artem Yanenko 29beb2962d
Fix primary color picker for canvas tent (#17416) 2022-06-20 21:24:09 +02:00
Hielke Morsink 13db5a771b
Annotate hardcoded arrays and verify their sizes
This also reduces the number of lines within // clang-format comments
2022-06-16 23:51:24 +02:00
Duncan f0949284c4
Editor Bottom Toolbar Window class (#17358)
* Move EditorBottomToolbar to window class

* Minor refactoring

* Further refactoring

* keep compilers happy
2022-06-08 20:54:03 +01:00
duncanspumpkin d521327072 use consistent style 2022-06-07 22:35:06 +01:00
duncanspumpkin 249eaa989e Refactor sign internal variables 2022-06-07 22:35:06 +01:00
duncanspumpkin 3dba3984bf Remove map_variables 2022-06-07 22:35:06 +01:00