Patric Stout
055121df80
Fix: depot-related commands did not validate depot tiles properly ( #9948 )
...
The bug comes in two slices:
1) the functions never actually checked if "tile" was a depot tile.
This allowed executing the function on tile 0, where are the
things like shadows of aircrafts are.
2) BuildDepotVehicleList() first checked if a vehicle is in a depot
before checking if it was a primary vehicle. This is invalid
for aircraft.
Fixing the first hides the second, and fixing the second makes the
first non-exploitable. But, fixing both felt like the best thing
to do.
2022-07-09 12:28:09 +02:00
Patric Stout
28e90769f7
Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had
...
While at it, replace OTTD_ASSERT with WITH_ASSERT, as this
is always set if assert() is valid. No matter if NDEBUG is set
or not.
2021-06-03 17:30:00 +02:00
Patric Stout
fece1c57ca
Codechange: Suppress warnings when asserts are disabled ( #8917 )
2021-04-01 11:16:19 +02:00
Charles Pigott
860c270c73
Codechange: Replace assert_compile macro with static_assert
2020-12-27 10:55:42 +00:00
glx22
d8605ad18d
Codechange: Replace FOR_VEHICLE_ORDERS with range-based for loops
2020-12-27 10:28:46 +00:00
glx
d8a1be48cd
Codechange: Replace vehicle related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
S. D. Cloudt
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
Henry Wilson
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
Henry Wilson
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
Henry Wilson
9cba6f7193
Codechange: Replaced SmallVector::Compact() with std::vector::shrink_to_fit()
2019-03-26 20:15:57 +00:00
Henry Wilson
bfd79e59dc
Codechange: Replace SmallVector::Clear() with std::vector::clear()
2019-03-26 20:15:57 +00:00
frosch
b4b98e5165
(svn r27893) -Codechange: Use fallthrough attribute. (LordAro)
2017-08-13 18:38:42 +00:00
frosch
476b2b0e8c
(svn r27677) -Codechange: Remove implicit VehicleListIdentifier from uint32 constructor, to make conversions more explicit.
2016-11-05 19:16:59 +00:00
frosch
da9de1de70
(svn r26679) -Codechange: VehicleListIdentifier::Pack can be const. (Juanjo)
2014-07-08 20:07:21 +00:00
rubidium
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
peter1138
567d0ff3a7
(svn r26450) -Feature: Hierarchical vehicle subgroups.
2014-04-08 21:09:06 +00:00
rubidium
85d4f8d65c
(svn r25959) -Fix: clang warnings; either because type safety was assumed, or because technically the wrong value was tested
2013-11-09 06:52:08 +00:00
alberth
2ab7c82b31
(svn r24395) -Doc: Fixed argument references in @param descriptions.
2012-07-10 18:37:54 +00:00
frosch
db09f67674
(svn r24260) -Change [FS#5126]: Make the oilrig-vehicle list accessible to specators and colour it's caption neutrally grey.
2012-05-16 22:08:46 +00:00
planetmaker
43c8cd1d5e
(svn r22473) -Codechange: Automatic orders are better called implicit orders as no real order influencing path finding is added
2011-05-18 12:19:58 +00:00
rubidium
7eba2bf4d3
(svn r21890) -Cleanup: remove some unneeded includes
2011-01-22 14:52:20 +00:00
rubidium
64f04c3a74
(svn r21642) -Feature: concept of automatic station orders; add stub orders for intermediate stations and remove them when not visiting them anymore. This allows you to see what trains visit a station without actually having to order a vehicle to stop at all stations. Based on patch by fonsinchen
2010-12-26 09:03:19 +00:00
rubidium
3ebf8a297e
(svn r20776) -Codechange: make VehicleLists for the group "ALL_GROUP" work as well
2010-09-09 14:39:48 +00:00
rubidium
f5128695c5
(svn r20772) -Codechange: use packed VehicleListIdentifiers as window numbers
2010-09-08 21:37:13 +00:00
rubidium
881c6c679f
(svn r20771) -Add: concept of vehicle list identifiers to identify a vehicle list instead of a string of parameters
2010-09-08 21:28:50 +00:00
smatz
c4175b752a
(svn r19957) -Codechange: remove VLW_WAYPOINT_LIST
2010-06-11 00:18:28 +00:00
frosch
5ecf2f7f8c
(svn r19656) -Codechange/Fix: Report back if invalid vehicle lists are requested.
2010-04-17 14:47:56 +00:00
rubidium
7fbc33dae1
(svn r17248) -Fix: add GPL license notice where appropriate
2009-08-21 20:21:05 +00:00
smatz
d86e17d65a
(svn r16719) -Codechange: make IsArticulatedPart(), IsTrainEngine(), IsTrainWagon(), IsMultiheaded(), EngineHasArticPart() and IsRearDualheaded() members of Train
2009-07-01 23:57:20 +00:00
smatz
ecfaa0564d
(svn r16718) -Codechange: make IsFreeWagon() member of Train
2009-07-01 23:49:13 +00:00
smatz
0c10006907
(svn r16527) -Codechange: use static member functions instead of simple casts when converting Vehicle to specialised vehicle types. Includes safety check
2009-06-06 16:54:22 +00:00
rubidium
e3c5bc8d2e
(svn r16434) -Cleanup: remove some dead code; primarily stuff that can't be reached like break after returns or break after functions that never return (i.e. NOT_REACHED)
2009-05-26 15:46:24 +00:00
rubidium
0d99b6c71c
(svn r16421) -Codechange: do not unnecessarily remove constness or unnecessarily add it.
2009-05-24 20:29:04 +00:00
rubidium
c4b627af42
(svn r16392) -Codechange: move some variables (the ones that aren't caches) from VehicleRail to Train
2009-05-22 22:33:05 +00:00
rubidium
80e94b9bb1
(svn r16391) -Codechange: use Train instead of Vehicle where appropriate.
2009-05-22 22:22:46 +00:00
smatz
6221d74644
(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)
2009-05-16 23:34:14 +00:00
smatz
0d3f5e6e74
(svn r15299) -Cleanup: remove many redundant includes
2009-01-31 20:16:06 +00:00
rubidium
0c352ede7a
(svn r14783) -Fix (r12661): don't add vehicles with "go to nearest depot" to the vehicle list of the depot with index 0.
2009-01-02 19:45:46 +00:00
rubidium
a999bb3227
(svn r14466) -Doc: remove some obsolete parameters, fix a few parameter names in comments and add a little more doxygen documentation.
2008-10-14 19:27:08 +00:00
rubidium
3b798599b6
(svn r14421) -Codechange: rename all player variables/types to company *or* client so it is immediatelly clear which one you are working with.
2008-09-30 20:39:50 +00:00
frosch
67db5087cd
(svn r14406) -Fix [FS#Eddi]: Autoreplace did not work for vehicles in free wagon chains.
2008-09-27 14:58:46 +00:00
belugas
d3dd9c6566
(svn r14118) -Fix(r14104): typos creeping like bugs
2008-08-21 01:42:21 +00:00
belugas
77ee099212
(svn r14104) -Feature: Add a window for waypoints, allowing to view all the trains having the selected waypoint in their orders.
...
Changing its name is also supported from the same new window.
Gui based on work done by Satyap, on FS#2025.
2008-08-20 01:29:05 +00:00
rubidium
99efe9aaae
(svn r14097) -Fix [FS#2085]: one couldn't get a list of vehicles sharing an order when the number of orders was 0; you could see that the vehicles had a shared order though.
2008-08-17 21:07:09 +00:00
rubidium
abd9f74871
(svn r14096) -Codechange: merge the shared order's vehicle list management to a single location.
2008-08-17 19:56:17 +00:00
peter1138
f9fc53f98a
(svn r13307) -Codechange: Separate VehicleList and its two functions so only the 3 users include it, reducing dependencies on misc/smallvec.h
2008-05-28 11:56:21 +00:00