mirrors
/
OpenRCT2
mirror of https://github.com/OpenRCT2/OpenRCT2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
25,998 Commits 7 Branches 39 Tags 335 MiB
Commit Graph

173 Commits

Author SHA1 Message Date
Gymnasiast c158854a7f
Move Park into namespace, add other park-related things to struct 2024-04-04 18:14:27 +02:00
Claudio Tiecher 24688ad5a3 Part of #21421: Refactor TILE_ELEMENT_DIRECTION_MASK 2024-03-25 16:17:32 +01:00
Peter Froud 40a7fa70fc
Fix empty error messages (#21351) 
* Add `STR_ERR_CANT_CHANGE_PARK_ENTRANCE_FEE`

* Add `STR_ERR_TRACK_ON_THIS_TILE_NEEDS_WATER`

* Return existing `GameAction::Result`

* Add `STR_ERR_ACTION_INVALID_FOR_THAT_STAFF_TYPE`

I am open to suggestions for a different message!
Originally this was going to be STR_ERR_WRONG_STAFF_TYPE
but I thought that was confusing because the game
action arguments do not specify a staff type. We
want it to mean "the staff ID you specified is the
wrong StaffType for this game action".

* Refactor `StaffSetColour()` to return `Result`

* Remove unnecessary arguments when `Status` is `Ok`

* Refactor `SwapTileElements()` to return `Result`

Also add STR_ERR_CANT_SWAP_TILE_ELEMENT_WITH_ITSELF

* Format code

* Use `STR_ERR_CANT_CHANGE_PARK_ENTRANCE_FEE` in title

* Format code using Github web editor

* Format indentation
 2024-02-19 20:58:04 -03:00
Matt fc1b580074
Merge pull request #21244 from pfroud/add-error-strings 
Add error strings to reduce how many `GameActions::Result`s have `STR_NONE, STR_NONE`
 2024-01-29 18:02:37 +02:00
Peter Froud ce45cb3360
Use descriptive error strings for two `GameAction::Result`s 
- Fix error when setting brake speed outside park
- Fix error when pasting but reached tile limit
 2024-01-25 11:37:02 +01:00
Peter Froud 7302d718e3 Fix local variable shadowing a previous local 2024-01-22 02:49:19 -08:00
Peter Froud 4145f851da Run clang-format 2024-01-22 02:29:08 -08:00
Peter Froud 9299a80a58 Add descriptive error strings for null checks 2024-01-22 01:21:14 -08:00
James103 1d8dc111f1
Replace 2023 with 2024 in copyright headers (#21139) 
Replace all instances of the year 2023 with 2024 in all copyright headers
 2024-01-01 12:52:28 +01:00
Michael Bernardi 73579900ad Fix inconsistent behaviour when removing in MP 2023-08-12 22:38:04 +02:00
Michael Bernardi 0faff29a88 Move tile invalidation to the action 2023-08-12 22:00:29 +02:00
Michael Bernardi a26464b897 Selected TileElement now stored in paint session 2023-08-12 22:00:29 +02:00
Michael Bernardi b496e001d1 Remove old calls to invalidate now handled by intent 2023-08-12 22:00:29 +02:00
Michael Bernardi 055a532571 Fix #19822: Banners can now be copy-pasted from the tile inspector 2023-07-02 21:35:09 +02:00
Matthias Moninger 3ef6003671
Replace openrct2_assert with Guard::Assert, remove openrct2_assert 2023-07-02 16:42:46 +02:00
Michael Bernardi 9c5c1eb858 Fix #20349: Tile inspector creates map animations 2023-06-06 21:55:15 +02:00
John Mulcahy 18ce417dc0
Fix 19231 - Fix Tile Copy/Paste null pointer exception 2023-04-04 11:35:20 +02:00
Duncan e904ef406f
Fix #19503. Hide 3+ queue junction railings behind a flag (#19644) 
* Fix #19503. Hide 3+ queue junction railings behind a flag

This is to prevent existing parks from changing their behaviour

* Clang format

* Bump version numbers. Update changelog

* Update text
 2023-03-23 08:16:32 +00:00
Duncan b56748bc82
ObjectEntry Cleanup. FootpathItem, SceneryGroup, Water, LargeScenery (#19385) 
* Move footpathitem entry into new getter

* Move scenery group entry into new getter

* Move water entry into new getter

* Move large scenery entry into new getter

* Remove unused header includes

* Fix compile issue

* Include missing header from vcxproj
 2023-02-15 21:35:16 +00:00
Duncan ead13c44b8
Split off LargeSceneryEntry (#19277) 2023-01-26 18:44:42 +00:00
Duncan e09f27df3c
Rename snake_case Class names (Remaining Bits) (#19237) 
* Rename snake_case Class names

* Clang format

* Fix build issues
 2023-01-21 19:57:17 +00:00
Michael Steenbeek 448c8fafd0
Rename base_height, clearance_height and owner 2023-01-19 20:36:30 +01:00
Michael Steenbeek bb55c6ce66
Remove loadsasnakes (#19192) 
* Rename snake_case methods in scenario folder

* Rename snake_case methods in title folder

* Rename snake_case methods in object folder

* Rename snake_case methods in platform folder

* Rename snake_case methods in windows folder

* Rename tile_inspector.h to TileInspectorGlobals.h

* Rename snake_case methods in ui/windows folder
 2023-01-17 19:46:55 +00:00
Hielke Morsink 6b7dc8fcdb
Rename snake_case functions in openrct2/src folder 
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2023-01-17 13:24:51 +01:00
Stephan Spengler 76b918e7ed
Change openrct2/ride methods to UpperCamelCase, part 1 2023-01-17 01:32:54 +01:00
Hielke Morsink 6dafbbfb65
Rename global window functions to TitleCase (#19167) 2023-01-16 20:13:42 +00:00
James103 73738bbdc8
Replace 2022 with 2023 in copyright headers 
Replace all instances of the year 2022 with 2023 in all copyright headers
 2023-01-01 11:58:01 +01:00
spacek531 09c8e4755f
Rename GetBrakeClosed() to IsBrakeClosed() 2022-12-31 14:06:22 +01:00
Gymnasiast 38b34e841a
Use safe method to access ted block 2022-12-10 22:31:23 +01:00
Duncan 406b73d904
Remove final snakes from map and world (#18304) 2022-10-12 09:14:45 -03:00
Duncan 7dd8989e70
Next chunk of World/Map.h snakes (#18296) 
* Next chunk of World/Map.h snakes

* Apply clang-format
 2022-10-12 06:35:20 +01:00
Duncan 67bbc8560d
Code style: Remove snakes from everything world apart from Map.h (#18273) 
* Remove remaining snakes from world (outside of map)

* Initial few desnaking of Map.h
 2022-10-11 19:39:24 +01:00
Duncan 5dba30778d
Code style: Remove more snakes from the park, maphelper, scenery. (#18222) 2022-10-08 06:56:17 -03:00
duncanspumpkin 2a593b6029 Remove snake cases from Location and LargeScenery 2022-10-05 20:21:56 +01:00
73 b9e677945d
Replace 20XX with 2022 (#18158) 
* Replace 2020 with 2022

Replace all 2020 headers with 2022

* replace other years with 2022

add missing years
 2022-10-01 08:42:14 +01:00
Hielke Morsink 7f29e4e39c
Make `rct_windowclass` strong type `WindowClass` 
This already revealed some places where implicit conversions were done, including some where its use was nonsense (MouseInput.cpp).
The changes to the Intent class were necessary to keep things working, and this splits things up more neatly.
 2022-08-21 18:38:25 +02:00
Hielke Morsink 7cafccdb64
Use COORDS_XY_STEP constant in TileInspector.cpp (#17789) 2022-08-13 14:00:13 +02:00
Hielke Morsink 6f48ffdf41
Fix #17430: Crash when modifying tile when in multiplayer 2022-07-26 19:47:38 +02:00
Hielke Morsink ad0a2a8f96
Remove entrance/exit location functions 2022-02-18 23:28:17 +02:00
Duncan b3bae9429c
Fix #16427. Actually copy banners when using tile inspector (#16450) 2022-01-22 08:22:46 +00:00
Michael Steenbeek 27cbb6c6ae
Merge pull request #16190 from Gymnasiast/refactor/normalised-tile-element-type-3 
Part of #15485: normalise all OpenRCT2 tile element types
 2021-12-12 09:53:09 +01:00
ζeh Matt cec30e093d
Merge pull request #15991 from ZehMatt/refactor/bannerid 
Use TIdentifier for BannerIndex
 2021-12-11 08:08:27 -08:00
Gymnasiast aa34f0f760
Drop the N postfix 2021-12-11 00:39:39 +01:00
Gymnasiast fc3ce3294c
Move over switches to normalised tile element types 2021-12-11 00:30:59 +01:00
Michael Steenbeek 2d1af0ec42
Replace many GetType() calls with GetTypeN() 2021-12-10 22:43:17 +01:00
Gymnasiast 91635a5047
Replace SetType and old strong enum with normalised 2021-12-05 13:54:01 +01:00
ζeh Matt 810521bd5b
Remove BANNER_INDEX_NULL 2021-12-01 14:41:59 +02:00
ζeh Matt 83b911b193
#15634: Refactor passing GameActions::Result by copy (#15951) 
* Refactor to result GameActions::Result as copy instead of unique_ptr

* Remove alias GameActions::Result::Ptr

* Remove MakeResult wrapper

* Remove type forwarder in TileInspector
 2021-11-24 07:35:08 +00:00
IntelOrca 34128dc262
Add new .park save format 
Co-authored-by: Gymnasiast <Gymnasiast@users.noreply.github.com>
Co-authored-by: duncanspumpkin <duncanspumpkin@users.noreply.github.com>
Co-authored-by: ZehMatt <Zehmatt@users.noreply.github.com>
Co-authored-by: Broxzier <Broxzier@users.noreply.github.com>
 2021-11-21 22:43:22 +01:00
ζeh Matt 60838f563e
Refactor explicit constructor usage for TileInspector 2021-10-27 04:32:05 +03:00