mirrors
/
OpenRCT2
mirror of https://github.com/OpenRCT2/OpenRCT2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
23,903 Commits 7 Branches 39 Tags 354 MiB
Commit Graph

18638 Commits

Author SHA1 Message Date
Michael Steenbeek ce03c228ad
Fix #17616: Quarter-tile scenery is misaligned 2022-08-11 00:50:42 +02:00
Michael Steenbeek 5661da1c68
Unwrap game action compat wrappers 2022-08-11 00:00:58 +02:00
Michael Steenbeek 93807ec5bf
Remove ride type checks for log bumps/rapids string 2022-08-10 23:43:00 +02:00
frutiemax 59c31e8b7a
Add AccelerationFactor field to RTD (#17687) 2022-08-09 22:20:07 -03:00
frutiemax 9cd6c646a9
Add UpdateMeasurementsSpecialElements field to RTD (#17659) 2022-08-09 22:18:15 -03:00
ltsSmitty e0e7227dae
Fix sprintf deprecation error on MacOS build 
Co-authored-by: Gymnasiast <Gymnasiast@users.noreply.github.com>
 2022-08-09 20:31:15 +02:00
Michael Steenbeek 39722307d2
Fix #11746: Cannot set ride or shop prices in some circumstances (#17765) 2022-08-09 18:06:21 +00:00
Hielke Morsink 9e1b24d977
Make support transparency invisible by default 2022-08-08 19:04:02 +02:00
Michael Steenbeek 980e3cbc4c
Remove superfluous line from MSVC project file 2022-08-06 16:34:10 +02:00
Michael Steenbeek a7e66535d9
Change ‘restroom’ to ‘toilet’ in the code 2022-08-06 14:33:37 +00:00
Michael Steenbeek 746722df1b
Fix #17703: (undefined string) when building on invalid height 2022-08-06 15:42:51 +02:00
leoleotte 863892391d
Fix #17600: Notifications aren't cleared on park load (#17705) 
When loading a save using the New Save Format (.park files), the notification (news) list is not properly terminated and is preserving previously loaded news from other save files, including the main menu ones.
 2022-08-06 13:42:07 +00:00
Gymnasiast 49896ece43
Pass considerOnlyCloseRides to PeepHeadForNearestRideWithFlags() 2022-08-06 15:00:52 +02:00
frutiemax 6868b3dcaf
Rename IS_SHOP to IS_SHOP_OR_FACILITY and use it for RideObject 2022-08-06 15:00:52 +02:00
frutiemax 2d75858589
Add IS_FIRST_AID flag 2022-08-06 15:00:52 +02:00
frutiemax 76104cbbee
Use RIDE_TYPE_FLAG_IS_TOILET 2022-08-06 15:00:52 +02:00
Gymnasiast ab68d7d631
Remove ride type check in JuniorRollerCoaster.cpp 2022-08-06 12:19:27 +02:00
AuraSpecs 5249ae1426
Enlarge Special Elements dropdown 
Enlarging the Special Element dropdown to accomodate for the new longest name "Large Corkscrew (right)" so you can at least make out which direction it's turning in.
 2022-08-06 11:25:25 +02:00
frutiemax d6d43e5b0b
Remove ride type check for reverser upkeep cost 2022-08-05 21:56:28 +02:00
spacek531 468084a401
Move supported track pieces return type to BitSet 2022-08-05 18:55:30 +00:00
Michał Janiszewski 0be5c9d720 Register park being loaded for crash upload 2022-08-04 19:48:47 +02:00
Michał Janiszewski 4243bf0d8e Allow to register additional files for upload in case of crash 2022-08-04 19:48:47 +02:00
Michał Janiszewski b42ff262ef Add more info to 'trigger assert' button 2022-08-04 18:42:34 +02:00
Michał Janiszewski a9fe4da279 Use SDL_ShowMessageBox's 'close' value for dummy UI context 2022-08-04 18:42:34 +02:00
Michał Janiszewski e146ca0853 Make sure to update the screen after displaying an error 2022-08-04 18:42:34 +02:00
Michał Janiszewski c25ebdd1c8 Provide more info in case of write failure 2022-08-04 18:42:34 +02:00
Michał Janiszewski 15fad6b979 Prompt user to submit a bug report on park save failure 2022-08-04 18:42:33 +02:00
Michał Janiszewski a6e84fab5c Add a message box with buttons to UiContext 2022-08-04 18:42:33 +02:00
Michał Janiszewski 0bcb779acb Present more info to user in case of save failure 2022-08-04 18:42:33 +02:00
Basssiiie fe9e60975f
Increment network version for #17638 (#17699) 2022-08-03 19:59:25 +00:00
Nikolas Parshook a44ddd5adc
Refactor NewRideWindow to use Window class 2022-08-03 21:59:03 +02:00
Hielke Morsink faea1ca494
Make rct_window non-copyable and non-assignable 2022-08-03 21:35:25 +02:00
Michael Steenbeek 840f497d85
Merge pull request #17663 from frutiemax/RTD_PoweredLaunchBlock 
Convert PoweredLaunch to PoweredLaunchBlockSectioned when block brake
 2022-08-03 20:09:36 +02:00
Gymnasiast b54ef13c4f
Implement cleaner method for checking mode availability 2022-08-03 19:42:43 +02:00
Hielke Morsink eec99b6fae
Catch window refs by reference instead of copy 2022-08-02 21:55:23 +02:00
Michael Steenbeek 2765ed45d2
Remove now-unnecessary object patches (#17674) 
These 5 objects are now part of the game and all fixes have been integrated.
 2022-08-02 21:53:17 +02:00
Michał Janiszewski e1c2a8b74f
Merge pull request #17634 from OpenRCT2/janisozaur-patch-1 
Build OpenRCT2 with breakpad support in CI
 2022-08-01 15:04:08 -07:00
Michael Steenbeek 56f6828ba9
Fix #17571: Researched rides show up as new vehicles in .park scenarios 2022-08-01 23:46:33 +02:00
Michael Steenbeek 80f0d952ad
Merge pull request #17638 from X123M3-256/new_track_pieces 
Add new track pieces to the hybrid and single rail
 2022-08-01 23:24:22 +02:00
Michał Janiszewski bc51039e8f Don't take screenshot of crashed OpenGL application 2022-08-01 22:24:26 +02:00
Michał Janiszewski f9e870a388 Provide more traces for breakpad 2022-08-01 22:24:26 +02:00
frutiemax 293370c3c5 Convert PoweredLaunch to PoweredLaunchBlockSectioned when block brake 2022-07-31 17:58:58 -04:00
Henry Cheng 281cf137f4
Fix #17639: Duplicate special elements when building upside down 2022-07-31 21:51:08 +00:00
Gymnasiast 9841b4e9e0
Fix naming conflicts 2022-07-31 22:30:18 +02:00
Gymnasiast d3fd31c611
Rename rct_string_id to StringId 2022-07-31 22:30:13 +02:00
Hielke Morsink 5c6db6126d
Take const reference in some window functions 2022-07-31 20:34:33 +02:00
Hielke Morsink 7cb2113252
Apply clang-format rules 2022-07-31 20:34:32 +02:00
Hielke Morsink 274ab7190d
Remove unused function definitions 2022-07-31 20:34:32 +02:00
Hielke Morsink d6525e3cd0
Refactor window functions to take references 7 2022-07-31 17:23:18 +02:00
Hielke Morsink d05d675ed9
Refactor window functions to take references 6 2022-07-31 17:23:17 +02:00
Hielke Morsink 755deeef8e
Refactor window functions to take references 5 2022-07-31 17:23:17 +02:00
Hielke Morsink a258008bef
Refactor window functions to take references 4 2022-07-31 17:23:16 +02:00
Hielke Morsink 523bb8136e
Refactor window functions to take references 3 2022-07-31 17:23:16 +02:00
Hielke Morsink c8605a8763
Refactor window functions to take references 2 2022-07-31 17:23:15 +02:00
Hielke Morsink 76c1bc8980
Refactor window functions to take references 1 2022-07-31 17:23:15 +02:00
Rik Smeets 889293f2b7
Lower default price for the Crooked House (#17655) 
Guests didn't want to pay the previous default price,
even if the ride was brand new.
 2022-07-31 14:07:36 +02:00
frutiemax e96f428c7b
Add RIDE_TYPE_FLAG_HAS_SEAT_ROTATION for multi-dim rollercoaster 2022-07-31 12:01:22 +02:00
Hielke Morsink 099b3c939b Apply regular expressions to format tables 2022-07-31 10:22:46 +01:00
X123M3-256 da710557de Fix bug in ride construction window 2022-07-31 10:22:46 +01:00
X123M3-256 da472ff033 Remove unnecessary changes 2022-07-31 10:22:45 +01:00
X123M3-256 f77a2386ca Remove excess newlines from VehicleSubpositionData 2022-07-31 10:22:45 +01:00
X123M3-256 ffbf8f4706 Fix bit shifts in ride construction window 2022-07-31 10:22:45 +01:00
X123M3-256 0347ee62cb Remove apparently redundant cast 2022-07-31 10:22:45 +01:00
X123M3-256 8090eab2a3 Fix comments in TrackData 2022-07-31 10:22:45 +01:00
X123M3-256 3b7cd1194c Fix formatting 2022-07-31 10:22:44 +01:00
X123M3-256 c6a5a6da5f Allow more than 32 special pieces in construction menu 2022-07-31 10:22:04 +01:00
X123M3-256 77c5bbcafe Finalize track data and G forces 2022-07-31 10:22:04 +01:00
X123M3-256 15d82db8fd Implement zero g rolls, large corkscrews and medium loops 2022-07-31 10:22:00 +01:00
frutiemax aab94437dc
Add RIDE_TYPE_FLAG_HAS_ONE_STATION for gokarts and minigolf 2022-07-31 02:16:48 +02:00
Michał Janiszewski 575bae7ac4
Rename global variable text_palette -> gTextPalette (#17647) 2022-07-30 23:21:34 +02:00
Michał Janiszewski 3c4a07859b
Provide enough space in temp buffer 
```
src/openrct2-ui/windows/Ride.cpp:3338:44: error: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Werror=format-truncation=]
 3338 |     snprintf(buffer, std::size(buffer), "%u", currentValue);
      |

(...)

/usr/include/x86_64-linux-gnu/bits/stdio2.h:71:35: note: ‘__builtin___snprintf_chk’ output between 2 and 6 bytes into a destination of size 5
```
 2022-07-30 23:19:52 +02:00
Michael Steenbeek 92d7c79ac8
Fix #17532: Object Selection allows unselecting all stations 
While it shouldn’t be possible to unselect them under normal circumstances,
I added checks for terrain surfaces and edges as well for good measure.
 2022-07-30 20:01:42 +02:00
Michael Steenbeek 0bfc151ab9
Remove remaining usages of gGameCommandErrorText 2022-07-30 18:04:59 +02:00
Ted John 142b9ff243
Optimise object selection search 
* Do case insensitive string matching for object search.
* Return as soon as first field is a hit.
 2022-07-30 16:50:54 +02:00
frutiemax d556eafc73
Add LightFXAddLightsMagicVehicle to RTD (#17211) 2022-07-30 16:45:41 +02:00
Michael Steenbeek 5a5b107245
Refactor Twist rotations, fix truncating of operating value (#17636) 2022-07-30 16:32:22 +02:00
Hielke Morsink e2da19f0f7
Add missing includes 2022-07-29 18:45:10 +02:00
Michael Steenbeek 2b859c7099
Remove __ENABLE_LIGHTFX__ define 
It is already enabled for all our builds, and upcoming changes to RTD would add a slew more.
Discussed in team chat with Duncan and Hielke.
 2022-07-28 21:34:02 +00:00
Duncan 5f9b0da5ff
Parkinfo object query (#16283) 
* Add basic parkinfo object query

* Cleanup output and remove remnants of future work

* Make review changes

* Update changelog
 2022-07-28 21:20:55 +00:00
Michael Steenbeek 34a7421b98
Remove last references to WINNT 5.1 (#17631) 
Probable oversight from https://github.com/OpenRCT2/OpenRCT2/pull/17411.
 2022-07-28 22:39:04 +02:00
Hielke Morsink 0392925450
Close #16840: Add support for rectangular heightmaps 2022-07-28 20:24:37 +00:00
Gymnasiast 5e8b749277
Fix #17542: Stalls will autorotate towards paths outside the park 2022-07-28 21:26:11 +02:00
Gymnasiast f0777e5418
Introduce constant for construction rights clearance 2022-07-28 21:25:42 +02:00
Raymond Zhao 7399163a3c
Use more smart ptrs and u8strings (#17611) 
* Use smart ptr for PlatformUiContext and WindowManager

* Remove more delete calls

* Apply PR feedback
 2022-07-28 18:19:38 +01:00
Michael Steenbeek e5d2e3001d
Fix buffer size handling for ride operations input 
Ensure a nicely terminated string
 2022-07-28 14:24:19 +02:00
Michael Steenbeek 6852b184b6
Fix #17541: Station style not correctly saved to TD6 2022-07-28 14:23:53 +02:00
Michael Steenbeek a75cc10dd5
Refactor Ride::Open, Ride::Test not to use gGameCommandErrorText 2022-07-28 14:23:33 +02:00
Michael Steenbeek 1a8660d59d
Pass window reference to tool_set (#17625) 2022-07-27 22:22:22 -03:00
frutiemax a3ce24658c
Add StartRideMusic field to RTD 2022-07-27 23:50:20 +00:00
Gymnasiast 39f60c3412
Input current value; fix dodgems mode detection 2022-07-27 23:13:01 +02:00
Rik Smeets 1eb3a86770
Ride operating settings can be set via text input 
Both minimum and maximum wait time and operating settings for flat rides can now be set via text input.
 2022-07-27 22:50:04 +02:00
Michael Steenbeek 30f477972c
Close #15358: Increase park name character limit 2022-07-27 17:35:15 +02:00
Duncan 7433119749
Fix #17620. Missing setting ride id for construction window (#17622) 
This would eventually cause a crash when trying to reset the window on last track piece deletion. Mistake made in refactor #17578
 2022-07-27 16:06:33 +01:00
Michael Steenbeek 710e0e30db
Replace ride type check in S4Importer 
This is more preparation needed to make ride types into objects. Supersedes #17209.
 2022-07-27 12:44:15 +02:00
frutiemax bc72c7e24c
Add UpdateLeaveEntrance field to the RTD (#16986) 
Co-authored-by: frutiemax <frutiemax@users.noreply.github.com>
 2022-07-26 19:33:54 -03:00
Michael Steenbeek 3f56a0eac9
Fix stray white line 2022-07-26 20:08:05 +01:00
Hielke Morsink 6f48ffdf41
Fix #17430: Crash when modifying tile when in multiplayer 2022-07-26 19:47:38 +02:00
Raymond Zhao 4f23e5e9ec
Refactor struct TrackDesignFileRef 
- Refactors track_design_file_ref to TrackDesignFileRef and replaces the utf8* fields of that struct with u8string
- Gets rid of some String::Duplicate() and delete calls
- Uses a bunch of c_str() calls to interface with older functions
 2022-07-26 16:12:46 +00:00
Duncan 68ded02b14
Fix #17605. Prevent crash when parks include missing objects (#17606) 
* Fix #17605. Prevent crash when parks include missing objects

Specifically the park needs to have had removed an object that is referenced within a scenery group object.
 2022-07-26 14:33:30 +00:00
Nikolas Parshook 628da77c0e
Refactor ride construction window (#17578) 2022-07-26 15:17:25 +01:00
Ted John bd6817cb45
Fix #17533: Missing audio when specifying --rct2-data-path 2022-07-25 14:26:28 +00:00
Henry Cheng 08e0b9ae8d
Fix #17508: Grid Doesn't Disable After Setting Patrol Area (#17574) 
* Move show_gridlines to only run under condition

* Update changelog.txt

Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-07-25 13:39:19 +00:00
frutiemax bf432cc943
Add name field to RideTypeDescriptor structure 2022-07-25 00:06:37 +02:00
Hielke Morsink 323fad7b49
Allocate buffer on the stack and improve comments 2022-07-24 20:02:46 +02:00
jazzysoggy c0853b56ad
Fix Format_VA. Rename Format to StdFormat. 
author jazzysoggy <39224097+jazzysoggy@users.noreply.github.com> 1655955994 -0400
committer jazzysoggy <39224097+jazzysoggy@users.noreply.github.com> 1656516326 -0400

Fixed Format_VA and renamed Format to StdFormat. Both now output to Std::String, while taking the same input as before. Changed functions that use these two to account for this output difference
 2022-07-24 19:30:57 +02:00
X123M3-256 55c8a3d775
Add extra vehicle sprite groups (new track pieces part 1) (#17352) 
* Add new sprite groups for zero G rolls

* Fix formatting

* Rename vehicle paint functions

* Fix formatting

* Fix parameter name

* Fix formatting
 2022-07-24 05:40:41 +01:00
AuraSpecs d82360cc16
Add Authors to the list of things you can search for in the Object Selection menu (#17575) 
* Add Authors to Search option

Joint effort from Spacek and karst

* Update changelog.txt

* Apply code review comment

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-07-23 20:28:39 +00:00
Duncan 3edcc91e40
Fix #17339. Reset Scaleing frame buffers on scale change (#17598) 
* Fix #17339. Poor visuals due to scalling incorrectly

Mistake made during refactor meant that the scaleing framebuffers were
kept enabled even though at integer numbers of scale they are not meant
to be used.

* Update changelog
 2022-07-23 20:11:00 +00:00
Henry Cheng 46a2047309
Refactor Server Start Window to Class (#17592) 
* Refactor first

* Update refactor

* Add fixes requested

* Dropped static
 2022-07-23 20:47:17 +01:00
Michał Janiszewski 5688eb511d
Use SDL_free to release SDL_RWops (#17591) 2022-07-22 22:28:58 +00:00
Raymond Zhao 71ad3af930
Use more smart pointers in openrct2-ui (#17582) 
* Use more smart ptrs

* Use move instead of copy ctor
 2022-07-22 11:48:43 +01:00
Karst a74acee961
Fix: Wrong boundboxes for tunnels & terrain. (#17312) 
* Edit Boundboxes

* Make all code consistent

Eight is the magic number
 2022-07-21 07:57:49 +01:00
Raymond Zhao f4df6be8ae
Remove some calls to free (#17577) 2022-07-21 07:50:43 +01:00
Sadret ed18ef1146
Fix #16392: Scenery on sloped surface is placed at wrong height. (#17343) 
* Fix #16392: Scenery on sloped surface is placed at wrong height.

* fix SceneryQuadrantOffset

* fix valley land height

* Bump network version

* update replays

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-07-20 20:33:33 +01:00
Henry Cheng 3bad01a704
Fix #17553: Crash when moving invention list items to empty list (#17555) 
* Fix content check

* Add change log entry

Co-authored-by: Duncan <duncans_pumpkin@hotmail.co.uk>
 2022-07-17 07:12:29 +00:00
Cory Sanin 37a38af6a5
Fix: [#17503] Correct staff refactor issue (#17546) 2022-07-17 07:43:32 +01:00
8street 213696ea27
Add option to sell merchandise in random colours 
Co-authored-by: 8street <nikolai_e@rambler.ru>
 2022-07-12 22:20:49 +00:00
Hielke Morsink fd5c5f546c
Fix #16476: Crash on demolishing maze 2022-07-12 20:28:16 +00:00
Michael Steenbeek 1bf49f95ba
Fix #17444: “Manta Ray” boats slowed down too much in “Ayers Rock” 2022-07-12 20:09:20 +02:00
underdoom fe2f1bad5a
Remove unwanted condition in ride_ratings_update_state_5 2022-07-12 19:58:40 +02:00
Michael Steenbeek 11614d7170
Merge pull request #17486 from duncanspumpkin/inventionWnd 
Invention List Window Class Refactor
 2022-07-12 19:49:03 +02:00
Gymnasiast 452206701a
Drop support for old names for CAR_ENTRY_FLAG_* 2022-07-11 18:06:23 +02:00
Gymnasiast 8871760472
Rename car entry animation flags 2022-07-11 18:06:22 +02:00
Gymnasiast 06c368694a
Update variables containing a CarEntry 2022-07-11 18:06:22 +02:00
Henry Cheng 3d16bca6ab
Add notification for mismatched g2.dat entries size (#17496) 
Added expected number of sprites to StringIds.h and a mismatch check upon loading g2.dat in Drawing.Sprite.cpp. If the mismatch catch fails, then an error is logged and a notification is displayed

* Add improper install warning
 2022-07-08 06:57:24 +02:00
Huu Kim Nguyen c949edd591
Crop giant screenshot to horizontal view-clip area 2022-07-06 23:11:43 +02:00
Michael Steenbeek 94a1351100
Default-initialise rct_g1_element, rct_g1_header (#17501) 2022-07-04 21:42:51 -03:00
underdoom 46b3687a2d
Simplify tile element initialisation 2022-07-04 21:59:09 +02:00
spacek531 312ad3e3ce
Warn user if unsupported vehicle or element used 2022-07-04 19:06:59 +00:00
Gymnasiast be518f48e3
Release v0.4.1 
- Feature: [#16825] Add Alpine Coaster track type.
- Feature: [#17011] Option to show ride vehicles as separate entries when selecting a ride to construct.
- Feature: [#17217] Add FLAC and OGG/vorbis as supported audio formats for ride music objects.
- Feature: [#12328, #17418] Add vehicles for the Hybrid Coaster, Single-Rail Roller Coaster and Classic Mini Roller Coaster.
- Improved: [#7983] The red colour in the ride stat screen and the ride graphs now corresponds better to negative effects on a ride’s stats.
- Improved: [#13966] Music Style dropdown is now sorted by name.
- Improved: [#16978] Tree placement is more natural during map generation.
- Improved: [#16992] The checkbox in the visibility column of the Tile Inspector has been replaced with an eye symbol.
- Improved: [#16999] The maximum price for the park entry has been raised to £999.
- Improved: [#17050] Transparency can be enabled directly without needing see-through enabled first.
- Improved: [#17059] Show Tile Inspector usage hint when nothing is selected.
- Improved: [#17199] Allow creation of Spiral Slide reskins.
- Improved: [#17242] More natural looking shorelines in map generator.
- Improved: [#17328] Parks can now be resized into rectangular shapes from the map and map generation windows.
- Change: [#16952] Make “Object Selection” order more coherent.
- Change: [#17002] Weather no longer resets when converting a save to scenario.
- Change: [#17294] New ride window remembers scroll position per tab instead of highlighted ride.
- Removed: [#16864] Title sequence editor (replaced by plug-in).
- Removed: [#16911, #17411] Residual support for pre-Vista Windows systems.
- Fix: [#13997] Placing a track design interferes with other players building a ride.
- Fix: [#15787] When deselecting "Show banner text in upper case", the banners remain upper case for 10 seconds.
- Fix: [#16539] CustomListView header not clickable when listview is scrolled.
- Fix: [#16799] Browsing “Up” in the Load Save window shows no files, only folders.
- Fix: [#16934] Park size displayed incorrectly in Park window.
- Fix: [#16974] Small scenery ghosts can be deleted.
- Fix: [#16989] Re-focusing maximised window triggers a restore and maximise.
- Fix: [#17005] Unable to set patrol area for first staff member in park.
- Fix: [#17017] [Plugin] Crash when using tile element properties that require a valid ride to be linked.
- Fix: [#17073] Corrupt ride window and random crashes when trains have more than 144 cars.
- Fix: [#17080] “Remove litter” cheat does not empty litter bins.
- Fix: [#17099] Object selection thumbnail box is one pixel too tall.
- Fix: [#17104] Changing map size does not invalidate park size.
- Fix: [#17157] Crash when browsing “Up” to folder with CJK characters in its name.
- Fix: [#17187] Text input window does not resize correctly.
- Fix: [#17197] Segfault when extracting files from the GOG installer.
- Fix: [#17205] Map generator sometimes crashes when not all standard terrain objects are available.
- Fix: [#17221] Object ghosts and tooltips follow invisible cursor when moving the viewport by right-click dragging.
- Fix: [#17255] Cursor position is incorrect when adjusting terrain and water height.
- Fix: [#17257] [Plugin] Add tertiary colour to large scenery scripting API.
- Fix: [#17261] Hand cursor position is incorrect when dragging items in the Inventions List window.
- Fix: [#17292] Rows in shortcut key list stay highlighted when cursor leaves list.
- Fix: [#17295] Pause status not cleared when loading a scenario made from a converted paused save.
- Fix: [#17310] Reversed reversible vehicles not imported properly when loading RCT1 parks.
- Fix: [#17335] [Plugin] Documentation has an incorrect type for PixelData ‘data’ attribute.
- Fix: [#17337] Air Powered Vertical Coaster trains not imported properly when loading RCT1 parks.
- Fix: [#17346] Surface height markers are concealed by sprites of same surface.
- Fix: [#17369] [Plugin] ‘Car.travelBy()’ moves other cars as well.
- Fix: [#17377] When building the park entrance before opening the Footpaths window, the path will be invisible.
- Fix: [#17381] Air Powered Vertical Coaster stat penalty is wrong.
- Fix: [#17399] Guests never generate the being watched thought.
- Fix: [#17433] Wrong T-shirt colours for guests on a Twist ride.
- Fix: [#17450] Ducks can swim on three-corners-up land tile.
- Fix: [#17461] Footpath Railing tooltip showing incorrect tooltip.
- Fix: [#17464] Green Tarmac footpath is not available in the Track Designer.
- Fix: [#17466] New object types not packed in save files.
- Fix: [#17481] Roto-drop cars try going up to top pieces that are ghosts or belong to other rides.
 2022-07-04 18:53:36 +02:00
Duncan 5d896c65b5
Refactor Guest Window to Class 2022-07-03 22:00:37 +02:00
Hielke Morsink 43a98680ac
Fix: Fallback when selecting RCT1 titles while it's not installed 2022-07-03 16:39:27 +02:00
Hielke Morsink d06f564506
Clean up some title sequence code 2022-07-03 16:20:23 +02:00
Hielke Morsink 1578cd816a
Fix #17493: Title sequence defaults to RCT1 
Even while the default config value is "*OPENRCT2", the game failed to find this config ID and fell back to the first sequence in the list instead.
 2022-07-03 16:19:42 +02:00
Cory Sanin 05f1007dd9
Fix #16989: Re-focusing maximised window triggers a restore and maximise 
Fixes #16989 by removing an SDL hack. Originally added to address issue #2158, I can't reproduce this issue with the hack removed. Tested on Linux (by CorySanin) and Windows (by Broxzier).
 2022-07-02 21:48:43 +02:00
Artem Yanenko 019ed54a48
Fix #17377: Park entrance can be placed without path in Scenario Editor 2022-07-02 14:02:27 +00:00
Sadret 544770c0fb
Fix #16539: CustomListView header unclickable when scrolled 2022-07-02 12:34:12 +02:00
Henry Cheng 2246851f6b
Fix #17464: Green Tarmac footpath does not show up in Track Designer 2022-07-02 12:29:41 +02:00
duncanspumpkin 8492453702 Refactor to conform to style. Move uncommon items out of rct_window 2022-07-02 07:53:46 +01:00
duncanspumpkin 144cd5ada7 Complete moving into class 2022-07-02 07:28:16 +01:00
Gymnasiast d42e67ddfe
Reformat the ifs, remove unnecessary parameter 2022-07-01 23:26:40 +02:00
Gymnasiast d936aa48e1
Fix #17481: Roto-drop cars try going up to the wrong top pieces 2022-07-01 18:23:03 +02:00
duncanspumpkin 22f50b8199 Start creating invention list class 2022-07-01 14:57:24 +01:00
Hielke Morsink 9c595ccaa7
Replace 16 with new constant WATER_HEIGHT_STEP 2022-07-01 00:09:27 +02:00
Hielke Morsink 8e509d9669
Remove ObjectType++ operator, ensure ObjectTypes size 2022-06-30 23:13:40 +02:00
Duncan 43562a6899
Window Class Refactor: Invention List Drag (#17415) 
* Start working on drag

* Finish moving invention drag into window class

* Refactor drag item into a window variable

* Remove rct2 comment
 2022-06-30 10:25:18 +01:00
Hielke Morsink ac7331f878
Include <array> and use page count for size 2022-06-30 07:25:24 +00:00
Duncan d6e188d289
Park Window to class (#17364) 
* Start base of class

* Start moving things into class

* Finish porting over

* Refactor to conform more with style

* Add no discard to imageid

* Fix objective window position

* Fix audio on viewport

* Make further fixes

* Move nodiscard again
 2022-06-30 05:37:43 +01:00
Karst 7345dd58fe
Fix: Footpath Railing tooltip showing incorrect tooltip (#17461) 
* Fix Footpath Railing tooltip

* Add changelog entry

* Update src/openrct2-ui/windows/Footpath.cpp

Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
 2022-06-28 21:15:44 -03:00
Henry Cheng 36f43285ad
Close #16688: Remove unused variables on RideConstruction (#17453) 
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
 2022-06-28 21:15:15 -03:00
Hielke Morsink e39fd9226f
Merge pull request #17426 from Broxzier/refactor/variadic-title-commands 2022-06-28 22:55:47 +02:00
Hielke Morsink 2936de5c86
Replace hardcoded 255/0xFF with TUNE_ID_NULL 2022-06-28 22:55:25 +02:00
Hielke Morsink 79ae03fc5e
Rename `command` to avoid ghosting 
It's curious that gcc complains about ghosting here, since the lambda has its own stack pointer, and doesn't capture the outer `command`.
 2022-06-28 21:57:29 +02:00
Hielke Morsink 8e439b9895
Zero-initialize all command arguments 2022-06-28 21:57:29 +02:00
Hielke Morsink 6a017ac761
use std::decay helper type 2022-06-28 21:57:28 +02:00
Hielke Morsink 0e5cfce073
Maintain centre view position when screen resizes 2022-06-28 21:57:28 +02:00
Hielke Morsink 43f49f2483
Fix: commands used as tags don't save in scripting 2022-06-28 21:57:28 +02:00
Hielke Morsink 2b52df87ce
Move scripting command names to command classes 
This way, new commands are required to have this field, or a compiler error will occur.
 2022-06-28 21:57:27 +02:00
Hielke Morsink c8537d57b3
Note for commands used as tags 2022-06-28 21:57:27 +02:00
Hielke Morsink 3da305b82f
Implement follow entity command 2022-06-28 21:57:27 +02:00
Hielke Morsink 239dcb1677
Update title sequence scripting part 2022-06-28 21:57:26 +02:00
Hielke Morsink 1fc2312abd
Move most command logic from sequence player 
This commit also moves everything related to the OpenRCT2::Title namespace.

Can be compiled with ENABLE_SCRIPTING disabled.
 2022-06-28 21:57:26 +02:00
Hielke Morsink 6bfba88845
Move title commands to their own source files 2022-06-28 21:57:26 +02:00
Hielke Morsink debdb0bcda
Make title sequence commands list variadic 2022-06-28 21:54:25 +02:00
Ted John 854655af55
Fix #17466: New object types not packed in save files (#17467) 2022-06-28 19:59:09 +01:00
Ted John c823bf5f7e
Merge pull request #17465 from IntelOrca/fix/17462-audio-crash 
Fix #17462: Crash when zooming or moving around the park
 2022-06-28 19:58:54 +01:00
Sadret 1b154b1b6e
Fix #17450: Ducks can swim on three-corners-up land tile. (#17456) 2022-06-27 21:37:00 -03:00
Ted John 00014adec9 Fix #17462: Crash when zooming or moving around park 
Lock the mixer while disposing an audio source.
 2022-06-28 00:25:57 +01:00
Ted John 83758de284 Prevent ride music popping in loudly 2022-06-28 00:16:40 +01:00
Ted John 585ebed600
Fix #17297: Crash when switching language (#17370) 
* Refactor all uses of IAudioChannel and the audio mixer.
* Use shared_ptr to avoid dead pointers hanging about.
* Reload particular audio channels where necessary after object reload.
 2022-06-27 17:41:53 +01:00
Basssiiie 4d8dd516bf
Fix plugin ‘Car.travelBy()’ moving other cars as well (#17369) 2022-06-26 20:28:54 +01:00
Nicolas Espinosa Mooser 69ff925b1e
Refactor window to class: Staff (#17400) 
* Refactor window to class: Staff
Close OpenRCT2/OpenRCT2#13806
 2022-06-26 07:07:59 +01:00
jazzysoggy f77611dcd2
Fix #17229: Rename G1_FLAG_BMP to G1_FLAG_HAS_TRANSPARENCY (#17441) 
* Renamed All Instance of G1_FLAG_BMP

Renamed all instances of G1_FLAG_BMP to GA_FLAG_HAS_TRANSPARENCY

* Fixed comments and labels

Fixed comments and labels to be more in line with new definitions
 2022-06-25 07:04:40 +01:00
ywnico 2d9e2de603
Fix: Wrong T-shirt colors when riding Twist (#17433) 
A typo in the code had caused the wrong ImageId object to be used when
painting the peeps, resulting in their T-shirts being set to the ride
colors. The peeps are now painted with the correct T-shirt colors.
 2022-06-23 07:07:59 +01:00
Hielke Morsink 5b2d1c2527
Use viewport flag constants in window_scroll_to_location (#17427) 2022-06-21 21:49:56 -03:00
Artem Yanenko 790e237b80
Fix #15787: toggling upper case banners only works after 10 secs 2022-06-21 20:37:45 +02:00
Gymnasiast 20f458b561
Remove outdated comment 2022-06-21 19:05:31 +02:00
Gymnasiast 23e9932c45
Add code to update IDs for hybrid/single-rail 2022-06-21 19:05:31 +02:00
Gymnasiast 486602077e
Use ported RCT1 vehicles for the Classic Mini Roller Coaster 2022-06-21 19:05:31 +02:00
Silent dc7e31f7af
Remove any traces of WinNT5.1 as per #16911 2022-06-20 21:26:40 +02:00
Artem Yanenko 29beb2962d
Fix primary color picker for canvas tent (#17416) 2022-06-20 21:24:09 +02:00
Hielke Morsink 13db5a771b
Annotate hardcoded arrays and verify their sizes 
This also reduces the number of lines within // clang-format comments
 2022-06-16 23:51:24 +02:00
autofire372 d76a21551a
Fix #17381: wrong stat penalty on APVC 
Co-authored-by: duncanspumpkin <duncanspumpkin@users.noreply.github.com>
 2022-06-13 18:31:26 +00:00
frutiemax 9c796816a1
Add DesignCreateMode field to the RTD (#16987) 2022-06-13 08:39:37 -03:00
Hielke Morsink b0ffa9d28e
Add missing includes to VehicleEntry.h (#17376) 2022-06-11 13:48:57 -03:00
MaxMallon f178163fe9
Don't Reset the weather when converting a save to scenario 2022-06-10 09:56:55 +02:00
Sadret 6b29d03475
Fix #17346: Surface height markers are concealed by surface sprites. (#17345) 2022-06-09 20:05:27 +01:00
Sadret 1c7c4c14c2
Add tertiary colour for large scenery to plugin API (#17314) 
Add tertiaryColour to ScTileElement.
 2022-06-09 20:03:32 +01:00
Duncan f0949284c4
Editor Bottom Toolbar Window class (#17358) 
* Move EditorBottomToolbar to window class

* Minor refactoring

* Further refactoring

* keep compilers happy
 2022-06-08 20:54:03 +01:00
Michael Steenbeek a0f5493575
Merge pull request #17353 from duncanspumpkin/intWindRefact 
Refactor a couple internal Window member variables
 2022-06-08 21:42:44 +02:00
Ted John dda5402644 Allow ride music to loop seamlessly without reload 2022-06-08 00:28:57 +01:00
Ted John 704e68a9b4 Fix deadlock due to ogg stream prematurely ending 2022-06-08 00:28:44 +01:00
duncanspumpkin d521327072 use consistent style 2022-06-07 22:35:06 +01:00
duncanspumpkin 249eaa989e Refactor sign internal variables 2022-06-07 22:35:06 +01:00
duncanspumpkin 8fb91c93aa Remove unused news_variables 2022-06-07 22:35:06 +01:00
duncanspumpkin 3dba3984bf Remove map_variables 2022-06-07 22:35:06 +01:00
Michael Steenbeek 3fae2413db
Use “car” instead of the ambiguous “vehicle”, part 1 
Currently, the word “vehicle” is used for both “train” and “car”. This is a first effort towards disambiguation.
 2022-06-07 20:36:20 +00:00
Ted John dcab9d4c9c
Merge pull request #17217 from IntelOrca/flac-support 
Add optional support for streaming FLAC and OGG/vorbis audio.

Galaxy style from OpenMusic is over 40 MiB in wav. FLAC gets it down to about 27 MiB and OGG/vorbis can get it down to just 1.36 MiB. I think vorbis should be our primary format for distributing OpenRCT2 assets due to its low size, but FLAC is available for those who want higher quality assets.
 2022-06-07 21:16:39 +01:00
Duncan 5bae48e505
Fix auto positioning 2022-06-07 14:09:18 +00:00
Duncan bde81c1d34
Move MainWindow into window class (#17351) 2022-06-07 12:06:57 +01:00
Duncan a73df7e376
Remove Editor Main (#17348) 
* Remove editor main window

* Remove editor main completely

* Update src/openrct2/Editor.cpp

Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>

Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
 2022-06-07 08:26:58 +01:00
Ted John 5be41b65f4 Fix flac decoding 2022-06-06 23:41:15 +01:00
Ted John 03d7bb0995 Removed unused variable 2022-06-06 23:41:15 +01:00
Ted John fe2e054f53 Undo change to Drawing.String.cpp 2022-06-06 23:41:15 +01:00
Ted John af2db16914 Disable flac and vorbis for bionic builds 2022-06-06 23:41:15 +01:00
Ted John 29d7c8217f Fix cmake file syntax error 2022-06-06 23:41:15 +01:00
Ted John dc47f4296f Add way of disabling flac and vorbis support 2022-06-06 23:41:14 +01:00
Ted John d493563f7e Fix windows builds 2022-06-06 23:41:14 +01:00
Ted John 95661f4df2 Refactor audio sources 2022-06-06 23:41:14 +01:00
Ted John 274bd921b3 Add ogg vorbis support 2022-06-06 23:41:14 +01:00
Ted John 73ac7954f1 Add flac support 2022-06-06 23:41:14 +01:00
frutiemax 0791b221e5
Add MusicUpdateFunction field to RTD 2022-06-06 21:00:16 +02:00
X123M3-256 4b11a4fc6a
Remove incorrect flags from alpine coaster (#17347) 2022-06-06 20:10:56 +02:00
Michael Steenbeek 88b3e88bdd
Remove Testpaint (#17333) 
TestPaint served us well, but it hasn’t compiled for years, and before that it produced incorrect results for years.
 2022-06-06 10:07:07 +02:00
Michael Steenbeek 3243183680
Fix #17187: Text input window does not resize correctly 
window_set_resize() already invalidates, so no need to call it twice.

Co-authored-by: guljam <guljam@users.noreply.github.com>
 2022-06-06 00:11:29 +02:00
Michael Steenbeek 60659f4a27
Fix #17337: APVC trains not imported properly when loading RCT1 parks 2022-06-05 23:19:35 +02:00
Hielke Morsink d1d1a8507b
Merge pull request #17328 2022-06-05 18:41:57 +02:00
Hielke Morsink 6d04e21518
Make map size spinners in mapgen window functional 2022-06-05 09:49:40 +02:00
Michael Steenbeek 339edcd0f3
Fix #17310: Reversed reversible vehicles not imported properly from S4 2022-06-05 09:40:53 +02:00
Hielke Morsink 7f2f27e826
Show map size inside spinner widgets 2022-06-04 23:23:00 +02:00
Hielke Morsink 49c3f49535
Split X and Y size in mapgen logic 2022-06-04 19:56:31 +02:00
Hielke Morsink 1644cb68d3
Split X and Y map size spinners in mapgen 2022-06-04 11:26:46 +02:00
Hielke Morsink 8d14016c3f
Allow maps to be resized to non-rectangular shapes 2022-06-04 11:26:34 +02:00
spacek531 673ec0fa10
Frames rotation count part 1 (#17106) 
Refactor vehicle sprite groups

rename rotationType to spriteGroup

remove numframes getters from scobject

add sprite groups getters

add documentation to plugin

Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-06-03 23:03:02 +01:00
Ted John 9a4492c704
Fix unable to save landscape in editor 
Audio objects were being unloaded, while they were still in the loaded object list.
 2022-05-30 23:34:29 +02:00
Hielke Morsink 529c1bcd07
Merge pull request #17294 2022-05-30 19:37:57 +02:00
Hielke Morsink c8df66fab9
Log exception when an error occurs 2022-05-29 08:30:42 +02:00
Duncan 1cc2901680
Dropdown Window Class Refactor (#17278) 
* Move dropdown window to class

* Refactor and move locals into member vars

* Deduplicate slightly

* Apply review comments
 2022-05-29 01:06:23 +01:00
Hielke Morsink 3ea70cdeaf
Fix: shortcut key highlight remains when cursor leaves list 2022-05-28 20:55:42 +00:00
MaxMallon a45a788da9
Fix scenarios made from paused saves starting paused 2022-05-28 21:55:34 +02:00
Ted John d56a6a927c
Fix #17276: RollerCoaster Tycoon 1 Title screen music not playing 2022-05-28 13:57:42 +02:00
Hielke Morsink 15581b509d
Fix cursor pivot for land up/down cursor (#17255) 
Co-authored-by: guljam <cube4none@gmail.com>
 2022-05-28 11:53:45 +00:00
Hielke Morsink 205f98560b
Remove highlight when cursor leaves new rides list 2022-05-28 13:09:26 +02:00
Hielke Morsink d709668eab
Remember scroll position instead of ride selection 2022-05-28 13:09:26 +02:00
Hielke Morsink 64eff42c60
Introduce constant for ride tab count 2022-05-28 10:16:41 +02:00
Rik Smeets 275adc9e68
Fix #7983: Change when certain G-forces show up in red 
Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
 2022-05-27 22:09:18 +00:00
X123M3-256 502f06af91
Add "Alpine Coaster" ride type (#16825) 
* Implement "Alpine Coaster" ride type


Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
 2022-05-26 21:28:17 +00:00
Ted John 97c0c4e052
Merge pull request #16975 from IntelOrca/plugin/track-segments 
[Plugin] Add APIs for track segments and track iteration
 2022-05-26 20:33:53 +01:00
Ted John 2db373bb62 Increment plugin API version 2022-05-26 18:37:14 +01:00
Ken Reese 5d52f4fd31
Fixed > 4 to >= 4 in min height check for shore generation (#17280) 2022-05-25 06:48:10 +01:00
Ted John bb102cc1ec Remove null audio source and fix crash on exit 2022-05-23 23:06:41 +01:00
Ted John 6465d42b57 Apply code review changes, auto* 2022-05-23 22:24:56 +01:00
Ted John 2effca59d1 Fix audio source leak 2022-05-23 22:24:56 +01:00
Ted John 2012488956 Fix issues with file finding on Linux 2022-05-23 22:24:56 +01:00
Ted John a2e6691ac2 Add new audio objects for loading sounds 2022-05-23 22:24:56 +01:00
Duncan 5349e6fe88
Window Class Refactor: DebugPaint (#17269) 
* Move debug paint window to class

* Refactor global

* Use ref where possible
 2022-05-22 23:15:39 +01:00
guljam 03882905c8
fix #17247 Closing scenery window resets transparency settings 2022-05-22 22:58:51 +02:00
Hielke Morsink 6b94d8c0bc
Fix overwriting buffer for parent directory when browsing "Up" 2022-05-22 14:32:06 +00:00
guljam 530c62c27b
Fix hand cursor position on Inventions List 2022-05-22 14:02:26 +02:00
Ken Reese eab90843a2
Improve shorelines in map generation (#17242) 2022-05-22 08:05:20 +02:00